Page MenuHomePhabricator
Create Task
Maniphest T201718

Tracking blocks: Log when the desktop VisualEditor + 2010 wikitext editor block notice is displayed
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This is a child of T189724: 👩‍👧 Track how often blocked users attempt to edit

Requirements

  • Add tracking when the "you cannot edit because you are blocked" message appears in the VisualEditor/2017 wikitext editor and in the 2010 wikitext editor.
  • The data should be made available in a Grafana graph, displayed hourly.
  • The circumstances of how this data is logged is documented, including any known limitations.
  • No personally identifyable information (username, IP, block ID, etc.) should be collected.

Details

SubjectRepoBranchLines +/-
Add block notice stats on EditPage.mediawiki/coremaster+26 -7
Add block notice stats on EditPage.mediawiki/corewmf/1.33.0-wmf.6+26 -7
Track when block notices are returned on the apimediawiki/extensions/VisualEditormaster+20 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

• TBolliger triaged this task as Low priority.Aug 10 2018, 8:14 PM
• TBolliger created this task.
• TBolliger moved this task from Untriaged to Cards ready for development on the Anti-Harassment board.
• aezell moved this task from Cards ready for development to AHT Sprint 30 on the Anti-Harassment board.Sep 26 2018, 7:10 PM
• aezell edited projects, added Anti-Harassment (AHT Sprint 30); removed Anti-Harassment.
• aezell moved this task from AHT Sprint 30 to Cards ready for development on the Anti-Harassment board.
• aezell edited projects, added Anti-Harassment; removed Anti-Harassment (AHT Sprint 30).
• alexhollender_WMF unsubscribed.Sep 26 2018, 7:15 PM
dbarratt added a subscriber: dmaza.Oct 23 2018, 5:22 PM
dmaza claimed this task.Oct 23 2018, 5:33 PM
dmaza moved this task from Cards ready for development to AHT Sprint 31 on the Anti-Harassment board.
dmaza edited projects, added Anti-Harassment (AHT Sprint 31); removed Anti-Harassment.
dmaza moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 31) board.Oct 23 2018, 8:35 PM
• TBolliger moved this task from AHT Sprint 31 to AHT Sprint 32 on the Anti-Harassment board.Oct 24 2018, 7:11 PM
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 32); removed Anti-Harassment (AHT Sprint 31).
• aezell moved this task from Ready to In progress on the Anti-Harassment (AHT Sprint 32) board.Oct 24 2018, 7:11 PM
gerritbot subscribed.Nov 7 2018, 10:29 PM

Change 472342 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/VisualEditor@master] Track when block notices are displayed.

https://gerrit.wikimedia.org/r/472342

gerritbot added a project: Patch-For-Review.Nov 7 2018, 10:29 PM
gerritbot added a comment.Nov 8 2018, 4:08 AM

Change 472375 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Track when block notices are displayed.

https://gerrit.wikimedia.org/r/472375

dmaza moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 32) board.Nov 8 2018, 4:52 AM
• TBolliger moved this task from AHT Sprint 32 to AHT Sprint 33 on the Anti-Harassment board.Nov 8 2018, 8:01 PM
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 33); removed Anti-Harassment (AHT Sprint 32).
• TBolliger moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 33) board.
Jdlrobson added a project: Performance-Team.Nov 9 2018, 5:03 PM

Hey performance team! Just tagging you to request you weigh in on this patchset to add wgWikiID to mw.config as I think that impacts your RL plans. Thanks in advance!

• Imarlier added subscribers: Krinkle, • Imarlier.Nov 13 2018, 5:57 PM

@Jdlrobson: @Krinkle is on vacation until middle of next week. Can this wait until then?

• TBolliger added a comment.Nov 13 2018, 6:36 PM
In T201718#4743504, @Imarlier wrote:

@Jdlrobson: @Krinkle is on vacation until middle of next week. Can this wait until then?

If by 'this' you mean deploying this tracking, then reluctantly yes (though strongly preferably not.) If by 'this' you mean for Timo to assess, then that is a question for Jon to answer, not me.

• Imarlier added a comment.Nov 13 2018, 6:47 PM
In T201718#4743631, @TBolliger wrote:
In T201718#4743504, @Imarlier wrote:

@Jdlrobson: @Krinkle is on vacation until middle of next week. Can this wait until then?

If by 'this' you mean deploying this tracking, then reluctantly yes (though strongly preferably not.) If by 'this' you mean for Timo to assess, then that is a question for Jon to answer, not me.

Fair enough. I say go ahead and deploy as is, when @Krinkle comes back from vacation he may have suggestions for other ways to implement, but we can deal with it then.

gerritbot added a subscriber: Esanders.Nov 15 2018, 2:32 PM

Change 472342 abandoned by Dmaza:
Track when block notices are displayed.

Reason:
Based on @Esanders comments we are moving the tracking logic to the client. It does make more sense there

https://gerrit.wikimedia.org/r/472342

dbarratt moved this task from Review to In progress on the Anti-Harassment (AHT Sprint 33) board.Nov 15 2018, 5:25 PM
gerritbot added a comment.Nov 15 2018, 8:07 PM

Change 472342 restored by Dmaza:
Track when block notices are displayed.

https://gerrit.wikimedia.org/r/472342

gerritbot added a comment.Nov 16 2018, 3:41 AM

Change 474020 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Add tracking for block errors on create/edit actions

https://gerrit.wikimedia.org/r/474020

dmaza moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.Nov 16 2018, 4:28 AM
dbarratt moved this task from Review to In progress on the Anti-Harassment (AHT Sprint 33) board.Nov 19 2018, 6:48 PM
dbarratt moved this task from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.Nov 20 2018, 4:53 AM
gerritbot added a comment.Nov 20 2018, 10:31 PM

Change 472342 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Track when block notices are returned on the api

https://gerrit.wikimedia.org/r/472342

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 20 2018, 11:00 PM
dbarratt closed subtask T209633: Track when block notices are displayed on VisualEditor client side as Resolved.Nov 26 2018, 3:29 PM
• TBolliger moved this task from AHT Sprint 33 to AHT Sprint 34 on the Anti-Harassment board.Nov 26 2018, 8:21 PM
• TBolliger edited projects, added Anti-Harassment (AHT Sprint 34); removed Anti-Harassment (AHT Sprint 33).
• TBolliger moved this task from Ready to Review on the Anti-Harassment (AHT Sprint 34) board.Nov 26 2018, 8:34 PM
• Imarlier moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Nov 26 2018, 9:15 PM
gerritbot added a comment.Nov 28 2018, 7:39 PM

Change 476371 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@wmf/1.33.0-wmf.6] Add block notice stats on EditPage.

https://gerrit.wikimedia.org/r/476371

gerritbot added a comment.Nov 28 2018, 7:55 PM

Change 472375 merged by jenkins-bot:
[mediawiki/core@master] Add block notice stats on EditPage.

https://gerrit.wikimedia.org/r/472375

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 28 2018, 8:00 PM
gerritbot added a comment.Nov 29 2018, 12:41 AM

Change 476371 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.6] Add block notice stats on EditPage.

https://gerrit.wikimedia.org/r/476371

Stashbot subscribed.Nov 29 2018, 12:55 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-29T00:55:38Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.6/includes/: Add block notice stats on EditPage (T201718) (duration: 01m 14s)

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Nov 29 2018, 1:00 AM
dmaza moved this task from Review to Done on the Anti-Harassment (AHT Sprint 34) board.Nov 29 2018, 11:56 PM
• TBolliger closed this task as Resolved.Dec 5 2018, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits