Maniphest T202620

Mobile notification toast appears under surface text
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Aug 23 2018, 12:55 PM

Description

For example, the auto-save recovery message:

Details

	Subject	Repo	Branch	Lines +/-
	Add a notifications overlay container to the skin	mediawiki/skins/MinervaNeue	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Esanders	T202620 Mobile notification toast appears under surface text
Resolved	Mooeypoo	T143837 Append mw.notify div to the body instead of content so it is always on top
Resolved	ovasileva	T202466 [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible

Event Timeline

Esanders created this task.Aug 23 2018, 12:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2018, 12:55 PM

• Deskana triaged this task as Medium priority.Aug 28 2018, 6:48 PM

• Deskana added a project: Editing Q1 2018-19 mobile improvements.

• Deskana moved this task from To Triage to Up next on the VisualEditor board.

Esanders mentioned this in T202466: [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible.Aug 31 2018, 3:16 PM

Could be blocked by T202466?

Esanders added a parent task: T202466: [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible.Aug 31 2018, 4:59 PM

JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.Sep 5 2018, 5:49 PM

There are patches attached to T202466 and T143837 that should resolve this issue.

Change 456665 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Add a notifications overlay container to the skin

https://gerrit.wikimedia.org/r/456665

gerritbot added a project: Patch-For-Review.Sep 6 2018, 11:50 AM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Sep 6 2018, 11:50 AM

Esanders claimed this task.Sep 6 2018, 11:55 AM

Change 456665 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add a notifications overlay container to the skin

https://gerrit.wikimedia.org/r/456665

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 6 2018, 5:00 PM

Jdforrester-WMF added a parent task: T143837: Append mw.notify div to the body instead of content so it is always on top.Sep 6 2018, 5:32 PM

Jdforrester-WMF removed a parent task: T143837: Append mw.notify div to the body instead of content so it is always on top.

Jdforrester-WMF added a subtask: T143837: Append mw.notify div to the body instead of content so it is always on top.

Jdforrester-WMF removed a parent task: T202466: [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible.

Jdforrester-WMF added a subtask: T202466: [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible.