Page MenuHomePhabricator
Create Task
Maniphest T203457

Glosses: display the language name instead of the language code
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
Michael
Authored By
Lea_Lacroix_WMDE
Sep 4 2018, 1:18 PM
Tags
Referenced Files
F27257391: Screenshot_20181119_111120.png
Nov 19 2018, 10:13 AM
F27229612: image.png
Nov 15 2018, 1:08 PM
Subscribers
Addshore
gerritbot
• iecetcwcpggwqpgciazwvzpfjpwomjxn
KaMan
Lea_Lacroix_WMDE
Lucas_Werkmeister_WMDE
Lydia_Pintscher

Description

As a LexData editor, I want to understand easily what is the language of the glosses I read and edit.

Problem: Currently, when reading and editing glosses, only the language code (eg "fr") is displayed.
When reading, it would be way better if the language name is displayed (in the language of the user's interface)
When editing or adding a gloss, the user should be able to type either the language code or the language name, and have a suggester.

BDD
GIVEN a Sense with a Gloss
WHEN viewing the page
THEN the language of the Gloss should be indicated by the name of the language in the user interface language

Acceptance criteria:

  • the Gloss section of a Sense uses language names in the user interface language instead of language codes

Details

SubjectRepoBranchLines +/-
Show language of gloss in ui language when viewingmediawiki/extensions/WikibaseLexememaster+51 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lea_Lacroix_WMDE created this task.Sep 4 2018, 1:18 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptSep 4 2018, 1:18 PM
Liuxinyu970226 subscribed.Sep 4 2018, 1:57 PM
• iecetcwcpggwqpgciazwvzpfjpwomjxn subscribed.Sep 4 2018, 2:11 PM
KaMan subscribed.Sep 4 2018, 2:25 PM
Lydia_Pintscher triaged this task as Medium priority.Sep 29 2018, 8:30 PM
Lydia_Pintscher moved this task from incoming to features/bugs for next release (Lexeme page) on the Wikidata Lexicographical data board.
Lydia_Pintscher added a project: Wikidata-Campsite.
Lydia_Pintscher updated the task description. (Show Details)Sep 29 2018, 8:37 PM
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Lydia_Pintscher added a comment.Sep 29 2018, 8:51 PM

I'd be fine with switching to ordering by language name if we can do the same for termbox.

Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 2 2018, 1:13 PM
Addshore set the point value for this task to 8.
Addshore moved this task from Ready to estimate to In Progress on the Wikidata-Campsite board.Oct 2 2018, 1:34 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Oct 9 2018, 9:36 AM
Addshore removed a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Nov 1 2018, 11:14 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Lucas_Werkmeister_WMDE added subscribers: Addshore, Lucas_Werkmeister_WMDE.Nov 7 2018, 3:25 PM

@Addshore This task seems to already have been estimated – was it decided that it didn’t need to be broken down into any subtasks? Because I see at least two parts here, and the client-side stuff seems much harder to me than the server-side stuff.

Michael claimed this task.Nov 8 2018, 8:45 AM
Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot subscribed.Nov 8 2018, 4:57 PM

Change 472497 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Show language of gloss in ui language when viewing

https://gerrit.wikimedia.org/r/472497

gerritbot added a project: Patch-For-Review.Nov 8 2018, 4:57 PM
Michael mentioned this in rEWLE853f1654c4d3: Show language of gloss in ui language when viewing.Nov 8 2018, 4:59 PM
Michael mentioned this in rEWLE11f8c4949040: Show language of gloss in ui language when viewing.Nov 9 2018, 11:59 AM
Michael mentioned this in rEWLE6d12f3a27703: Show language of gloss in ui language when viewing.Nov 9 2018, 12:11 PM
Michael mentioned this in rEWLE2c01fb120017: Show language of gloss in ui language when viewing.Nov 9 2018, 12:59 PM
Michael mentioned this in rEWLE6b08ecae0ced: Show language of gloss in ui language when viewing.Nov 9 2018, 1:42 PM
Michael mentioned this in rEWLE346412b6638b: Show language of gloss in ui language when viewing.Nov 9 2018, 2:32 PM
Michael mentioned this in rEWLE15c175934bae: Show language of gloss in ui language when viewing.Nov 12 2018, 2:52 PM
Michael mentioned this in rEWLEd6037ebbc4ad: Show language of gloss in ui language when viewing.Nov 12 2018, 3:03 PM
Michael mentioned this in rEWLE576cede62194: Show language of gloss in ui language when viewing.Nov 12 2018, 3:12 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 12 2018, 3:33 PM
Michael mentioned this in rEWLE404d8017400b: Show language of gloss in ui language when viewing.Nov 13 2018, 1:53 PM
Michael mentioned this in rEWLEd44e35201864: Show language of gloss in ui language when viewing.Nov 13 2018, 5:16 PM
Michael mentioned this in rEWLE1bbe25fc2682: Show language of gloss in ui language when viewing.Nov 13 2018, 6:20 PM
Michael mentioned this in rEWLE5c75f7651699: Show language of gloss in ui language when viewing.Nov 14 2018, 9:11 AM
gerritbot added a comment.Nov 14 2018, 2:01 PM

Change 472497 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Show language of gloss in ui language when viewing

https://gerrit.wikimedia.org/r/472497

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 14 2018, 3:01 PM
Michael moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 15 2018, 8:31 AM
Addshore moved this task from Test (Verification) to Needs Announcement on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.EditedNov 15 2018, 1:08 PM

Looks good to me on beta

image.png (549×850 px, 33 KB)

Moving to needs announce, not sure if this actually needs an announce though? but I'll let @Lea_Lacroix_WMDE decide
This wont end up being deployed for 2 weeks.

Lucas_Werkmeister_WMDE added a comment.Nov 15 2018, 1:13 PM

Well, the editing part isn’t implemented yet, so that might be confusing to users?

Lydia_Pintscher added a comment.Nov 19 2018, 10:13 AM

Good point! Can we do it in a similar way to monolingual text values? If so I can create a separate ticket for it.

Screenshot_20181119_111120.png (374×1 px, 54 KB)

Addshore added a comment.Nov 20 2018, 7:49 AM
In T203457#4757434, @Lydia_Pintscher wrote:

Good point! Can we do it in a similar way to monolingual text values? If so I can create a separate ticket for it.

Sounds good to me.

Lea_Lacroix_WMDE added a comment.Dec 4 2018, 2:23 PM

Now deployed and announced. Will do another announcement when the changes in editing mode are ready :)

Restricted Application added a project: User-Michael. · View Herald TranscriptDec 4 2018, 2:23 PM
Lea_Lacroix_WMDE moved this task from Needs Announcement to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 4 2018, 2:23 PM
Michael moved this task from 🗃️ Incoming to ✅ my work done on the User-Michael board.Dec 4 2018, 3:29 PM
Lydia_Pintscher closed this task as Resolved.Dec 10 2018, 11:17 AM
KaMan added a comment.Dec 10 2018, 11:58 AM

@Lydia_Pintscher there is visual problem after this task. I formulated it in https://phabricator.wikimedia.org/T211577

Liuxinyu970226 unsubscribed.Dec 12 2018, 2:38 PM
Lydia_Pintscher added a comment.Dec 22 2018, 3:40 PM

Thank you!

Lydia_Pintscher closed subtask T209931: Glosses: display the language name also in edit mode as Resolved.Jan 26 2019, 1:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL