Page MenuHomePhabricator
Create Task
Maniphest T209931

Glosses: display the language name also in edit mode
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem:
The language of a Gloss of a Sense is displayed with its name of the language in the interface language when viewing a Sense. When editing the language code is required. This is confusing.

Solution:
Show the language name and code like it is done for editing of monolingual text values.

Screenshots/mockups:
How it looks for monolingual text:

Screenshot_20181119_111120.png (374×1 px, 54 KB)

BDD
GIVEN a Sense with a Gloss
AND I am in edit mode for that Sense
WHEN entering a new Gloss or editing an existing one
THEN the selector shows the language name in the interface language and the language code in brackets behind it

Acceptance criteria:

  • language name and language code is accepted for input
  • language name and language code are shown in the selector

Details

SubjectRepoBranchLines +/-
Introduce LanguageSelectorWrapper Vue Widgetmediawiki/extensions/WikibaseLexememaster+167 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lydia_Pintscher triaged this task as Medium priority.Nov 20 2018, 11:00 AM
Lydia_Pintscher created this task.
Lydia_Pintscher updated the task description. (Show Details)Nov 20 2018, 11:49 AM
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Addshore set the point value for this task to 5.Nov 20 2018, 2:12 PM
Michael moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Nov 20 2018, 2:13 PM
Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore moved this task from incoming to in progress on the Wikidata board.Nov 21 2018, 8:19 AM
Tarrow claimed this task.Nov 21 2018, 2:23 PM
Tarrow moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Tarrow added a comment.Nov 26 2018, 4:24 AM

extensions/Wikibase/view/lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.languagesuggester.js is what we want to use

Lydia_Pintscher moved this task from incoming to features/bugs for next release (Lexeme page) on the Wikidata Lexicographical data board.Nov 26 2018, 2:16 PM
Lea_Lacroix_WMDE subscribed.Dec 4 2018, 2:24 PM
gerritbot subscribed.Dec 5 2018, 2:59 PM

Change 477790 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] WIP Introduce LanguageSelectorWrapper Vue Widget

https://gerrit.wikimedia.org/r/477790

gerritbot added a project: Patch-For-Review.Dec 5 2018, 2:59 PM
Tarrow mentioned this in rEWLEb2f0026caa6e: WIP Introduce LanguageSelectorWrapper Vue Widget.Dec 5 2018, 3:00 PM
Tarrow mentioned this in rEWLEdb3f65933ec1: Introduce LanguageSelectorWrapper Vue Widget.Dec 11 2018, 10:52 AM
Tarrow added a comment.Dec 12 2018, 10:33 AM

As you can see in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/+/477790 attempting to complete this task by just wrapping the same widget we use for monolingual text had a few issues.

Attempting to follow the pattern for ItemSelectorWrapper which is used by LanguageAndLexicalCategoryWidget resulted in a working selector.

Specifically it is rather tricky to test well.

Indeed it appears that ItemSelectorWrapper isn't actually tested (other than by ruby browsertests) because the templates used in the tests are out of sync with the templates shipped by PHP (see: T198455).

Liuxinyu970226 subscribed.Dec 12 2018, 2:39 PM
Tarrow mentioned this in T211866: LanguageAndLexicalCategoryWidget Vue Test and Prod Template are not in sync.Dec 13 2018, 10:41 AM
Tarrow mentioned this in rEWLE2ee8342e7e61: Introduce LanguageSelectorWrapper Vue Widget.Dec 14 2018, 11:53 AM
Tarrow mentioned this in rEWLEaba3f7576e29: Introduce LanguageSelectorWrapper Vue Widget.Dec 14 2018, 1:52 PM
Tarrow mentioned this in rEWLEb1cade807c67: Introduce LanguageSelectorWrapper Vue Widget.Dec 14 2018, 2:38 PM
Tarrow mentioned this in rEWLEa5a1151aeacb: Introduce LanguageSelectorWrapper Vue Widget.Dec 14 2018, 3:14 PM
Tarrow moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 14 2018, 3:45 PM
Tarrow mentioned this in rEWLE8819cc63f42c: Introduce LanguageSelectorWrapper Vue Widget.Dec 17 2018, 3:52 PM
Tarrow mentioned this in rEWLEbb751bdbf632: Introduce LanguageSelectorWrapper Vue Widget.
Tarrow moved this task from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 3 2019, 11:05 AM
Tarrow removed Tarrow as the assignee of this task.Jan 3 2019, 11:10 AM
Tarrow subscribed.
Tarrow claimed this task.Jan 8 2019, 9:32 AM
Tarrow moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Tarrow moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 8 2019, 9:56 AM
Tarrow mentioned this in rEWLEeb5a1879371b: Introduce LanguageSelectorWrapper Vue Widget.Jan 8 2019, 9:56 AM
Tarrow added a comment.Jan 8 2019, 11:49 AM

It does not appear that deploying this patch without parser cache invalidation will cause cause frontend JS breakages.

I tested this locally by:

  • un-setting my value of $wgParserCacheType = CACHE_NONE.
  • so $wgParserCacheType defaults to CACHE_ANYTHING
  • loading current master
  • loading a lexeme page with a sense
  • updating to https://phabricator.wikimedia.org/rEWLEeb5a1879371b6c77d13e77a1e56f4b3411874082
  • reloading the page and confirming that it still has the old behaviour and no errors in the console
  • purging the cache with action=purge and now confirming it has the new functionality

I believe this is because the frontend JS remains backwards compatible with the old pages in the cache because the new widget simply isn't loaded and a plain <input> is still there.

Addshore removed a subtask: T211749: Invalidate parser cache when Lexeme templates are updated.Jan 8 2019, 11:53 AM
Addshore subscribed.

Removing the subtask then

Tarrow mentioned this in rEWLEf24a1a241ec6: Introduce LanguageSelectorWrapper Vue Widget.Jan 15 2019, 12:18 PM
Tarrow mentioned this in rEWLEe84f321ede16: Introduce LanguageSelectorWrapper Vue Widget.Jan 16 2019, 5:51 PM
gerritbot added a comment.Jan 18 2019, 11:46 AM

Change 477790 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Introduce LanguageSelectorWrapper Vue Widget

https://gerrit.wikimedia.org/r/477790

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 18 2019, 12:00 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 21 2019, 11:04 AM
Lydia_Pintscher closed this task as Resolved.Jan 26 2019, 1:39 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

\o/

Liuxinyu970226 unsubscribed.Jan 28 2019, 5:05 AM
Addshore mentioned this in T211749: Invalidate parser cache when Lexeme templates are updated.Jan 29 2019, 2:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL