Page MenuHomePhabricator

Improve alignment in visual editor table dialog
Closed, ResolvedPublic

Description

The dialog for editing table properties has unnecessary whitespace on the right:

table_dialog.png (661×367 px, 20 KB)

Also on desktop:
image.png (259×493 px, 19 KB)

Event Timeline

It seems the the widget gets 60% of the width (as opposed to the label) by default. Where there are only narrow widgets (e.g. toggle switches, as here), perhaps this should be overridden.

Change 458324 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[VisualEditor/VisualEditor@master] Fix alignment in visual editor table dialog

https://gerrit.wikimedia.org/r/458324

Copying comments from gerrit:

@matmatrex wrote:

I just thought that using 'small' also has a drawback, the dialog title no longer fits in some languages, e.g. German:

image.png (290×319 px, 18 KB)
However this seems like a smaller problem than having the label and widget so far from each other than they hardly seem connected. But I'd like to hear another person say that they think this is okay :)

Or we could go back to medium, but put a width restriction on the form:

image.png (292×523 px, 24 KB)

(max-width: 20em; margin: 0 auto;)

I think that works. Here it is in German:

DesktopMobile
image.png (548×1 px, 65 KB)
image.png (638×362 px, 32 KB)

Change 458324 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix alignment in visual editor table dialog

https://gerrit.wikimedia.org/r/458324

Change 459540 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7926154e3)

https://gerrit.wikimedia.org/r/459540

Change 459540 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7926154e3)

https://gerrit.wikimedia.org/r/459540