Page MenuHomePhabricator
Create Task
Maniphest T204757

[OAuth] PHP Fatal Error: Call to undefined method MediaWiki\Extensions\OAuth\MWOAuthDAOAccessControl::getForHtml()
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Example: https://www.mediawiki.org/wiki/Special:OAuthListConsumers

PHP Fatal Error: Call to undefined method MediaWiki\Extensions\OAuth\MWOAuthDAOAccessControl::getForHtml()
/srv/mediawiki/php-1.32.0-wmf.22/extensions/OAuth/frontend/specialpages/SpecialMWOAuthListConsumers.php:244

#0 /srv/mediawiki/php-1.32.0-wmf.22/extensions/OAuth/frontend/specialpages/SpecialMWOAuthListConsumers.php(244): NO_FUNCTION_GIVEN()
#1 [internal function]: Closure$MediaWiki\Extensions\OAuth\SpecialMWOAuthListConsumers::formatRow(string)
#2 /srv/mediawiki/php-1.32.0-wmf.22/extensions/OAuth/control/MWOAuthDAOAccessControl.php(109): call_user_func(Closure$MediaWiki\Extensions\OAuth\SpecialMWOAuthListConsumers::formatRow;3183, string)
#3 /srv/mediawiki/php-1.32.0-wmf.22/extensions/OAuth/frontend/specialpages/SpecialMWOAuthListConsumers.php(245): MediaWiki\Extensions\OAuth\MWOAuthDAOAccessControl->get(string, Closure$MediaWiki\Extensions\OAuth\SpecialMWOAuthListConsumers::formatRow;3183)
#4 /srv/mediawiki/php-1.32.0-wmf.22/extensions/OAuth/frontend/specialpages/SpecialMWOAuthListConsumers.php(335): MediaWiki\Extensions\OAuth\SpecialMWOAuthListConsumers->formatRow(Wikimedia\Rdbms\DBConnRef, stdClass)
#5 /srv/mediawiki/php-1.32.0-wmf.22/includes/pager/IndexPager.php(445): MediaWiki\Extensions\OAuth\MWOAuthListConsumersPager->formatRow(stdClass)
#6 /srv/mediawiki/php-1.32.0-wmf.22/extensions/OAuth/frontend/specialpages/SpecialMWOAuthListConsumers.php(195): IndexPager->getBody()
#7 /srv/mediawiki/php-1.32.0-wmf.22/extensions/OAuth/frontend/specialpages/SpecialMWOAuthListConsumers.php(51): MediaWiki\Extensions\OAuth\SpecialMWOAuthListConsumers->showConsumerList()
#8 /srv/mediawiki/php-1.32.0-wmf.22/includes/specialpage/SpecialPage.php(569): MediaWiki\Extensions\OAuth\SpecialMWOAuthListConsumers->execute(NULL)
#9 /srv/mediawiki/php-1.32.0-wmf.22/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(868): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(525): MediaWiki->main()
#13 /srv/mediawiki/php-1.32.0-wmf.22/index.php(42): MediaWiki->run()
#14 /srv/mediawiki/w/index.php(3): include(string)
#15 {main}

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix escapeForHtml method nameGergő Tiszamediawiki/extensions/OAuthmaster+1 -1
Fix escapeForHtml method nameHasharmediawiki/extensions/OAuthwmf/1.32.0-wmf.22+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Sep 18 2018, 7:34 PM
gerritbot subscribed.Sep 18 2018, 7:39 PM

Change 461196 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/OAuth@master] Fix escapeForHtml method name

https://gerrit.wikimedia.org/r/461196

gerritbot added a project: Patch-For-Review.Sep 18 2018, 7:40 PM
hashar added a subscriber: Legoktm.Sep 18 2018, 7:40 PM

Comes from https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OAuth/+/456905/ by @Legoktm

The commit message refers to getForHtml() but the method is not added :]

Krinkle edited projects, added: Wikimedia-production-error; removed: Release.Sep 18 2018, 7:46 PM
Krinkle subscribed.

@hashar May wanna use "Create Task" or "Report Application Error" instead of "New sub task" because the latter creates the task as another train release :)

Krinkle moved this task from Untriaged to Nov2019/1.35.wmf.5+ on the Wikimedia-production-error board.Sep 18 2018, 7:47 PM
Krinkle edited parent tasks, added: T191068: 1.32.0-wmf.22 deployment blockers; removed: T204756: DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php.
gerritbot added a comment.Sep 18 2018, 7:50 PM

Change 461199 had a related patch set uploaded (by Hashar; owner: Gergő Tisza):
[mediawiki/extensions/OAuth@wmf/1.32.0-wmf.22] Fix escapeForHtml method name

https://gerrit.wikimedia.org/r/461199

gerritbot added a comment.Sep 18 2018, 7:55 PM

Change 461199 merged by jenkins-bot:
[mediawiki/extensions/OAuth@wmf/1.32.0-wmf.22] Fix escapeForHtml method name

https://gerrit.wikimedia.org/r/461199

gerritbot added a comment.Sep 18 2018, 7:56 PM

Change 461196 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Fix escapeForHtml method name

https://gerrit.wikimedia.org/r/461196

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 18 2018, 8:00 PM
hashar added a comment.Sep 18 2018, 8:05 PM
In T204757#4595329, @Krinkle wrote:

@hashar May wanna use "Create Task" or "Report Application Error" instead of "New sub task" because the latter creates the task as another train release :)

I noticed that :-\ My bad!

Stashbot added a comment.Sep 18 2018, 8:05 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-18T20:05:34Z] <hashar@deploy1001> Synchronized php-1.32.0-wmf.22/extensions/OAuth/frontend/specialpages/SpecialMWOAuthListConsumers.php: Fix escapeForHtml method name - T204757 (duration: 00m 58s)

hashar closed this task as Resolved.Sep 18 2018, 8:05 PM
hashar assigned this task to Tgr.

https://www.mediawiki.org/wiki/Special:OAuthListConsumers is back :]

Liuxinyu970226 unsubscribed.Sep 19 2018, 12:53 AM
Krinkle removed projects: Patch-For-Review, Train Deployments.Oct 10 2018, 8:03 PM
Krinkle removed Release Version.
Restricted Application changed the subtype of this task from "Release" to "Task". · View Herald TranscriptOct 10 2018, 8:03 PM
Krinkle moved this task from Nov2019/1.35.wmf.5+ to Resolved on the Wikimedia-production-error board.Jan 24 2019, 5:33 AM
Aklapper mentioned this in T210338: Phabricator Exception: Construction of a DateTime() with epoch raised.Jul 5 2019, 6:53 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits