Page MenuHomePhabricator
Create Task
Maniphest T206663

1.33.0-wmf.9 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Release Version
1.33.0-wmf.9
Release Date
Dec 17 2018, 12:00 AM

2018 week 51 1.33-wmf.9 Changes wmf/1.33.0-wmf.9

This MediaWiki Train Deployment is scheduled for the week of Monday, December 17th:

Monday December 17thTuesday, December 18thWednesday, December 19thThursday, December 20thFriday
Backports only.Branch wmf.9 and deploy to Group 0 Wikis.Deploy wmf.9 to Group 1 Wikis.Deploy wmf.9 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.9 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.33.0-wmf.8
Next: 1.33.0-wmf.10

Related Objects
Search...

Event Timeline

greg created this task.Oct 10 2018, 5:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 5:23 PM
greg triaged this task as Medium priority.Oct 10 2018, 7:26 PM
zeljkofilipin added a project: User-zeljkofilipin.Oct 11 2018, 9:25 AM
zeljkofilipin awarded a token.
zeljkofilipin subscribed.
Liuxinyu970226 subscribed.Oct 27 2018, 7:40 AM
zeljkofilipin claimed this task.Dec 17 2018, 5:07 PM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptDec 17 2018, 5:07 PM
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Dec 17 2018, 5:08 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin mentioned this in T207046: Code health metrics spike.Dec 17 2018, 5:32 PM
zeljkofilipin mentioned this in T210412: Learn Docker basics.
zeljkofilipin added a subtask: T211885: ErrorException from line 47 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Kartographer/includes/ApiQueryMapData.php: PHP Warning: data error.Dec 18 2018, 11:36 AM
zeljkofilipin mentioned this in T211885: ErrorException from line 47 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Kartographer/includes/ApiQueryMapData.php: PHP Warning: data error.
zeljkofilipin added a subtask: T212217: ErrorException from line 317 of /srv/mediawiki/php-1.33.0-wmf.9/extensions/ExtensionDistributor/includes/specials/SpecialBaseDistributor.php: PHP Notice: Undefined variable: downloadImg.Dec 18 2018, 2:48 PM
zeljkofilipin added a subtask: T212218: Fatal error: Call to undefined function Kartographer\Wikimedia\suppressWarnings() in /srv/mediawiki/php-1.33.0-wmf.9/extensions/Kartographer/includes/ApiQueryMapData.php on line 49 .Dec 18 2018, 3:01 PM
Jdforrester-WMF subscribed.Dec 18 2018, 3:40 PM
zeljkofilipin added a comment.Dec 18 2018, 3:48 PM

Incident report: Incident_documentation/20181218-train-1.33.0-wmf.9

• Mholloway closed subtask T212218: Fatal error: Call to undefined function Kartographer\Wikimedia\suppressWarnings() in /srv/mediawiki/php-1.33.0-wmf.9/extensions/Kartographer/includes/ApiQueryMapData.php on line 49 as Resolved.Dec 19 2018, 12:33 PM
• Mholloway closed subtask T211885: ErrorException from line 47 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Kartographer/includes/ApiQueryMapData.php: PHP Warning: data error as Resolved.Dec 19 2018, 12:43 PM
zeljkofilipin added a comment.Dec 19 2018, 2:34 PM

I've noticed this in mediawiki-errors:

[XBpTUApAIDwAAJyi064AAABS] /w/api.php?format=json&formatversion=2&action=jsondata&title=Original%2FSt.Petersburg%20population%20annotations.tab&uselang=www   ErrorException from line 309 of /srv/mediawiki/php-1.33.0-wmf.9/includes/debug/MWDebug.php: PHP Warning: API call had warnings trying to get remote JsonConfig: warnings={"main":{"*":"Subscribe to the mediawiki-api-announce mailing list at \u003Chttps://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce\u003E for notice of API deprecations and breaking changes. Use [[Special:ApiFeatureUsage]] to see usage of deprecated features by your application."},"revisions":{"*":"Because \"rvslots\" was not specified, a legacy format has been used for the output. This format is deprecated, and in the future the new format will always be used."}}, query={"action":"query","titles":"Data:Original/St.Petersburg population annotations.tab","prop":"revisions","rvprop":"content","continue":""} [Called from JsonConfig\JCUtils::warn in /srv/mediawiki/php-1.33.0-wmf.9/extensions/JsonConfig/includes/JCUtils.php at line 53]

But looks like it's a known problem: T204774: JsonConfig api emits PHP Warning "API call had warnings trying to get remote JsonConfig".

hashar closed subtask T212217: ErrorException from line 317 of /srv/mediawiki/php-1.33.0-wmf.9/extensions/ExtensionDistributor/includes/specials/SpecialBaseDistributor.php: PHP Notice: Undefined variable: downloadImg as Resolved.Dec 19 2018, 4:59 PM
hashar subscribed.Dec 19 2018, 5:07 PM

I will take care of deploying to group1 during the American window at 20:00 UTC (21:00 CET - 11am PST).

hashar removed a subtask: T212335: EventBus or CirrusSearch: DomainException from line 353 of /srv/mediawiki/php-1.33.0-wmf.9/vendor/firebase/php-jwt/src/JWT.php: Unknown JSON error: 5.Dec 19 2018, 8:31 PM
hashar added a comment.Dec 19 2018, 8:46 PM

Deployed and it looks fine so far.

zeljkofilipin added a subtask: T212427: No namespace configured for entity type `form`.Dec 20 2018, 2:28 PM
zeljkofilipin added a comment.Dec 20 2018, 3:30 PM

I've noticed T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database! in the logs, but I found it both for wmf.8 and wmf.9, so it's not new and not blocking the train.

zeljkofilipin added a comment.Dec 20 2018, 3:40 PM

I've also noticed T212430: Exception from ResourceLoaderULSModule (ext.uls.languagenames) on frr.wikipedia.org "JSON serialization of config data failed." for both wmf.8 and wmf.9 so not blocking the train.

zeljkofilipin added a comment.Dec 20 2018, 3:51 PM

T204781: [BUG] GlobalPreferencesFactory emits "PHP Error: in_array() expects parameter 2 to be an array or collection" just made to the top of fatal monitor, but not blocking the train since it's known problem.

greg removed a subtask: T212427: No namespace configured for entity type `form`.Dec 20 2018, 5:02 PM
zeljkofilipin closed this task as Resolved.Dec 20 2018, 5:43 PM
Liuxinyu970226 awarded a token.Dec 31 2018, 12:42 AM
Liuxinyu970226 unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits