Page MenuHomePhabricator
Create Task
Maniphest T208694

wgNoticeProjects should not default to wikimedia projects
Closed, ResolvedPublic
Actions

Description

wgNoticeProjects should default to [].. Miraheze uses CentralNotice and we set wgNoticeProjects to something specific within $wgConf. Rather than the default being overridden, our default somehow gets merged with the extension default. (Our config is here). I am proposing that wgNoticeProjects defaults to [] in the extension, and that the wikimedia values get set in the WMF config files.

Details

SubjectRepoBranchLines +/-
Have wgNoticeProjects default to []mediawiki/extensions/CentralNoticewmf_deploy+2 -18
Have wgNoticeProjects default to []mediawiki/extensions/CentralNoticeREL1_33+2 -18
Have wgNoticeProjects default to []mediawiki/extensions/CentralNoticemaster+2 -18
Set wgNoticeProjects for wikimediaoperations/mediawiki-configmaster+21 -0
Customize query in gerrit

Event Timeline

MacFan4000 created this task.Nov 4 2018, 11:02 PM
Restricted Application added a project: User-MacFan4000. · View Herald TranscriptNov 4 2018, 11:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MacFan4000 added a subscriber: Paladox.Nov 4 2018, 11:08 PM
gerritbot subscribed.Nov 4 2018, 11:09 PM

Change 471662 had a related patch set uploaded (by MacFan4000; owner: MacFan4000):
[mediawiki/extensions/CentralNotice@master] Have wgNoticeProjects default to false

https://gerrit.wikimedia.org/r/471662

gerritbot added a project: Patch-For-Review.Nov 4 2018, 11:09 PM
MacFan4000 updated the task description. (Show Details)Nov 4 2018, 11:38 PM
gerritbot added a comment.Nov 4 2018, 11:42 PM

Change 471663 had a related patch set uploaded (by MacFan4000; owner: MacFan4000):
[operations/mediawiki-config@master] Set wgNoticeProjects for wikimedia

https://gerrit.wikimedia.org/r/471663

MacFan4000 updated the task description. (Show Details)Nov 5 2018, 2:27 PM
• DStrine added a project: Fundraising-Backlog.Nov 5 2018, 4:59 PM
MacFan4000 added a subscriber: MediaWiki-extensions-CentralNotice.Nov 8 2018, 5:38 PM
• DStrine moved this task from Triage to Sprint +3 on the Fundraising-Backlog board.Nov 13 2018, 8:24 PM
MacFan4000 added a comment.Dec 30 2018, 6:39 PM

Commenting for somebody to please review my patches

Jdforrester-WMF subscribed.Jan 1 2019, 2:18 PM
jrbs added subscribers: • Jseddon, Pcoombe, jrbs.Jan 2 2019, 7:35 AM

I see I've been added to the Gerrit patch; I'm not that familiar with the issue, but someone like @Jseddon or @Pcoombe may be moreso.

AndyRussG subscribed.Jan 5 2019, 3:04 AM
In T208694#4846207, @MacFan4000 wrote:

Commenting for somebody to please review my patches

Thanks for the fix! I can take a look over the next few days...

gerritbot added a comment.Mar 25 2019, 5:38 PM

Change 471663 had a related patch set uploaded (by MacFan4000; owner: MacFan4000):
[operations/mediawiki-config@master] Set wgNoticeProjects for wikimedia

https://gerrit.wikimedia.org/r/471663

gerritbot added a comment.Mar 25 2019, 5:38 PM

Change 471662 had a related patch set uploaded (by MacFan4000; owner: MacFan4000):
[mediawiki/extensions/CentralNotice@master] Have wgNoticeProjects default to []

https://gerrit.wikimedia.org/r/471662

• DStrine moved this task from Sprint +3 to FY 2022-2023 on the Fundraising-Backlog board.May 8 2019, 8:25 PM
gerritbot added a comment.Sep 3 2019, 10:50 PM

Change 471663 merged by jenkins-bot:
[operations/mediawiki-config@master] Set wgNoticeProjects for wikimedia

https://gerrit.wikimedia.org/r/471663

Stashbot added a comment.Sep 3 2019, 10:54 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-03T22:54:02Z] <jforrester@deploy1001> Synchronized wmf-config/CommonSettings.php: T208694 Set CentralNotice's wgNoticeProjects for wikimedia (duration: 00m 59s)

gerritbot added a comment.Sep 3 2019, 11:04 PM

Change 534251 had a related patch set uploaded (by MacFan4000; owner: MacFan4000):
[mediawiki/extensions/CentralNotice@REL1_33] Have wgNoticeProjects default to []

https://gerrit.wikimedia.org/r/534251

gerritbot added a comment.Sep 4 2019, 12:03 AM

Change 471662 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Have wgNoticeProjects default to []

https://gerrit.wikimedia.org/r/471662

gerritbot added a comment.Sep 4 2019, 3:32 PM

Change 534469 had a related patch set uploaded (by Jforrester; owner: MacFan4000):
[mediawiki/extensions/CentralNotice@wmf_deploy] Have wgNoticeProjects default to []

https://gerrit.wikimedia.org/r/534469

gerritbot added a comment.Sep 9 2019, 4:06 PM

Change 534251 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@REL1_33] Have wgNoticeProjects default to []

https://gerrit.wikimedia.org/r/534251

gerritbot added a comment.Sep 10 2019, 4:52 PM

Change 534469 abandoned by Jforrester:
Have wgNoticeProjects default to []

Reason:
Done in a large-scale cherry-pick.

https://gerrit.wikimedia.org/r/534469

Jdforrester-WMF closed this task as Resolved.Sep 10 2019, 5:02 PM
Jdforrester-WMF claimed this task.

Done in master, in production, and in REL1_33.

Aklapper removed a subscriber: MediaWiki-extensions-CentralNotice.May 16 2023, 12:56 PM
Restricted Application added a project: affects-Miraheze. · View Herald TranscriptMay 16 2023, 12:56 PM
Restricted Application added a subscriber: Reception123. · View Herald Transcript
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL