Maniphest T209183

Lazy loaded images: Copy `usemap` attribute for image maps
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	eranroz
	Nov 9 2018, 8:48 PM

Description

Note: There are several lazy loaded images bugs T207929, T199351, T209183. We'll probably want to fix these 3 bugs together.

When lazy loading imagemaps lazy loader doesn't set usemap attribute, hence breaking image maps.

How to reproduce:
Go to some article that use imagemap (the image shouldn't be small image, and not in the first section - lazy loading is done only for large images) and compare the desktop and the mobile versions.

Example:

Screen Shot 2018-11-12 at 11.11.43 AM.png (395×373 px, 137 KB)

Production test URL

Acceptance criteria

The usemap attribute is copied across as data-usemap in the placeholder
The usemap attribute is copied across when JS loads the image

QA steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Image_Map_test
Click the are of the image that's Australia

Expected: Can navigate to Australia page like on desktop.

QA Results - Beta

AC	Status	Details
1	✅	T209183#6349100

QA Results - Prod

AC	Status	Details
1	✅	T209183#6371571

Details

	Subject	Repo	Branch	Lines +/-
	Copy `usemap` attribute from original image to lazy loaded	mediawiki/extensions/MobileFrontend	master	+6 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T229472 [EPIC] Fix the various longstanding bugs in the lazy loaded image formatter
		Resolved		ovasileva	T209183 Lazy loaded images: Copy `usemap` attribute for image maps

Event Timeline

eranroz created this task.Nov 9 2018, 8:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2018, 8:48 PM

eranroz added a subscriber: IKhitron.Nov 9 2018, 8:49 PM

Jdlrobson renamed this task from lazy loading images breaks imagemaps to Lazy loaded images: Copy `usemap` attribute for image maps.Nov 12 2018, 7:15 PM

Jdlrobson triaged this task as Medium priority.

Jdlrobson mentioned this in T207929: Lazy loaded images: Styles are not copied across from img tags when an image is lazy loaded.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson mentioned this in T199351: Lazy loaded images: Lazily loaded inline images cause reflow - should retain other classes such as `thumbborder`.

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Nov 12 2018, 9:18 PM

Jdlrobson updated the task description. (Show Details)Nov 27 2018, 5:43 PM

Jdlrobson set the point value for this task to 3.Nov 27 2018, 5:50 PM

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Jan 7 2019, 6:51 PM

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Feb 13 2019, 7:27 PM

Jdlrobson added a parent task: T229472: [EPIC] Fix the various longstanding bugs in the lazy loaded image formatter.Jul 31 2019, 8:28 PM

@ovasileva any chance we can schedule some time for this and the other 3 bugs listed as subtasks post-AMC deploy? (T229472 tracks them)

MBinder_WMF edited projects, added Web-Team-Backlog (Needs Product Owner Decisions); removed Web-Team-Backlog.Aug 7 2019, 4:56 PM

Peter.ovchyn claimed this task.Jul 22 2020, 3:33 PM

Peter.ovchyn edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog (Needs Product Owner Decisions).

Peter.ovchyn moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Peter.ovchyn moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 25 2020, 11:38 AM

Change 616223 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/MobileFrontend@master] Use data-style attribute to transfer styles from original image to lazy loaded

https://gerrit.wikimedia.org/r/616223

gerritbot added a project: Patch-For-Review.Jul 25 2020, 12:05 PM

Jdlrobson updated the task description. (Show Details)Jul 28 2020, 12:30 AM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson reassigned this task from Peter.ovchyn to Edtadros.Jul 28 2020, 4:46 PM

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdlrobson added a subscriber: Peter.ovchyn.

Change 616223 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Copy usemap attribute from original image to lazy loaded

https://gerrit.wikimedia.org/r/616223

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2020, 5:11 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 28 2020, 6:00 PM