| cmadeo | |
| Nov 14 2018, 5:19 PM |
| F28147359: Screenshot_20190207-153658.jpg | |
| Feb 7 2019, 2:40 PM |
| F27221498: image.png | |
| Nov 14 2018, 5:19 PM |
The edit action queue flow includes a number of dialogues that are similar in nature but relate to different tasks, having an image can help to further 'illustrate' the different task types to users. Additionally we can reuse these throughout the app and potentially for fundraising asks.
As an Android user, I would like app dialogues to be friendly and informative. Visual elements help me to navigate through the app.
 |
| Zeplin: https://zpl.io/aN9JzEN |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Create custom dialog with image | apps/android/wikipedia | master | +205 -5 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dbrant | T207332 Create an "App Editor Tasks" list/feed that can be unlocked by active in-app editors | |||
| Resolved | Dbrant | T207333 Add an in-app notification to be sent to users when they unlock the App Editor Tasks list | |||
| Resolved | Sharvaniharan | T209511 Create a custom dialog that includes an image |
Change 475946 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Create custom dialog with image
@cmadeo @schoenbaechler Image for the dialog is not provided in the Zeplin mocks.
Few more questions:
--With the margins provided, and the width of the dialog, along with the text size in mock, the text appearance is not the same. The title runs to 3 lines.
--Left margin of title and description is 24dp, right is 27dp?
Screenshot as of now
https://drive.google.com/open?id=1tg5NtJWY8G4xYI0icO5ZrG_JL8VbeAwS
Sorry about that, updated the Zeplin mock to include an export of the image
Few more questions:
--With the margins provided, and the width of the dialog, along with the text size in mock, the text appearance is not the same. The title runs to 3 lines.
Thanks for the heads up on this, the wrap is a bit unfortunate so I'll work on some new copy. That being said I'm sure this will need to wrap on a bunch of languages (eg. DE, etc).
--Left margin of title and description is 24dp, right is 27dp?
A mistake on my end, the left and right margins should both be 24dp
@cmadeo A very general design question stemming from this task:
In your mock, the negative dialog button ("Maybe Later") is in a different color than the positive button. The standard behavior is for both buttons to be the same color.
We can potentially override this color, but then the question becomes: do we want this style to apply to *all* dialogs in the app, for the sake of consistency? (This would also be the simpler way to go, as long as we're already making customizations.) Or do we want to leave the buttons with the standard (uniform) color?
@Dbrant, my apologies, I had carried this over from iOS without checking Android. Please keep both buttons the same color.
Change 475946 abandoned by Sharvaniharan:
Create custom dialog with image
Reason:
https://gerrit.wikimedia.org/r/#/c/apps/android/wikipedia/ /478764/
Moving this to Blocked to indicate 'Development done and waiting for other tasks for the prototype to be completed, but does not need QA'.
Dialog looks good from a design perspective on 2.7.269-alpha-2019-02-05. Screenshot from ONEPLUS A6003:
Moving it to the “Ready for signoff“ column.