Page MenuHomePhabricator

Design Special:Diff integration for Jade
Open, HighPublic

Description

For past work, see https://en.wikipedia.org/wiki/User:Prtksxna/jade-test.js

  • A user should be able to supply a first labvel for a facet from Special:Diff/<revid>.
  • If a label proposal already exists the relevant diff, then the user should be linked to Jade:Diff/<revid>
    • The user should also be able to clearly see the preferred label.

Event Timeline

awight created this task.Nov 27 2018, 11:06 PM
Harej moved this task from Inbox to Feature Requests on the Jade board.Dec 3 2018, 6:16 PM
Harej renamed this task from Prototype Jade controls on the action=diff page to Jade Mockups: Diff view controls.Dec 19 2018, 11:21 PM
Harej triaged this task as High priority.Mar 19 2019, 9:47 PM
awight removed a subscriber: awight.Mar 21 2019, 4:04 PM
Harej removed a subscriber: Harej.Jul 4 2019, 9:27 AM
Halfak renamed this task from Jade Mockups: Diff view controls to Design Special:Diff integration for Jade.Aug 8 2019, 8:54 PM
Halfak added subscribers: Harej, Halfak.
Halfak updated the task description. (Show Details)Aug 8 2019, 10:07 PM
Prtksxna removed a subscriber: Prtksxna.Aug 8 2019, 11:13 PM
Halfak added a comment.Aug 9 2019, 3:51 PM

I've got some wireframes! In the process of putting together wireframes for Special:Diff, I realized that we should also have UI integrations that appear with "Undo" and "Rollback".

Special:Diff

Here I've added a "Propose label" button for when a label has yet to be proposed. If the user clicks on that, they will be presented with a modal that looks identical to the one we use on Jade pages for selecting "damaging"/"goodfaith" and their complements. Once a label is "published", then a visual representation of the label is presented (again identical to what we see on a Jade page). If a label already exists, then the visual representation of the label is presented along with an "edit" link that would take the editor to the Jade page.

action=edit&undo

Here, I have added a "propose label" button beneath the edit box and above the edit summary & save/preview buttons. If the user clicks on that, they will be presented with a modal that looks identical to the one we use on Jade pages for selecting "damaging"/"goodfaith" and their complements. Once a label is "published", then a visual representation of the label is presented (again identical to what we see on a Jade page). If a label already exists, then the visual representation of the label is presented along with an "edit" link that would take the editor to the Jade page.

action=rollback

Here, the Jade integration appears after the rollback has been completed. As in the other two cases, I have added a "propose label" button to the top of the page. If the user clicks on that, they will be presented with a modal that looks identical to the one we use on Jade pages for selecting "damaging"/"goodfaith" and their complements. Once a label is "published", then a visual representation of the label is presented (again identical to what we see on a Jade page). If a label already exists, then the visual representation of the label is presented along with an "edit" link that would take the editor to the Jade page.

Halfak added a comment.Aug 9 2019, 3:52 PM

One other note: I don't think "edit type" is really relevant for "undo" and "rollback" so I left it out of the mocks. But in theory, we could add that back as well. Things would get complicated for rollback because multiple edits can be rolled back. The editquality of multiple rolled back edits is probably the same, but the edittype probably is not.

Halfak claimed this task.Aug 15 2019, 8:33 PM
Halfak added a subscriber: ACraze.Aug 16 2019, 4:49 PM

Note while talking to @ACraze. We'll be using the "catchall" endpoint for this. So we'll need design work for what to do with the warnings that the endpoint returns.