Help panel: implement support for VisualEditor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Dec 3 2018, 9:39 PM

Description

Currently the CTA only loads on &action=edit from source mode.

Details

Subject	Repo	Branch	Lines +/-
Help Panel: MobileFrontend integration	mediawiki/extensions/GrowthExperiments	master	+23 -11
Add mw.hook() calls when the editor opens and closes	mediawiki/extensions/MobileFrontend	master	+10 -0
Help panel: display the help panel when VisualEditor is opened	mediawiki/extensions/GrowthExperiments	master	+31 -3
Help panel: Move config vars into a data module	mediawiki/extensions/GrowthExperiments	master	+56 -18

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	MMiller_WMF	T206711 [EPIC] Growth: help panel
Resolved	MMiller_WMF	T206717 Help panel: add call-to-action and help panel into the editing UI
Resolved	Catrope	T211059 Help panel: implement support for VisualEditor

Event Timeline

kostajh created this task.Dec 3 2018, 9:39 PM

MMiller_WMF renamed this task from Implement support for VE and MobileFrontend to Help panel: implement support for VE and MobileFrontend.Dec 3 2018, 10:55 PM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 6 2018, 1:39 PM

kostajh mentioned this in T206717: Help panel: add call-to-action and help panel into the editing UI.Dec 6 2018, 3:10 PM

Aklapper removed a subscriber: Growth-Team.Dec 7 2018, 12:53 PM

Catrope claimed this task.Dec 8 2018, 1:31 AM

Catrope moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Catrope added a project: GrowthExperiments.

Change 478381 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Help panel: Move config vars into a data module

https://gerrit.wikimedia.org/r/478381

Change 478382 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Help panel: display the help panel when VisualEditor is opened

https://gerrit.wikimedia.org/r/478382

Catrope mentioned this in rEGRE013f652317e4: Help panel: Move config vars into a data module.Dec 8 2018, 2:13 AM

Catrope mentioned this in rEGRE9f7bd72535c0: Help panel: display the help panel when VisualEditor is opened.

Catrope mentioned this in rEGRE0ff94c3c9d9c: Help panel: Move config vars into a data module.

Catrope mentioned this in rEGRE59f353cbe6f9: Help panel: display the help panel when VisualEditor is opened.

Catrope mentioned this in rEGREb334c9359bcb: Help panel: Move config vars into a data module.Dec 8 2018, 2:17 AM

Catrope mentioned this in rEGRE2e9f3c780911: Help panel: display the help panel when VisualEditor is opened.Dec 8 2018, 2:20 AM

Catrope moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 8 2018, 2:20 AM

Change 478381 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: Move config vars into a data module

https://gerrit.wikimedia.org/r/478381

kostajh mentioned this in rEGREde539dfc0798: Help panel: display the help panel when VisualEditor is opened.Dec 9 2018, 7:30 PM

Change 478382 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: display the help panel when VisualEditor is opened

https://gerrit.wikimedia.org/r/478382

@Catrope looks good! Moving back to "Ready for development" to implement the MobileFrontend bit. We'll probably need to not output the button server side if in a mobile skin, and construct the button to append to the MobileFrontend overlay like you're doing with the VE in this patch.

kostajh moved this task from Code Review to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 9 2018, 7:54 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 9 2018, 8:00 PM

Change 479364 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/MobileFrontend@master] Add mw.hook() calls when the editor opens and closes

https://gerrit.wikimedia.org/r/479364

Change 479365 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Help panel: MobileFrontend integration

https://gerrit.wikimedia.org/r/479365

Catrope mentioned this in rEGRE00f4ef306aaf: Help Panel: MobileFrontend integration.Dec 13 2018, 1:04 AM

Catrope mentioned this in rEGRE8d9cfe179e1e: Help panel: MobileFrontend integration.

kostajh renamed this task from Help panel: implement support for VE and MobileFrontend to Help panel: implement support for VisualEditor.Dec 13 2018, 7:03 PM

kostajh mentioned this in T211913: Help Panel: Implement support for MobileFrontend.

kostajh moved this task from Ready for Development to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 13 2018, 7:12 PM

Change 479364 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add mw.hook() calls when the editor opens and closes

https://gerrit.wikimedia.org/r/479364

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 14 2018, 8:00 PM