Page MenuHomePhabricator
Create Task
Maniphest T212554

Visual editor source editing preview does not link to changed reference footnotes
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Use the Visual editor source editing mode and edit some footnote within <ref>...</ref>. If you then preview your changes with Publish Changes/Show preview and click on the footnote, you will be sent to the original article's (unchanged) footnote text. This is unexpected, unhelpful, and differs from the behavior of the old-fashioned source code editor's preview mode.

Details

SubjectRepoBranchLines +/-
ve.ui.MWSaveDialog: Fix fragment links in visual diff toomediawiki/extensions/VisualEditormaster+1 -0
Fix fragment links in previewmediawiki/extensions/VisualEditormaster+47 -0
Customize query in gerrit

Related Objects

Event Timeline

AxelBoldt created this task.Dec 22 2018, 5:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2018, 5:00 AM
Esanders claimed this task.Jan 3 2019, 5:09 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders set the point value for this task to 1.
gerritbot subscribed.Jan 3 2019, 5:13 PM

Change 482081 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix ref links in preview

https://gerrit.wikimedia.org/r/482081

gerritbot added a project: Patch-For-Review.Jan 3 2019, 5:13 PM
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jan 3 2019, 6:10 PM
gerritbot added a comment.Jan 18 2019, 4:54 PM

Change 482081 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix fragment links in preview

https://gerrit.wikimedia.org/r/482081

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 18 2019, 5:00 PM
Schnark merged a task: T153511: Clicking on a reference note from Preview section of NWE takes me to "https://en.wikipedia.org/wiki/Main_Page#cite_note-1" .Jan 19 2019, 9:00 AM
Schnark added subscribers: Ryasmeen, Wargo, Schnark, Jdforrester-WMF.
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Jan 22 2019, 1:42 AM
Ryasmeen added a comment.Feb 6 2019, 1:05 AM

So what's the expected behavior now? I see that right now, it does not navigate to any page but stays on the Preview section. Is that the change was about?

Ryasmeen added a comment.Feb 6 2019, 1:16 AM

It does highlight the reference when I click on the footnote though.

Esanders added a comment.Feb 7 2019, 1:15 PM

So what's the expected behavior now? I see that right now, it does not navigate to any page but stays on the Preview section. Is that the change was about?

Yes, previously the reference links in the preview would open a new window.

JTannerWMF added a project: Editing QA.Feb 7 2019, 5:44 PM
Esanders moved this task from Inbox to Low Priority on the Editing QA board.Feb 7 2019, 7:06 PM
Ryasmeen added a comment.Feb 7 2019, 9:10 PM

got it, Thanks @Esanders.

Ryasmeen edited projects, added Verified; removed Patch-For-Review.Feb 7 2019, 9:11 PM
Ryasmeen removed a project: Editing QA.
Ryasmeen added a comment.Feb 7 2019, 9:37 PM

@Esanders: Just a quick question though, on VisualDiff when I click on a reference note it opens a new window, is that a separate issue, or is it fixable by this same change?

matmarex added a project: Editing QA.Feb 13 2019, 6:43 PM
Ryasmeen moved this task from QA to Stalled/Waiting on the VisualEditor (Current work) board.Feb 13 2019, 11:45 PM
Ryasmeen removed a project: Editing QA.
gerritbot added a comment.Feb 22 2019, 9:51 PM

Change 492398 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWSaveDialog: Fix fragment links in visual diff too

https://gerrit.wikimedia.org/r/492398

gerritbot added a project: Patch-For-Review.Feb 22 2019, 9:51 PM
matmarex moved this task from Stalled/Waiting to Code review on the VisualEditor (Current work) board.Feb 22 2019, 9:53 PM
matmarex subscribed.

My patch stops the reference footnote links from opening in a new window, but instead they go nowhere, because we don't set the needed ID attributes in the visual diff. I think this is still an improvement (and it is a complete fix for any other links to fragments). We should file a separate task about the remaining issue.

gerritbot added a comment.Feb 23 2019, 6:26 PM

Change 492398 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWSaveDialog: Fix fragment links in visual diff too

https://gerrit.wikimedia.org/r/492398

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.19; 2019-02-26); removed MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Feb 23 2019, 7:00 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Feb 25 2019, 11:25 PM
Ryasmeen added a project: Editing QA.Feb 26 2019, 8:46 PM
Ryasmeen removed projects: Editing QA, Patch-For-Review.Feb 28 2019, 10:37 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

Verified again for the part about visual diff.

ppelberg closed this task as Resolved.Feb 28 2019, 11:34 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 28 2019, 11:34 PM
matmarex mentioned this in T218492: Remove conflicting section anchors in historical visual diffs.Mar 19 2019, 5:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL