Page MenuHomePhabricator
Create Task
Maniphest T212577

Simplify default MT config
Closed, ResolvedPublic
Actions

Description

Currently, MT defaults are managed via config/mt-defaults.wikimedia.yaml, which is difficult to maintain with more and more language pair additions and likely error prone. Split it or manage it via some other way to make sure it is readable and manageable.

Details

SubjectRepoBranchLines +/-
Remove 'source-mt' option for all language pairsmediawiki/services/cxservermaster+0 -856
Customize query in gerrit

Related Objects

Event Timeline

KartikMistry created this task.Dec 23 2018, 2:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2018, 2:27 PM
KartikMistry renamed this task from Simplyfy default MT config to Simplify default MT config.Dec 23 2018, 2:28 PM
KartikMistry added a project: Language-Team (Language-2019-January-March).
Pginer-WMF triaged this task as Medium priority.Dec 27 2018, 11:23 AM
Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-Team (Language-2019-January-March) board.
santhosh added a subscriber: Pginer-WMF.Mar 12 2019, 9:42 AM

There are 855 lines of coniguration that maps language pairs to 'source- mt' https://github.com/wikimedia/mediawiki-services-cxserver/blob/master/config/mt-defaults.wikimedia.yaml

I see no reason to have source-mt as default if there is an MT engine(If not present source-mt become default anyway). The UI allows to easily choose a preferred one and persist that option.

@Pginer-WMF agree?

Pginer-WMF added a comment.Mar 12 2019, 9:47 AM
In T212577#5016813, @santhosh wrote:

@Pginer-WMF agree?

Yes. Makes sense. It seems that can be simplified.

KartikMistry added a comment.Mar 12 2019, 10:58 AM

Some entries are quite old, I'll submit cleaning patch as followups.

gerritbot subscribed.Mar 12 2019, 11:19 AM

Change 495866 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[mediawiki/services/cxserver@master] Remove 'source-mt' option for all language pairs

https://gerrit.wikimedia.org/r/495866

gerritbot added a project: Patch-For-Review.Mar 12 2019, 11:19 AM
KartikMistry claimed this task.Mar 12 2019, 11:19 AM
KartikMistry moved this task from Maintenance backlog to In Progress on the Language-Team (Language-2019-January-March) board.
gerritbot added a comment.Mar 13 2019, 7:17 AM

Change 495866 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Remove 'source-mt' option for all language pairs

https://gerrit.wikimedia.org/r/495866

• Petar.petkovic updated the task description. (Show Details)Mar 13 2019, 9:47 AM
Stashbot subscribed.Mar 14 2019, 7:18 AM

Mentioned in SAL (#wikimedia-operations) [2019-03-14T07:18:50Z] <kartik@deploy1001> Started deploy [cxserver/deploy@3ba57a5]: Update cxserver to b16f4a1 (T212577, T208386)

Stashbot mentioned this in T208386: MT error while translating the big reflist section.Mar 14 2019, 7:18 AM
Stashbot added a comment.Mar 14 2019, 7:22 AM

Mentioned in SAL (#wikimedia-operations) [2019-03-14T07:22:40Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@3ba57a5]: Update cxserver to b16f4a1 (T212577, T208386) (duration: 03m 50s)

KartikMistry moved this task from In Progress to Needs QA - post deployment on the Language-Team (Language-2019-January-March) board.Mar 14 2019, 7:35 AM
Arrbee moved this task from Needs QA - post deployment to Done on the Language-Team (Language-2019-January-March) board.Mar 14 2019, 8:08 AM
• Petar.petkovic removed a project: Patch-For-Review.Mar 14 2019, 8:23 AM
Arrbee closed this task as Resolved.Mar 15 2019, 8:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL