Page MenuHomePhabricator

Review Special:Block design once partial blocks are more fully implemented
Open, NormalPublic3 Story Points

Description

After partial blocking for namespaces, uploading and creating pages is complete, review the design of the Special:Block page - in particular the spacing of the widgets.

Event Timeline

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptJan 10 2019, 4:26 PM
TBolliger triaged this task as Normal priority.Jan 30 2019, 10:49 PM
TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.
TBolliger set the point value for this task to 3.Feb 21 2019, 7:28 PM
TBolliger added a subscriber: TBolliger.

desktop + mobile

make sure nothing jumps

check with Prateek + Dom before closing

Niharika assigned this task to Prtksxna.Apr 3 2019, 11:37 PM
Niharika added a subscriber: Niharika.

Prateek, assigning this to you, whenever you have time to pick this up. If you have suggestions at the end for what to fix/change, please file follow-up tickets. Thank you!

dbarratt moved this task from Heth - ח to Blocked on the Anti-Harassment board.Apr 10 2019, 7:34 PM
dbarratt edited projects, added Anti-Harassment; removed Anti-Harassment (Heth - ח).
Prtksxna added a subscriber: dbarratt.EditedTue, Jul 9, 3:30 AM

@Niharika @dbarratt I had a couple of questions about the page:

  • Why is the "Suppress username from edits and lists." option bold?
    • When is it enabled?
  • What is the expected format for Other time Expiration?

  • Would it make sense to make Editing the last checkbox item (since it has items under it)?
  • Should we add some placeholder text to the extra reason?
    • Do we want to show it even when a reason has been selected from the dropdown?

@Niharika @dbarratt I had a couple of questions about the page:

  • Why is the "Suppress username from edits and lists." option bold?

I think this is because it's only available to privileged users (i.e. not every admin that can see this page will get this option). Similar to the way pages are listed in bold if they are for privileged users on Special:SpecialPages.

See T219931 & T213981

  • When is it enabled?

Users with the hideuser permission will see the option.

  • What is the expected format for Other time Expiration?

This currently accepts anything that strtotime() accepts, however, that function is English-only, so I'd like to fix the format to something we use elsewhere in MediaWiki. However, this will also involve fixing the drop-down values (not the labels) because those use English strings as well. See: T190449

  • Would it make sense to make Editing the last checkbox item (since it has items under it)?

Sure? The only thing I think keeping it at the top is that that is probably the most-popular thing you want to block, but I don't think it necessarily needs to stay in the order it is in.

  • Should we add some placeholder text to the extra reason?

Like what?

  • Do we want to show it even when a reason has been selected from the dropdown?

I feel like if a Reason is selected, then the extra field should be disabled, no? Shouldn't it work like the "Other time" extra field?

  • When is it enabled?

Oh. I misunderstood your question. I listed what you have to do to enable it in T219931

  • Do we want to show it even when a reason has been selected from the dropdown?

I feel like if a Reason is selected, then the extra field should be disabled, no? Shouldn't it work like the "Other time" extra field?

No, because it can be often used to add to the selected reason. For example, when I block someone for inserting false information, I add in the extra reason the name of the page where the false information was added. The drop down has the general concepts, and you can add text to it to make it more specific

No, because it can be often used to add to the selected reason. For example, when I block someone for inserting false information, I add in the extra reason the name of the page where the false information was added. The drop down has the general concepts, and you can add text to it to make it more specific

Ah, I see.

I think this is because it's only available to privileged users (i.e. not every admin that can see this page will get this option). Similar to the way pages are listed in bold if they are for privileged users on Special:SpecialPages.
See T219931 & T213981

Interesting, I wasn't aware of this convention. I am not sure if it is required though. It is also different from the Special pages case where you're probably looking for a needle in a haystack.

This currently accepts anything that strtotime() accepts, however, that function is English-only, so I'd like to fix the format to something we use elsewhere in MediaWiki. However, this will also involve fixing the drop-down values (not the labels) because those use English strings as well. See: T190449

Wow, strototime is quite versatile. Could we add a placeholder text there with a few examples — 1 week or 10 August 2019

  • Do we want to show it even when a reason has been selected from the dropdown?

I feel like if a Reason is selected, then the extra field should be disabled, no? Shouldn't it work like the "Other time" extra field?

No, because it can be often used to add to the selected reason. For example, when I block someone for inserting false information, I add in the extra reason the name of the page where the false information was added. The drop down has the general concepts, and you can add text to it to make it more specific

Thanks @Ciencia_Al_Poder, this is helpful.

  • Should we add some placeholder text to the extra reason?

Like what?

Per @Ciencia_Al_Poder's comment I am thinking something along the lines of Add details about the reason, or Elaborate the reason, but I am not happy with how either of those sound. Suggestions are welcome!

Wow, strototime is quite versatile. Could we add a placeholder text there with a few examples — 1 week or 10 August 2019

We sure can. But I would rather get rid of it. Since strototime() is English-only, the placeholder text would also have to be English-only.. See: T190449

Per @Ciencia_Al_Poder's comment I am thinking something along the lines of Add details about the reason, or Elaborate the reason, but I am not happy with how either of those sound. Suggestions are welcome!

Could it be "help" text rather than a placeholder? Perhaps then it could be a little more verbose?

Wow, strototime is quite versatile. Could we add a placeholder text there with a few examples — 1 week or 10 August 2019

We sure can. But I would rather get rid of it. Since strototime() is English-only, the placeholder text would also have to be English-only.. See: T190449

Ah, I see your point, sorry I missed that link earlier. If adding placeholder text is easy, and T190449 isn't going to happen in the short term, then we could still add it in the mean time.

Per @Ciencia_Al_Poder's comment I am thinking something along the lines of Add details about the reason, or Elaborate the reason, but I am not happy with how either of those sound. Suggestions are welcome!

Could it be "help" text rather than a placeholder? Perhaps then it could be a little more verbose?

We don't need a lot of text to explain the field, maybe something like — The user is blocked because… (I actually like this ). Help text behind the icon is good when we must have long text, we could try to avoid that here.