- On a mobile (or in the Chrome browser mobile simulator) open an article for editing. If an article opens in VE mode, switch to wikitext mode and leave the article to make wikitext mode default.
- Switch to VE mode (this causes UI issues described in T214302)
- Switch to the wikitext mode again and leave the editor using the "X" close button in top-left corner - without any edits. Clicking to start editing (click on the pencil button) will not open the editor again - the page needs to be reloaded. (Leaving the editor using the browser back button does not cause this problem.)
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- T213338: Toggling from VE to source to VE in MobileFrontend breaks
- Mentioned Here
- T215367: [Regression wmf.16] Switching to VE from Wikitext editor is failing on mobile, shows error "TypeError: Cannot read property 'saveFields' of null"
T213120: Restore section hash fragment after section editing in mobile VE
T214302: Appearance broken when switching from source to VE on mobile
Event Timeline
Comment Actions
Agree with high priority. Tagging with our backlog so we can discuss how to triage properly
Comment Actions
I believe this falls under the editing team, since the button is created by VisualEditor. @Esanders please correct me if I'm wrong
Comment Actions
- On a mobile (or in the Chrome browser mobile simulator) open an article for editing. If an article opens in VE mode, switch to wikitext mode and leave the article to make wikitext mode default.
- Switch to VE mode - the toolbar disappears (the double gray line will be displayed). Clicking on the editor options will display jumbled menu options:
Looks like Ed has filed a separate task that covers these two issues: T214302: Appearance broken when switching from source to VE on mobile. And he also fixed them – both problems are fixed on master. I don't know if he found the issue independently, or read your comment here and forgot about the task ;)
- Switch to the wikitext mode again and leave the article - without any edits.
Clicking to start editing (click on the pencil button) will not open editor - the page needs to be reloaded.
This, however, is still a problem.
It seems like the URL is not updated to remove #/editor/0 from it after the editor is closed, and that is why clicking the pencil again does nothing (because you're already at the URL it would navigate to). This also causes funny issues with back/forward navigation.
I'm going to rephrase this task to cover just this issue.
Comment Actions
Change 485975 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] OverlayManager: Emit overlay hide events after using #replaceCurrent
Comment Actions
@Jdlrobson I'd appreciate review from you or other Reading folks, I think the bug is in OverlayManager, and y'all are more familiar with it.
Comment Actions
I'm not sure if this is related, but in T213120 I made the page navigate to the read URL (with a section fragment if required), instead of calling history.back(). The latter seems fragile and problematic, and could be an issue here too?
Comment Actions
Change 485975 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] OverlayManager: Emit overlay hide events after using #replaceCurrent
Comment Actions
This issue is fixed, but there is a new regression:T215367 which seems to be relevant to this.