This task is to make the decision ensure the "SKIP" action is explicitly selected in variation C of the Welcome survey by disabling the ability to dismiss it via pressing escape or clicking outside of the modal.
Per @SBisson, this involves changing the following:
WelcomeSurveyDialog.static.escapable = false;
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | MMiller_WMF | T206365 [EPIC] Growth: Welcome survey | |||
| Resolved | SBisson | T213958 Welcome Survey: disable implicit escape of Variation C |
Change 484751 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Welcome survey C: make unescapable
To clarify, this is not making the survey unskippable whatsoever, there is a prominent SKIP button shown in the modal. This is just removing the extra, unintended ways that users might accidentally close the modal by clicking outside of the modal window or pressing the escape key
Change 484751 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Welcome survey C: make unescapable
Change 485027 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@wmf/1.33.0-wmf.12] Welcome survey C: make unescapable
Change 485033 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@wmf/1.33.0-wmf.13] Welcome survey C: make unescapable
Change 485027 abandoned by Sbisson:
Welcome survey C: make unescapable
Reason:
Wrong branch
Change 485033 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.33.0-wmf.13] Welcome survey C: make unescapable
Mentioned in SAL (#wikimedia-operations) [2019-01-17T19:29:25Z] <catrope@deploy1001> Synchronized php-1.33.0-wmf.13/extensions/GrowthExperiments/: Make welcome survey C unescapable (T213958) (duration: 00m 52s)
Checked in kowiki and cswiki - 'Skip the survey` should be clicked to dismiss the survey.