Page MenuHomePhabricator
Create Task
Maniphest T214811

WTE2017 preview doesn't de-duplicate the categories
Closed, ResolvedPublic
Actions

Description

Sometimes categories of the same name (especially maintenance categories) are emitted in the page. In preview, that looks like this:

image.png (422×1 px, 81 KB)

This is not a representative preview.

(If it matters, this is over Timeless; I expect this issue to be skin-irrelevant.)

Details

SubjectRepoBranchLines +/-
Filter out duplicate categories in NWE previewmediawiki/extensions/VisualEditormaster+21 -17
Customize query in gerrit

Related Objects

Event Timeline

Izno created this task.Jan 28 2019, 2:47 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 28 2019, 2:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Izno renamed this task from Preview doesn't de-duplicate the categories in WTE2017 to WTE2017 preview doesn't de-duplicate the categories.Jan 28 2019, 2:49 AM
Izno updated the task description. (Show Details)
Dvorapa subscribed.Jan 28 2019, 7:34 AM
JTannerWMF moved this task from To Triage to Freezer on the VisualEditor board.Feb 12 2019, 5:06 PM
matmarex claimed this task.Feb 12 2019, 6:18 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.
matmarex subscribed.

This is pretty easy to fix, so I'd like to rescue it from the freezer.

gerritbot subscribed.Feb 12 2019, 6:19 PM

Change 490114 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Filter out duplicate categories in NWE preview

https://gerrit.wikimedia.org/r/490114

gerritbot added a project: Patch-For-Review.Feb 12 2019, 6:19 PM
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Feb 12 2019, 6:19 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 12 2019, 6:50 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Feb 12 2019, 7:06 PM

Change 490114 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Filter out duplicate categories in NWE preview

https://gerrit.wikimedia.org/r/490114

Jdforrester-WMF added a project: MW-1.33-notes (1.33.0-wmf.18; 2019-02-19).Feb 12 2019, 7:42 PM
JTannerWMF added a project: Editing QA.Feb 13 2019, 6:43 PM
• Esanders moved this task from Inbox to Low Priority on the Editing QA board.Feb 13 2019, 6:46 PM
Dvorapa added a comment.Feb 13 2019, 8:37 PM

Hm.. Just wondering why don't we use OWE JavaScript Preview for this? Issues like this has been already debugged in it over the years.

matmarex added a comment.Feb 18 2019, 6:02 PM
In T214811#4952331, @Dvorapa wrote:

Hm.. Just wondering why don't we use OWE JavaScript Preview for this? Issues like this has been already debugged in it over the years.

I don't know, we probably should. Looks like there is task T154844: New Wikitext Editor: Previews should use the article-view rendering engine for this.

Ryasmeen removed a project: Editing QA.Apr 2 2019, 6:33 AM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.May 22 2019, 1:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits