[Story] length limits for Schema inputs
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Lydia_Pintscher
	Jan 29 2019, 12:17 PM

Description

Problem:
We need to set some limits for all the input fields related to Schemas.

BDD:
GIVEN a Schema page
WHEN editing it
AND trying to save a value for the label, description, alias or Schema code that is longer than the limit
THEN an error saying "The input can not be saved because it is too long. The limit is XXX" is shown
AND the edit is not saved

WHEN creating a new Schema via Special:NewSchema
AND trying to save a value for the label, description, alias or Schema code that is longer than the limit
THEN an error saying "The input can not be saved because it is too long. The limit is XXX" is shown
AND the new Schema is not saved

Acceptance criteria:

Editors can not enter data that violates the length limits.
This is validated in the frontend (i.e. in the input) as well

Open questions:

What are the limits?
- Answer: For Labels/Descriptions/Aliases we go with the established limits from Items and Properties. See also T145932: [Bug] Special:NewItem does not validate maximum label length. For the Schema code it is 50 000 bytes but configurable.

Notes:
This should work on ?action=edit, the Special page for editing existing labels/descriptions/aliases as well as the Special page for creating a new Schema.

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T214904 [Story] length limits for Schema inputs
Resolved	Michael	T216147 Implement length limits for schema labels, descriptions, aliases
Resolved	Michael	T216148 Implement length limit for schema text
Resolved	hoo	T218867 Validate length limits for Schema inputs in the front-end

Event Timeline

Lydia_Pintscher created this task.Jan 29 2019, 12:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2019, 12:17 PM

Lydia_Pintscher moved this task from Backlog to Needs work on the EntitySchema board.Jan 29 2019, 12:21 PM

Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.Jan 30 2019, 11:46 AM

Michael updated the task description. (Show Details)Feb 14 2019, 9:59 AM

Michael updated the task description. (Show Details)Feb 14 2019, 10:02 AM

Michael updated the task description. (Show Details)

Lydia_Pintscher updated the task description. (Show Details)Feb 14 2019, 10:10 AM

Lydia_Pintscher updated the task description. (Show Details)

The longest automatically inferred schema by the Wikidata Shape Expressions Inference tool is #23 at 718 039 bytes. MediaWiki’s default [$wgMaxArticleSize](https://www.mediawiki.org/wiki/Manual:$wgMaxArticleSize) is 2048 “kilobytes” (presumably kibibytes, i. e. 2048×1024 = 2 097 152 bytes?), so some schema length limit around one million bytes should be enough to store even large auto-generated schemas while not exceeding the underlying MediaWiki limit.

(I suppose it’s possible to craft schemas that are significantly longer in JSON format, but I’d expect most real schemas to be not much longer in JSON than they are in plain text.)

Decision: we’ll go with a configurable limit that defaults to a lower value, e. g. 50 000 bytes. This will also be indicated client-side via a maxlength on the inputs. (We’ll consider improving the browser’s default behavior for maxlength – just stopping to type / paste more input is a bit user-unfriendly.)

Lydia_Pintscher triaged this task as Medium priority.Feb 24 2019, 3:33 PM

Lydia_Pintscher updated the task description. (Show Details)Feb 24 2019, 3:58 PM

Lucas_Werkmeister_WMDE renamed this task from length limits for Schema inputs to [Story] length limits for Schema inputs.Feb 28 2019, 2:36 PM

Michael edited projects, added Shape Expressions Sprint 4; removed EntitySchema.Mar 12 2019, 2:03 PM

Michael moved this task from Backlog to Doing on the Shape Expressions Sprint 4 board.Mar 14 2019, 12:24 PM

Michael moved this task from Doing to Peer Review on the Shape Expressions Sprint 4 board.Mar 19 2019, 2:45 PM

Lydia_Pintscher closed subtask T216148: Implement length limit for schema text as Resolved.Mar 20 2019, 11:31 AM

Lea_Lacroix_WMDE closed subtask T216147: Implement length limits for schema labels, descriptions, aliases as Resolved.Mar 21 2019, 8:57 AM

Lucas_Werkmeister_WMDE mentioned this in T218867: Validate length limits for Schema inputs in the front-end.Mar 21 2019, 11:26 AM

Lucas_Werkmeister_WMDE moved this task from Peer Review to Backlog on the Shape Expressions Sprint 4 board.

Lucas_Werkmeister_WMDE added a project: Shape Expressions Sprint 5.Mar 25 2019, 2:10 PM

hoo moved this task from Backlog to Verification on the Shape Expressions Sprint 5 board.Mar 26 2019, 10:47 AM