Page MenuHomePhabricator
Create Task
Maniphest T215393

Add edit links for “identifying information” section and “ShExC” section
Closed, ResolvedPublic
Actions

Description

The first links to Special:SetSchemaLabelDescriptionAliases, the second to ?action=edit.

Details

SubjectRepoBranchLines +/-
Add name badge edit links to schema pagesmediawiki/extensions/WikibaseSchemamaster+46 -5
Localize Edit Schema Linkmediawiki/extensions/WikibaseSchemamaster+13 -6
Add Edit Schema Linkmediawiki/extensions/WikibaseSchemamaster+108 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as Medium priority.Feb 6 2019, 10:22 AM
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE removed the point value for this task.
Lydia_Pintscher added a project: Wikidata.Feb 8 2019, 1:25 PM
Michael edited projects, added Shape Expressions Sprint 2; removed EntitySchema.Feb 19 2019, 11:12 AM
Tarrow claimed this task.Feb 20 2019, 10:46 AM
Tarrow moved this task from Backlog to Doing on the Shape Expressions Sprint 2 board.
Tarrow added a subscriber: Lydia_Pintscher.Feb 20 2019, 10:52 AM

@Lydia_Pintscher Any thoughts where the edit links should go? Should it be to the right? and read 'edit'?

gerritbot subscribed.Feb 20 2019, 10:56 AM

Change 491728 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseSchema@master] Add Edit Schema Link

https://gerrit.wikimedia.org/r/491728

gerritbot added a project: Patch-For-Review.Feb 20 2019, 10:57 AM
Tarrow moved this task from Doing to Backlog on the Shape Expressions Sprint 2 board.Feb 20 2019, 10:57 AM
Lydia_Pintscher added a comment.Feb 20 2019, 1:59 PM
In T215393#4968110, @Tarrow wrote:

@Lydia_Pintscher Any thoughts where the edit links should go? Should it be to the right? and read 'edit'?

Yeah let's take the termbox as the guide.

Tarrow moved this task from Backlog to Doing on the Shape Expressions Sprint 2 board.Feb 21 2019, 10:46 AM
Tarrow added a comment.Feb 22 2019, 1:51 PM

Great! I noticed while I was trying to do this without depending on wikibase that wikibase now uses an old version of the oojs-ui icons.
This is how it looks on wikidata:

image.png (35×59 px, 1 KB)

This is how it would look with the current icon set:

image.png (32×61 px, 902 B)

Which is in line with the image used in other mediawiki bits:

image.png (41×131 px, 2 KB)

Patch is up for implementing in the wikibase style but let me know if you would rather have the new one.

Addshore subscribed.EditedFeb 22 2019, 2:31 PM

Related T207190 & T209259?

Lydia_Pintscher added a comment.Feb 22 2019, 3:10 PM

Yes. Sorry. I should have thought of that. There are patches up to change the one on Items to use the oojs-ui one. So let's go with the new one here as well.

Tarrow added a comment.Feb 25 2019, 7:47 AM

Great! I personally like the new one :).

Shex hikers: new patch up is the "more modern" oojs style one

Tarrow removed Tarrow as the assignee of this task.Feb 25 2019, 8:11 AM
Lucas_Werkmeister_WMDE added a project: Shape Expressions Sprint 3.Feb 25 2019, 2:23 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Shape Expressions Sprint 3 board.
gerritbot added a comment.Feb 28 2019, 7:22 PM

Change 491728 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add Edit Schema Link

https://gerrit.wikimedia.org/r/491728

gerritbot added a comment.Mar 1 2019, 2:32 AM

Change 493634 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Localize Edit Schema Link

https://gerrit.wikimedia.org/r/493634

hoo claimed this task.Mar 1 2019, 10:44 AM
gerritbot added a comment.Mar 6 2019, 11:21 PM

Change 494853 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Add name badge edit links to schema pages

https://gerrit.wikimedia.org/r/494853

hoo moved this task from Doing to Peer Review on the Shape Expressions Sprint 3 board.Mar 6 2019, 11:21 PM
gerritbot added a comment.Mar 7 2019, 8:56 AM

Change 493634 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Localize Edit Schema Link

https://gerrit.wikimedia.org/r/493634

gerritbot added a comment.Mar 7 2019, 8:57 AM

Change 494853 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add name badge edit links to schema pages

https://gerrit.wikimedia.org/r/494853

Michael moved this task from Peer Review to Verification on the Shape Expressions Sprint 3 board.Mar 7 2019, 11:30 AM
Lydia_Pintscher moved this task from Verification to Backlog on the Shape Expressions Sprint 3 board.Mar 11 2019, 9:31 AM

Looking good and the link leads to the special page. For some reason the special page doesn't keep the schema ID though and I need to fill it in again.

hoo added a comment.Mar 11 2019, 1:03 PM
In T215393#5014627, @Lydia_Pintscher wrote:

Looking good and the link leads to the special page. For some reason the special page doesn't keep the schema ID though and I need to fill it in again.

Yeah, that's not yet finished on the special page side: T217314: Support subpage syntax.

Lucas_Werkmeister_WMDE added a project: Shape Expressions Sprint 4.Mar 11 2019, 2:10 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Verification on the Shape Expressions Sprint 4 board.
Lydia_Pintscher closed this task as Resolved.Mar 14 2019, 8:46 AM
Lydia_Pintscher moved this task from Verification to Done on the Shape Expressions Sprint 4 board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL