Page MenuHomePhabricator

PHP fatal error: Class undefined: CirrusSearch\Search\EmptyResultSet
Closed, ResolvedPublic

Description

When I search for "Dorota" in Wikidata then I get item page. But when I search in lexeme namespace with "l:" prefix https://www.wikidata.org/w/index.php?search=&search=l%3ADorota&title=Special%3ASearch&go=Przejd%C5%BA then I get PHP fatal error:
Class undefined: CirrusSearch\Search\EmptyResultSet

Event Timeline

KaMan created this task.Feb 7 2019, 11:52 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptFeb 7 2019, 11:55 AM

Looks like some deployment issue - 1.33.0-wmf.14 has this class, but 1.33.0-wmf.16 does not.

Smalyshev triaged this task as Unbreak Now! priority.Feb 7 2019, 6:17 PM

Ah, I see what's up - Wikibase has been updated, but WikibaseLexeme was not.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptFeb 7 2019, 6:17 PM

Change 488985 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@master] Fix fatal error - EmptySet does not exist anymore

https://gerrit.wikimedia.org/r/488985

Also, we probably need some test to capture this situation in the future. Looks like current tests do not cover this branch.

Change 489000 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@wmf/1.33.0-wmf.16] Fix fatal error - EmptySet does not exist anymore

https://gerrit.wikimedia.org/r/489000

Change 488985 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix fatal error - EmptySet does not exist anymore

https://gerrit.wikimedia.org/r/488985

Change 489000 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@wmf/1.33.0-wmf.16] Fix fatal error - EmptySet does not exist anymore

https://gerrit.wikimedia.org/r/489000

Smalyshev closed this task as Resolved.Feb 7 2019, 8:20 PM
Smalyshev claimed this task.

Change 489122 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@master] Add test for empty result

https://gerrit.wikimedia.org/r/489122

Change 489122 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add test for empty result

https://gerrit.wikimedia.org/r/489122