Nearby isn't a WatchstarPageList. Nearby has a WatchstarPageList.
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

None

Authored By

	Jdlrobson
	Mar 7 2019, 1:12 AM

Description

NOTE: Refactoring WatchstarPageList is out of scope for this task. Try to limit yourself to just the Nearby component

Nearby is currently a WatchstarPageList. However at times it also looks like this:

A single MessageBox (error)

Screen Shot 2019-03-06 at 5.04.53 PM.png (97×369 px, 13 KB)

A welcome screen

Screen Shot 2019-03-06 at 5.04.33 PM.png (352×356 px, 27 KB)

A WatchstarPageList

Screen Shot 2019-03-06 at 5.08.27 PM.png (630×685 px, 165 KB)

Acceptance criteria

Nearby no longer extends WatchstarPageList - either use a factory function using a plain View or make
The welcome screen can be rendered outside Nearby.
promisedView pattern is being used to display Nearby results

QA steps

Test this on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby#/coord/37.7889528,-122.4034687 and without results https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby

On Special:Nearby test the following scenarios

Confirm clicking "show nearby articles" shows nearby articles
Ensure Special:Nearby has loaded first. Then drop your WiFi. Click the "show nearby articles" button and confirm an error message is shown
Log in and show nearby articles and confirm a watchstar is displayed (note on staging clicking watchstar will not work, we will need to confim this on beta cluster)

QA Results

AC	Status	Details
1	✅	T217814#5183122
2	✅	T217814#5183122
3	✅	T217814#5183122

Details

	Subject	Repo	Branch	Lines +/-
	Remove the Nearby component and use WatchstarPageList	mediawiki/extensions/MobileFrontend	master	+127 -525
	Remove the Nearby component and use WatchstarPageList	mediawiki/extensions/MobileFrontend	master	+126 -526

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	Jdlrobson	T195482 [EPIC] Review and refactor MobileFrontend components used by Minerva
Open	None	T281930 [EPIC] Migrate MobileFrontend's code to Vue.js and Codex
Declined	None	T212465 [EPIC] None of our View's should exhibit 2 levels of inheritance
Resolved	None	T217814 Nearby isn't a WatchstarPageList. Nearby has a WatchstarPageList.
Resolved	None	T218813 Refactoring Nearby: Remove messageBox template partial inside Nearby

Event Timeline

Jdlrobson triaged this task as High priority.Mar 7 2019, 1:12 AM

Jdlrobson created this task.

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

Jdlrobson mentioned this in T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance.

Jdlrobson raised the priority of this task from High to Needs Triage.Mar 8 2019, 8:03 PM

Jdlrobson moved this task from Backlog to Review and refactor components on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.

ovasileva triaged this task as High priority.Mar 12 2019, 10:08 AM

Jdlrobson updated the task description. (Show Details)Mar 13 2019, 4:19 PM

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Mar 13 2019, 4:26 PM

Jdlrobson set the point value for this task to 8.

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Mar 27 2019, 11:49 AM

Unsure if we're splitting this task up so moving back to needs analysis

@Jdlrobson: T217814#5062730 doesn't have a lot of context (e.g. it may've been a comment written in haste during a meeting). Can you advise whether this task should be split up or reestimated?

Message received. I think the general consensus is we want to work on smaller more contained changes than large changes, so will need time to work this out.

Jdlrobson closed subtask T218813: Refactoring Nearby: Remove messageBox template partial inside Nearby as Resolved.Apr 1 2019, 11:11 PM

Jdlrobson removed a subtask: T220159: Inline templates for mobile editor.Apr 4 2019, 10:35 PM

Change 501445 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Nearby is a dumb component

https://gerrit.wikimedia.org/r/501445

gerritbot added a project: Patch-For-Review.Apr 4 2019, 11:17 PM

I tried to break this down today by exploring the steps I would need to do this, but couldn't find a way. That said, I felt the task was quite straightforward. I think XL exaggerates the work involved here to get rid of the level of inheritance as this component doesn't really seem to be using inheritance for any good reason.

Hopefully this patch demonstrates that.

ovasileva set the point value for this task to 5.Apr 16 2019, 4:51 PM

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Apr 17 2019, 5:08 PM

Jdlrobson moved this task from Upcoming to Readers-Web-Kanbanana-Board-2018-19-Q4 on the Web-Team-Backlog board.Apr 24 2019, 2:04 AM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog.

Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.Apr 24 2019, 11:00 AM

Change 506129 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove the loading overlay usage in Nearby

https://gerrit.wikimedia.org/r/506129

Change 501445 abandoned by Jdlrobson:
Remove the Nearby component and use WatchstarPageList

https://gerrit.wikimedia.org/r/501445

Change 506129 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove the Nearby component and use WatchstarPageList

https://gerrit.wikimedia.org/r/506129

Jdlrobson reassigned this task from Jdlrobson to Edtadros.May 8 2019, 11:40 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.

Jdlrobson updated the task description. (Show Details)

Test Result

Status: ✅
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):QA steps
Test this on https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby#/coord/37.7889528,-122.4034687 and without results https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby

On Special:Nearby test the following scenarios

✅ AC1: Confirm clicking "show nearby articles" shows nearby articles
With Results:
With Huntington Beach, CA set as location

Without Results:
With Kansas City set as location (geolocation override from devtools)

✅ AC2: Drop your WiFi and click the button and confirm an error message is shown
With Results:

Without Results:

✅ AC3: Log in and show nearby articles and confirm a watchstar is displayed (note on staging clicking watchstar will not work, we will need to confim this on beta cluster)+:
With Results:

Without Results:

Edtadros updated the task description. (Show Details)May 14 2019, 11:20 PM

Jdlrobson updated the task description. (Show Details)May 15 2019, 8:06 AM

I've made steps for 2 clearer.
For 3 you'll need to create a page located near you on the beta cluster (this will be helpful for future):

Find a geolocation near you
- Go to Special:Nearby in production, visit a page near you and copy and paste the wikitext of that article to the beta cluster
- You can visit special:nearby and click button and get your location from the URL hash fragment (after # #/coord/50.0,14.4)
- Visit google maps and find a spot near you and find it in the URL there ( e.g. a URL https://www.google.com/maps/place/Pho+Original/@50.0718247,14.4300708,16z/data=!4m5!3m4!1s0x0:0x7049962427680a16!8m2!3d50.0721892!4d14.4371972 - the coordinates are 50.0718247,14.4300708 )
Create a new article on the beta cluster with wikitext substituting 50 and 14 with your location or something near your location (you don't want to share your house!):

{{Coord|50.0|N|14.4|W|display=title|name=random location}}

go make a coffee (might take a few minutes for it to propagate)

@Jdlrobson Thanks for the hints. I enjoyed my coffee. I also discovered after I added the wikitext that I can override geolocation through devtools. Devtools is the gift that keeps on giving.

Edtadros reassigned this task from Jdlrobson to ovasileva.May 16 2019, 9:11 PM

Edtadros added a project: Product-QA (RW-Test-Cases).

Edtadros updated the task description. (Show Details)

Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.

ovasileva removed ovasileva as the assignee of this task.May 20 2019, 9:25 AM

• nray claimed this task.May 20 2019, 5:05 PM

• nray closed this task as Resolved.May 21 2019, 8:42 PM

• nray removed • nray as the assignee of this task.

• nray updated the task description. (Show Details)

• nray subscribed.

ovasileva moved this task from Backlog to Advanced Mobile Contributions on the Product-QA (RW-Test-Cases) board.Mar 2 2020, 6:39 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2020, 7:13 PM

	F29073504: T217814-2b.png
	May 16 2019, 9:08 PM

	F29073260: T217814-2a.png
	May 16 2019, 9:06 PM

	F29073483: T217814-3aa.png
	May 16 2019, 9:06 PM

	F29073463: T217814-3a.png
	May 16 2019, 9:06 PM

Nearby isn't a WatchstarPageList. Nearby has a WatchstarPageList.Closed, ResolvedPublic5 Estimated Story PointsActions