Page MenuHomePhabricator
Create Task
Maniphest T218098

Call to a member function addJsConfigVars() on a non-object (null)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: AWlyJEHYNBo9dX1kEAfZ

message
Call to a member function addJsConfigVars() on a non-object (null)
trace
#0 /srv/mediawiki/php-1.33.0-wmf.21/extensions/MobileFrontend/includes/specials/SpecialMobileOptions.php(63): SpecialMobileOptions->setJsConfigVars()
#1 /srv/mediawiki/php-1.33.0-wmf.21/includes/specialpage/SpecialPage.php(569): SpecialMobileOptions->execute(NULL)
#2 /srv/mediawiki/php-1.33.0-wmf.21/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
#3 /srv/mediawiki/php-1.33.0-wmf.21/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#4 /srv/mediawiki/php-1.33.0-wmf.21/includes/MediaWiki.php(867): MediaWiki->performRequest()
#5 /srv/mediawiki/php-1.33.0-wmf.21/includes/MediaWiki.php(517): MediaWiki->main()
#6 /srv/mediawiki/php-1.33.0-wmf.21/index.php(42): MediaWiki->run()
#7 /srv/mediawiki/w/index.php(3): include(string)
#8 {main}

Impact

Notes

Details

SubjectRepoBranchLines +/-
Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()mediawiki/extensions/MobileFrontendwmf/1.33.0-wmf.21+2 -1
Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()mediawiki/extensions/MobileFrontendwmf/1.33.0-wmf.21+2 -1
Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()mediawiki/extensions/MobileFrontendmaster+2 -1
Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()mediawiki/extensions/MobileFrontendmaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Mar 12 2019, 1:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2019, 1:49 PM
zeljkofilipin triaged this task as Unbreak Now! priority.Mar 12 2019, 1:49 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 12 2019, 1:49 PM
zeljkofilipin added a parent task: T206675: 1.33.0-wmf.21 deployment blockers.Mar 12 2019, 1:49 PM
zeljkofilipin added a project: User-zeljkofilipin.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Untriaged to Sep2019/1.34.wmf.21+ on the Wikimedia-production-error board.
gerritbot subscribed.Mar 12 2019, 2:06 PM

Change 495722 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()

https://gerrit.wikimedia.org/r/495722

gerritbot added a project: Patch-For-Review.Mar 12 2019, 2:06 PM
• Niedzielski merged a task: T218101: PHP Notice: Undefined variable: output.Mar 12 2019, 2:09 PM
zeljkofilipin added a comment.Mar 12 2019, 2:26 PM

Introduced by 492369.

gerritbot added a comment.Mar 12 2019, 2:54 PM

Change 495722 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()

https://gerrit.wikimedia.org/r/495722

zeljkofilipin added subscribers: pmiazga, xSavitar, • Niedzielski.Mar 12 2019, 3:08 PM

@Niedzielski @pmiazga @D3r1ck01 looks like the problem is resolved by 495722. This is still blocking the train. Please backport it to wmf.21 and schedule the backport for a SWAT deploy.

gerritbot added a comment.Mar 12 2019, 3:14 PM

Change 495905 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()

https://gerrit.wikimedia.org/r/495905

• Niedzielski added a comment.Mar 12 2019, 3:24 PM

@zeljkofilipin, backport will be swatted in about an hour. Sorry for the trouble.

gerritbot added a comment.Mar 12 2019, 3:26 PM

Change 495907 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.21] Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()

https://gerrit.wikimedia.org/r/495907

gerritbot added a comment.Mar 12 2019, 3:27 PM

Change 495905 abandoned by Niedzielski:
Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()

Reason:
@Jforrester, it was indeed intended for wmf/1.33.0-wmf.21. Thank you! Superseded by Ifb89a5c92c5c883b5e0b9c6e533302ff5f683b6e.

https://gerrit.wikimedia.org/r/495905

Jdlrobson added a project: Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).Mar 12 2019, 3:41 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
• Niedzielski added a comment.Mar 12 2019, 4:06 PM

backport will be swatted in about an hour.

Correction: I confused the upcoming Puppet deployment window for a swat window. Deployment won't be for ~3 hours.

gerritbot added a comment.Mar 12 2019, 5:09 PM

Change 495945 had a related patch set uploaded (by D3r1ck01; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.21] Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()

https://gerrit.wikimedia.org/r/495945

xSavitar added a comment.Mar 12 2019, 5:10 PM

Backport patch created: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/495945, @Niedzielski, do you want to schedule this for SWAT on wmf.21?

gerritbot added a comment.Mar 12 2019, 5:16 PM

Change 495945 abandoned by D3r1ck01:
Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()

Reason:
In favor of Ifb89a5c92c5c883b5e0b9c6e533302ff5f683b6e

https://gerrit.wikimedia.org/r/495945

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 12 2019, 9:05 PM
gerritbot added a comment.Mar 12 2019, 11:24 PM

Change 495907 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.21] Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()

https://gerrit.wikimedia.org/r/495907

Stashbot subscribed.Mar 12 2019, 11:33 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-12T23:33:02Z] <thcipriani@deploy1001> Synchronized php-1.33.0-wmf.21/extensions/MobileFrontend/includes/specials/SpecialMobileOptions.php: SWAT: [[gerrit:495907|Fix: undefined locals in SpecialMobileOptions.setJsConfigVars()]] T218098 (duration: 00m 57s)

zeljkofilipin closed this task as Resolved.Mar 13 2019, 11:38 AM
zeljkofilipin claimed this task.
Liuxinyu970226 unsubscribed.Mar 16 2019, 1:23 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 12:03 AM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.21; 2019-03-12); removed MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 1:02 AM
Krinkle moved this task from Sep2019/1.34.wmf.21+ to Resolved on the Wikimedia-production-error board.May 6 2019, 6:18 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL