Page MenuHomePhabricator
Create Task
Maniphest T218220

Make mobileapps & proton swagger spec compliant
Closed, ResolvedPublic
Actions

Description

See parent task T218217: Make services swagger specs standard compliant

Blocked until T225707: Upgrade python-service-checker across the fleet is resolved

Details

SubjectRepoBranchLines +/-
Fix: swagger spec x-amples schemamediawiki/services/chromium-rendermaster+94 -103
Update swagger spec to 3.0mediawiki/services/chromium-rendermaster+286 -171
Use upstream swagger-uimediawiki/services/chromium-rendermaster+49 -20
Update spec to OpenAPI 3.0mediawiki/services/mobileappsmaster+2 K -2 K
Use upstream swagger-uimediawiki/services/mobileappsmaster+2 K -1 K
Use upstream swagger-uimediawiki/services/mobileappsmaster+1 K -67
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Jhernandez created this task.Mar 13 2019, 3:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2019, 3:37 PM
• Jhernandez triaged this task as High priority.Mar 13 2019, 3:37 PM
• Jhernandez moved this task from Needs triage to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.
MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.Apr 2 2019, 3:47 PM
MSantos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Tgr added a project: Proton.Apr 2 2019, 9:52 PM
Tgr subscribed.
MSantos claimed this task.Apr 3 2019, 2:47 PM
gerritbot added a comment.Apr 15 2019, 7:05 PM

Change 504079 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/mobileapps@master] WIP: Use upstream swagger-ui

https://gerrit.wikimedia.org/r/504079

gerritbot added a project: Patch-For-Review.Apr 15 2019, 7:05 PM
gerritbot added a comment.Apr 18 2019, 3:06 PM

Change 504891 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/chromium-render@master] Use upstream swagger-ui

https://gerrit.wikimedia.org/r/504891

MSantos mentioned this in rMSCR31795e1d79e6: Use upstream swagger-ui.Apr 18 2019, 3:20 PM
MSantos mentioned this in rMSCRff4e86f4cb3a: Use upstream swagger-ui.Apr 29 2019, 8:14 PM
gerritbot added a comment.May 8 2019, 1:44 PM

Change 508825 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/mobileapps@master] Use upstream swagger-ui

https://gerrit.wikimedia.org/r/508825

gerritbot added a comment.May 21 2019, 8:34 PM

Change 508825 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Use upstream swagger-ui

https://gerrit.wikimedia.org/r/508825

gerritbot added a comment.Jun 5 2019, 12:41 AM

Change 514414 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/mobileapps@master] Update spec to OpenAPI 3.0

https://gerrit.wikimedia.org/r/514414

gerritbot added a comment.Jun 5 2019, 12:42 AM

Change 504079 abandoned by MSantos:
Use upstream swagger-ui

Reason:
Patch sliptted into more than one change. When Ibea93c3b790f2624f63380a8bcde95221f438ced is merged all functionality here will be fulfilled.

https://gerrit.wikimedia.org/r/504079

MSantos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 11 2019, 7:56 PM
MSantos changed the task status from Open to Stalled.Jun 18 2019, 10:24 PM
MSantos updated the task description. (Show Details)
MSantos moved this task from Code Review to Blocked on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Moving to blocked to reflect reality. Blocked until T225707 is resolved.

MSantos removed a project: Patch-For-Review.Jun 18 2019, 10:27 PM
MSantos moved this task from Blocked to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 24 2019, 1:17 PM
gerritbot added a comment.Jul 2 2019, 4:58 PM

Change 520273 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/chromium-render@master] Update swagger spec to 3.0

https://gerrit.wikimedia.org/r/520273

gerritbot added a project: Patch-For-Review.Jul 2 2019, 4:58 PM
MSantos changed the task status from Stalled to Open.Jul 2 2019, 5:01 PM
MSantos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
MSantos mentioned this in rMSCRecf63e3e28cd: Update swagger spec to 3.0.Jul 2 2019, 5:36 PM
MSantos mentioned this in rMSCR56a698547a82: Update swagger spec to 3.0.Jul 2 2019, 8:04 PM
gerritbot added a comment.Jul 2 2019, 8:49 PM

Change 514414 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Update spec to OpenAPI 3.0

https://gerrit.wikimedia.org/r/514414

gerritbot added a comment.Jul 2 2019, 8:50 PM

Change 520273 merged by jenkins-bot:
[mediawiki/services/chromium-render@master] Update swagger spec to 3.0

https://gerrit.wikimedia.org/r/520273

MSantos moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jul 2 2019, 9:14 PM
MSantos moved this task from To Deploy to Blocked on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jul 9 2019, 3:10 PM
MSantos added subscribers: • Pchelolo, • mobrovac.Jul 19 2019, 7:51 PM

@Pchelolo and @mobrovac we tried to deploy mobileapps a while ago and service-checker complained about.

I'm marking this as stalled for now, but don't know the criteria to push these changes forward, could you outline those, please? Which means, what needs to be deployed/developed so we can change the services spec swagger version.

• Pchelolo added a comment.Aug 5 2019, 4:07 PM

Service-checker supports swagger 3 definitions. Do you have any more info about what was in complained about?

Also, when upgrading RESTBase we found it useful to include a spec validity unit test.

gerritbot added a comment.Aug 5 2019, 10:13 PM

Change 504891 abandoned by MSantos:
Use upstream swagger-ui

Reason:
This should be abandoned in favor of I07489ed86738fa0caedc897e6c06412f10e040ef

https://gerrit.wikimedia.org/r/504891

MSantos moved this task from Blocked to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 6 2019, 3:34 PM
MSantos moved this task from Sign off to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
MSantos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 12 2019, 4:39 PM
MSantos moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 13 2019, 8:27 PM
Stashbot added a comment.Aug 15 2019, 5:58 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-15T17:58:11Z] <mbsantos@deploy1001> Started deploy [proton/deploy@fb0b2a5]: Update chromium-renderer to 3f1cc72 (T218220)

Stashbot added a comment.Aug 15 2019, 5:58 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-15T17:58:53Z] <mbsantos@deploy1001> Finished deploy [proton/deploy@fb0b2a5]: Update chromium-renderer to 3f1cc72 (T218220) (duration: 00m 43s)

gerritbot added a comment.Aug 15 2019, 6:48 PM

Change 530437 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/chromium-render@master] Fix: swagger spec x-amples schema

https://gerrit.wikimedia.org/r/530437

gerritbot added a comment.Aug 17 2019, 2:56 AM

Change 530437 merged by jenkins-bot:
[mediawiki/services/chromium-render@master] Fix: swagger spec x-amples schema

https://gerrit.wikimedia.org/r/530437

MSantos mentioned this in rMSCRc4fbe706fd37: Fix: swagger spec x-amples schema.Aug 17 2019, 2:57 AM
MSantos mentioned this in T199101: Validate swagger definitions and test them against a set of responses from the services.Sep 2 2019, 4:52 PM
• Mholloway moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Nov 5 2019, 3:29 PM
MSantos closed this task as Resolved.Jan 6 2020, 4:22 PM
MSantos mentioned this in T218217: Make services swagger specs standard compliant.Jul 2 2020, 12:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits