Page MenuHomePhabricator
Create Task
Maniphest T218553

Wikibase CI appears to be broken
Closed, ResolvedPublic
Actions

Description

CI seems to be failing for at least all Wikibase patches with errors like:

gyp WARN EACCES user "jenkins-deploy" does not have permission to access the dev dir "/nonexistent/.node-gyp/10.4.0"
10:16:36 gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"
10:16:37 make: Entering directory '/src/node_modules/fibers/build'
10:16:37   CXX(target) Release/obj.target/fibers/src/fibers.o
10:16:38 ../src/fibers.cc: In static member function ‘static void Fiber::DestroyOrphans()’:
10:16:38 ../src/fibers.cc:464:67: warning: ‘v8::String::Utf8Value::Utf8Value(v8::Local<v8::Value>)’ is deprecated: Use Isolate version [-Wdeprecated-declarations]
10:16:38       String::Utf8Value stack(uni::Deref(that.isolate, fatal_stack));
10:16:38                                                                    ^
10:16:38 In file included from /tmp/.node-gyp/10.4.0/include/node/v8.h:26:0,
10:16:38                  from /tmp/.node-gyp/10.4.0/include/node/node.h:63,
10:16:38                  from ../src/coroutine.h:1,
10:16:38                  from ../src/fibers.cc:1:
10:16:38 /tmp/.node-gyp/10.4.0/include/node/v8.h:2846:28: note: declared here
10:16:38                    explicit Utf8Value(Local<v8::Value> obj));
10:16:38                             ^
10:16:38 /tmp/.node-gyp/10.4.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
10:16:38    declarator __attribute__((deprecated(message)))
10:16:38    ^~~~~~~~~~
10:16:38 ../src/fibers.cc: In static member function ‘static void Fiber::RunFiber(void**)’:
10:16:38 ../src/fibers.cc:686:66: warning: ‘static v8::Local<v8::Script> v8::Script::Compile(v8::Local<v8::String>, v8::ScriptOrigin*)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
10:16:38      Script::Compile(uni::NewLatin1String(that.isolate, "void 0;"));
10:16:38                                                                   ^
10:16:38 In file included from /tmp/.node-gyp/10.4.0/include/node/v8.h:26:0,
10:16:38                  from /tmp/.node-gyp/10.4.0/include/node/node.h:63,
10:16:38                  from ../src/coroutine.h:1,
10:16:38                  from ../src/fibers.cc:1:
10:16:38 /tmp/.node-gyp/10.4.0/include/node/v8.h:1237:38: note: declared here
10:16:38                         Local<Script> Compile(Local<String> source,
10:16:38                                       ^
10:16:38 /tmp/.node-gyp/10.4.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
10:16:38    declarator __attribute__((deprecated(message)))
10:16:38    ^~~~~~~~~~
10:16:38 ../src/fibers.cc:701:66: warning: ‘v8::Local<v8::Value> v8::TryCatch::StackTrace() const’ is deprecated: Use maybe version. [-Wdeprecated-declarations]
10:16:38        uni::Reset(that.isolate, fatal_stack, try_catch.StackTrace());
10:16:38                                                                   ^
10:16:38 In file included from /tmp/.node-gyp/10.4.0/include/node/v8.h:26:0,
10:16:38                  from /tmp/.node-gyp/10.4.0/include/node/node.h:63,
10:16:38                  from ../src/coroutine.h:1,
10:16:38                  from ../src/fibers.cc:1:
10:16:38 /tmp/.node-gyp/10.4.0/include/node/v8.h:8445:52: note: declared here
10:16:38    V8_DEPRECATED("Use maybe version.", Local<Value> StackTrace() const);
10:16:38                                                     ^
10:16:38 /tmp/.node-gyp/10.4.0/include/node/v8config.h:324:3: note: in definition of macro ‘V8_DEPRECATED’
10:16:38    declarator __attribute__((deprecated(message)))
10:16:38    ^~~~~~~~~~
10:16:38   CXX(target) Release/obj.target/fibers/src/coroutine.o
10:16:39   CC(target) Release/obj.target/fibers/src/libcoro/coro.o
10:16:39   SOLINK_MODULE(target) Release/obj.target/fibers.node
10:16:39   COPY Release/fibers.node
10:16:39 make: Leaving directory '/src/node_modules/fibers/build'
10:16:40 Installed in `/src/node_modules/fibers/bin/linux-x64-64/fibers.node`

Seems to be very similar to: T213944 so perhaps related

Details

SubjectRepoBranchLines +/-
Replace *-jsduck-* jobs with *-node10-docs-* ones (2)integration/configmaster+11 -30
build: Define `npm run-script doc`mediawiki/extensions/Wikibasemaster+1 -0
Revert "Replace *-jsduck-* jobs with *-node10-docs-* ones"integration/configmaster+30 -11
Customize query in gerrit

Related Objects

Event Timeline

Tarrow created this task.Mar 18 2019, 10:46 AM
Restricted Application added projects: Wikidata, User-Addshore. · View Herald TranscriptMar 18 2019, 10:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore updated the task description. (Show Details)Mar 18 2019, 10:49 AM
Addshore triaged this task as Unbreak Now! priority.Mar 18 2019, 10:53 AM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptMar 18 2019, 10:53 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Mar 18 2019, 10:53 AM
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
hashar subscribed.Mar 18 2019, 10:55 AM
10:31:53 Installed in `/src/node_modules/fibers/bin/linux-x64-64/fibers.node`
10:31:53 npm notice created a lockfile as package-lock.json. You should commit this file.
10:31:53 added 686 packages from 811 contributors and audited 2812 packages in 20.425s
10:31:53 found 1 low severity vulnerability
10:31:53   run `npm audit fix` to fix them, or `npm audit` for details

Seems that works fine, and indeed the job continues with:

10:31:53 + npm run-script doc

And fails due to:

10:31:54 npm ERR! missing script: doc
10:31:54 
10:31:54 npm ERR! A complete log of this run can be found in:

So package.json is missing the doc script?

gerritbot subscribed.Mar 18 2019, 10:58 AM

Change 497268 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Revert "Replace *-jsduck-* jobs with *-node10-docs-* ones"

https://gerrit.wikimedia.org/r/497268

gerritbot added a project: Patch-For-Review.Mar 18 2019, 10:58 AM
gerritbot added a comment.Mar 18 2019, 11:01 AM

Change 497268 merged by jenkins-bot:
[integration/config@master] Revert "Replace *-jsduck-* jobs with *-node10-docs-* ones"

https://gerrit.wikimedia.org/r/497268

hashar closed this task as Resolved.Mar 18 2019, 11:01 AM
hashar added subscribers: Jdforrester-WMF, Krinkle.

https://gerrit.wikimedia.org/r/#/c/integration/config/+/496887/ is a CI change to replace "jsduck" with "npm doc". I have reverted it since Wikibase is broken.

I am not opposed to that change, since we really have to remove jsduck entirely and I am totally for delegating to developers how the doc is generated (via npm run-script doc). It just happen to break on Wikibase repository and I have unfortunately don't have any bandwith today to fix it :-( Hence the revert. Sorry about that.

Addshore reassigned this task from Addshore to hashar.Mar 18 2019, 11:09 AM
Addshore subscribed.
WMDE-leszek subscribed.Mar 18 2019, 11:14 AM
gerritbot added a comment.Mar 18 2019, 3:33 PM

Change 497320 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Wikibase@master] build: Define npm run-script doc

https://gerrit.wikimedia.org/r/497320

gerritbot added a comment.Mar 18 2019, 3:34 PM

Change 497322 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] Revert "Revert "Replace *-jsduck-* jobs with *-node10-docs-* ones""

https://gerrit.wikimedia.org/r/497322

gerritbot added a comment.Mar 19 2019, 2:48 PM

Change 497320 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/extensions/Wikibase@master] build: Define npm run-script doc

https://gerrit.wikimedia.org/r/497320

gerritbot added a comment.Mar 19 2019, 6:54 PM

Change 497320 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] build: Define npm run-script doc

https://gerrit.wikimedia.org/r/497320

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 19 2019, 7:01 PM
gerritbot added a comment.Mar 19 2019, 10:24 PM

Change 497322 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[integration/config@master] Replace *-jsduck-* jobs with *-node10-docs-* ones (2)

https://gerrit.wikimedia.org/r/497322

gerritbot added a comment.Mar 19 2019, 10:25 PM

Change 497322 merged by jenkins-bot:
[integration/config@master] Replace *-jsduck-* jobs with *-node10-docs-* ones (2)

https://gerrit.wikimedia.org/r/497322

Stashbot subscribed.Mar 19 2019, 10:47 PM

Mentioned in SAL (#wikimedia-releng) [2019-03-19T22:47:44Z] <Krinkle> Reloading Zuul to deploy https://gerrit.wikimedia.org/r/497322 / T218553

hashar added a comment.Mar 20 2019, 8:57 AM

Thank you @Krinkle and sorry for the revert earlier :-\

Liuxinyu970226 unsubscribed.Mar 26 2019, 12:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL