Description

Screenshot_2019-03-21 View and restore deleted pages - Wikidata(1).png (270×947 px, 20 KB)

I think this $UNIQ thing is part of the migration to the new termbox, and is supposed to be replaced after it’s loaded from parser cache, but it looks like that doesn’t happen here.

Details

	Subject	Repo	Branch	Lines +/-
	Revert "OutputPageBeforeHTML: do nothing for non entity pages"	mediawiki/extensions/Wikibase	wmf/1.33.0-wmf.22	+2 -69
	Revert "OutputPageBeforeHTML: do nothing for non entity pages"	mediawiki/extensions/Wikibase	master	+2 -69

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T28213 Strip marker (UNIQ / QINU) issues (tracking)
		Resolved		• Pablo-WMDE	T218907 $UNIQ[hash]$ on Special:Undelete for items

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 21 2019, 3:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2019, 3:12 PM

Addshore triaged this task as High priority.Mar 21 2019, 3:13 PM

Addshore added subscribers: • Pablo-WMDE, Jakob_WMDE, Tarrow and 2 others.

• Pablo-WMDE claimed this task.Mar 21 2019, 3:39 PM

• Pablo-WMDE edited projects, added Wikidata-Termbox-Iteration-11; removed Wikidata-Termbox.

• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-11 board.

Validating the assumption that reverting https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/494476 will fix this...

Change 498142 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] Revert "OutputPageBeforeHTML: do nothing for non entity pages"

https://gerrit.wikimedia.org/r/498142

gerritbot added a project: Patch-For-Review.Mar 21 2019, 4:14 PM

@Jakob_WMDE poke

Change 498142 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "OutputPageBeforeHTML: do nothing for non entity pages"

https://gerrit.wikimedia.org/r/498142

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 21 2019, 6:01 PM

• Pablo-WMDE moved this task from Peer Review to Test (Product Review) on the Wikidata-Termbox-Iteration-11 board.Mar 21 2019, 7:13 PM

@Lydia_Pintscher Care to take a look at this on beta wiki, e.g. https://wikidata.beta.wmflabs.org/wiki/Special:Undelete?title=Q4711

@Addshore @WMDE-leszek We believe this is fixed in the main line. Please advise regarding a potentially expedited prod deployment.

I believe this would mean "backporting" to the production branch in a SWAT deployment window. Given it's Friday today, this would need to wait until Monday?
@Addshore @Tarrow @Lucas_Werkmeister_WMDE as deployers, could you please assist with this?

Change 498354 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.22] Revert "OutputPageBeforeHTML: do nothing for non entity pages"

https://gerrit.wikimedia.org/r/498354

Aklapper added a parent task: T28213: Strip marker (UNIQ / QINU) issues (tracking).Mar 22 2019, 12:02 PM

Added to Monday’s EU SWAT.

Thanks for fixing it. SWAT on Monday sounds good.

Change 498354 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.22] Revert "OutputPageBeforeHTML: do nothing for non entity pages"

https://gerrit.wikimedia.org/r/498354

Mentioned in SAL (#wikimedia-operations) [2019-03-25T11:35:40Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.33.0-wmf.22/extensions/Wikibase/repo: SWAT: [[gerrit:498354| Revert "OutputPageBeforeHTML: do nothing for non entity pages" (T218907)]] (duration: 01m 06s)