SDC: The tabs end up in the wrong place in "view" non-view pages like diffs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Mar 21 2019, 5:45 PM

Description

https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Photo_on_08-02-2019_at_16.35.jpg&diff=107196&oldid=106854&diffmode=source
(Updated above URL for testing - it'll take another week for the previous url to receive the fix)

QA steps:

have a look at some File pages, and check in their history
compare versions, and on the diff page the tabs should be under the actual diff and clicking on the tabs should work
look at an old version of a File page and make sure the tabs appear in the right place, and that clicking on them works
note that on the diff page and on the historical page that you shouldn't have 'edit' buttons you can click on to edit the structured data (captions and depicts)

QA Results

AC	Status	Details
1	✅	T218922#5096236
2	✅	T218922#5096236
3	✅	T218922#5096236
4	❌	T218922#5096236

Details

Subject	Repo	Branch	Lines +/-
Fix selector for enabling statement edits	mediawiki/extensions/WikibaseMediaInfo	wmf/1.34.0-wmf.1	+2 -1
Fix selector for enabling statement edits	mediawiki/extensions/WikibaseMediaInfo	master	+2 -1
Detach editing controls on diff and historical File pages	mediawiki/extensions/WikibaseMediaInfo	master	+18 -5
Put panel initialisation inside hooks	mediawiki/extensions/WikibaseMediaInfo	master	+37 -34
Adjust display to cater for diff and historical pages	mediawiki/extensions/WikibaseMediaInfo	master	+16 -15

Customize query in gerrit

Related Objects

Mentioned In: T221123: Adding multiple captions at once is v broken (Beta Commons)
T221110: Cannot edit statements for certain images
T221071: We don't want MediaInfo content to show up on wikis sharing Commons files
rEWBI98f8399d9196: Put panel initialisation inside hooks
rEWBIc8cb81c861bf: Put panel initialisation inside hooks
rEWBIdde352ca0328: Adjust display to cater for diff and historical pages
rEWBI1dbf33b31998: Adjust display to cater for diff and historical pages
rEWBI622fa09b0a52: Adjust display to cater for diff and historical pages
rEWBIcfe33a022b2f: Adjust display to cater for diff and historical pages
Mentioned Here: T221071: We don't want MediaInfo content to show up on wikis sharing Commons files
T221110: Cannot edit statements for certain images
T221123: Adding multiple captions at once is v broken (Beta Commons)

Event Timeline

Jdforrester-WMF created this task.Mar 21 2019, 5:45 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptMar 21 2019, 5:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Oof. That is ugly. But isn't the problem here that the tabs are in the wrong place, not necessarily that we shouldn't show them at all?

In T218922#5045419, @Ramsey-WMF wrote:

Oof. That is ugly. But isn't the problem here that the tabs are in the wrong place, not necessarily that we shouldn't show them at all?

Hmm. Yeah, we've never had interactive content in the view mode before, so this is novel, but I suppose we should retain them but inset at the right point, yes.

Jdforrester-WMF renamed this task from SDC: Don't try to show the tabs on non-view pages like diffs to SDC: The tabs end up in the wrong place in "view" non-view pages like diffs.Mar 21 2019, 6:49 PM

Assigning to Cormac for now since he's looking for stuff to do :)

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Mar 21 2019, 7:31 PM

• Ramsey-WMF moved this task from To Do to Doing on the Structured-Data-Team-Current-Work board.

• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.

• Ramsey-WMF added a subscriber: • PDrouin-WMF.

Note also that the tabs don't work properly on old versions of the page ...

Change 498415 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Adjust display to cater for diff and historical pages

https://gerrit.wikimedia.org/r/498415

gerritbot added a project: Patch-For-Review.Mar 22 2019, 4:11 PM

Cparle mentioned this in rEWBIcfe33a022b2f: Adjust display to cater for diff and historical pages.Mar 22 2019, 4:15 PM

Cparle moved this task from Doing to Code Review on the Structured-Data-Team-Current-Work board.Mar 22 2019, 4:28 PM

Cparle mentioned this in rEWBI622fa09b0a52: Adjust display to cater for diff and historical pages.Mar 22 2019, 4:34 PM

Cparle mentioned this in rEWBI1dbf33b31998: Adjust display to cater for diff and historical pages.

Jdforrester-WMF mentioned this in rEWBIdde352ca0328: Adjust display to cater for diff and historical pages.Mar 22 2019, 5:03 PM

Change 498415 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Adjust display to cater for diff and historical pages

https://gerrit.wikimedia.org/r/498415

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 22 2019, 6:01 PM

Cparle moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Mar 25 2019, 10:03 AM

Cparle removed Cparle as the assignee of this task.Mar 27 2019, 4:14 PM

Cparle updated the task description. (Show Details)

Cparle subscribed.

Cparle assigned this task to Edtadros.Mar 27 2019, 4:32 PM

Jdforrester-WMF removed a project: Patch-For-Review.Mar 27 2019, 10:40 PM

@Cparle I have a few questions about the QA steps.

have a look at some File pages, and check in their history - For this step is I'm just using the URL specified in the description. No question here.

compare versions, and on the diff page the tabs should be under the actual diff and clicking on the tabs should work Am I supposed to use the compare version from the "View History" tab or the extremely cool "Browse history interactively" option?

look at an old version of a File page and make sure the tabs appear in the right place, and that clicking on them works I need some clarification as to what "the right place" means. Maybe a screenshot or a link to the spec.

note that on the diff page and on the historical page that you shouldn't have 'edit' buttons you can click on to edit the structured data (captions and depicts) This is self explanatory, however depending on the method I got to the diff page I was either able to or unable to click the "Structured data" tag. For example, in this page I selected the two versions through the interactive browser and I'm unable to select the "Structured Data" tab:

Screen Shot 2019-03-30 at 8.41.02 AM.png (2×2 px, 960 KB)

Comparing the same two version through the "Compare Selected" button on the "View History" tab I am able to click the "Structured data" tab.

Screen Shot 2019-03-30 at 8.46.37 AM.png (2×2 px, 1013 KB)

Even with the open questions, I think this should be failed.

Edtadros updated the task description. (Show Details)Mar 30 2019, 3:52 PM

Wow, I never even noticed that interactive browse thing. Yeah, this needs to be failed based on your inability to select the 'structured data' tab in the interactive browser. Will take a look and answer your question when I re-submit

Cparle moved this task from Needs QA to Doing on the Structured-Data-Team-Current-Work board.Apr 1 2019, 2:17 PM

Change 500772 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Put panel initialisation inside hooks

https://gerrit.wikimedia.org/r/500772

gerritbot added a project: Patch-For-Review.Apr 2 2019, 3:57 PM

Cparle mentioned this in rEWBIc8cb81c861bf: Put panel initialisation inside hooks.Apr 2 2019, 3:59 PM

@Edtadros

compare versions, and on the diff page the tabs should be under the actual diff and clicking on the tabs should work

Am I supposed to use the compare version from the "View History" tab or the extremely cool "Browse history interactively" option?

Both. I'd never noticed the interactive one cos it's an extension I didn't have installed locally :/

look at an old version of a File page and make sure the tabs appear in the right place, and that clicking on them works

works I need some clarification as to what "the right place" means. Maybe a screenshot or a link to the spec.

I just mean under the image, like they appear on the main File page - in earlier versions of this we had bugs where the tabs would appear above the image

note that on the diff page and on the historical page that you shouldn't have 'edit' buttons you can click on to edit the structured data (captions and depicts)

This is self explanatory, however depending on the method I got to the diff page I was either able to or unable to click the "Structured data" tag.

Should be fixed now

• Ramsey-WMF moved this task from Doing to Code Review on the Structured-Data-Team-Current-Work board.Apr 2 2019, 4:37 PM

Jdforrester-WMF mentioned this in rEWBI98f8399d9196: Put panel initialisation inside hooks.Apr 2 2019, 8:42 PM

Change 500772 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Put panel initialisation inside hooks

https://gerrit.wikimedia.org/r/500772

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.25; 2019-04-09); removed MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Apr 2 2019, 11:01 PM

matthiasmullie reassigned this task from Cparle to Edtadros.Apr 3 2019, 6:45 AM

matthiasmullie updated the task description. (Show Details)Apr 3 2019, 6:48 AM

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.

Test Result

Status: ❌ FAIL
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

QA steps:

https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Photo_on_08-02-2019_at_16.35.jpg&diff=107196&oldid=106854&diffmode=source
have a look at some File pages, and check in their history
✅ AC1: compare versions, and on the diff page the tabs should be under the actual diff and clicking on the tabs should work

Screen Shot 2019-04-08 at 10.22.09 PM.png (2×2 px, 1 MB)

✅ AC2: look at an old version of a File page and make sure the tabs appear in the right place, and that clicking on them works

✅ AC3: note that on the diff page that you shouldn't have 'edit' buttons you can click on to edit the structured data (captions and depicts)
See AC1 above

❌ AC4: and on the historical page that you shouldn't have 'edit' buttons you can click on to edit the structured data (captions and depicts)
@Cormac it looks like the edit button exists on the historical page.

Screen Shot 2019-04-08 at 10.23.23 PM.png (2×2 px, 2 MB)

Edtadros updated the task description. (Show Details)Apr 9 2019, 5:31 AM

Cparle moved this task from Needs QA to Doing on the Structured-Data-Team-Current-Work board.Apr 16 2019, 3:43 PM

Change 504383 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Detach editing controls on diff and historical File pages

https://gerrit.wikimedia.org/r/504383

Cparle moved this task from Doing to Code Review on the Structured-Data-Team-Current-Work board.Apr 17 2019, 10:31 AM

Change 504537 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix selector for enabling statement edits

https://gerrit.wikimedia.org/r/504537

Change 504383 abandoned by Cparle:
Detach editing controls on diff and historical File pages

Reason:
Found a better fix https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/ /504537

https://gerrit.wikimedia.org/r/504383

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Apr 17 2019, 12:39 PM

Change 504537 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix selector for enabling statement edits

https://gerrit.wikimedia.org/r/504537

Works on beta!

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 17 2019, 2:00 PM

Change 504576 had a related patch set uploaded (by Jforrester; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.1] Fix selector for enabling statement edits

https://gerrit.wikimedia.org/r/504576

Change 504576 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.34.0-wmf.1] Fix selector for enabling statement edits

https://gerrit.wikimedia.org/r/504576

Mentioned in SAL (#wikimedia-operations) [2019-04-17T16:47:40Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.1/extensions/WikibaseMediaInfo/: SDC: Various fixes T218922 T221071 T221110 T221123 (duration: 01m 02s)

Stashbot mentioned this in T221071: We don't want MediaInfo content to show up on wikis sharing Commons files.Apr 17 2019, 4:47 PM

Stashbot mentioned this in T221110: Cannot edit statements for certain images.

Stashbot mentioned this in T221123: Adding multiple captions at once is v broken (Beta Commons).

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.1; 2019-04-16); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 17 2019, 5:00 PM

works on test-commons

Verified on prod

	F28597218: Screen Shot 2019-04-08 at 10.23.23 PM.png
	Apr 9 2019, 5:29 AM

	F28597210: Screen Shot 2019-04-08 at 10.22.09 PM.png
	Apr 9 2019, 5:29 AM

	F28597213: Screen Shot 2019-04-08 at 10.22.09 PM.png
	Apr 9 2019, 5:29 AM

	F28520991: Screen Shot 2019-03-30 at 8.41.02 AM.png
	Mar 30 2019, 3:51 PM

	F28520997: Screen Shot 2019-03-30 at 8.46.37 AM.png
	Mar 30 2019, 3:51 PM

SDC: The tabs end up in the wrong place in "view" non-view pages like diffsClosed, ResolvedPublicActions

Description

QA Results

Details

Related Objects

Event Timeline

Test Result

QA steps:

SDC: The tabs end up in the wrong place in "view" non-view pages like diffs
Closed, ResolvedPublic
Actions