Page MenuHomePhabricator

Browsing to Special:Search is broken on wmf.23, redirects to Special:Search&ns0=1 not Special:Search?ns0=1
Closed, ResolvedPublicBUG REPORT

Description

Impact

  • Title re-write points to an invalid page, so the user is stranded.
  • Manual/direct browsing to Special:Search is apparently quite common.

Notes

Spotted when doing final testing before deploying T219455 back-port.

Details

Related Gerrit Patches:
mediawiki/extensions/AdvancedSearch : masterUse wfAppendQuery in Hooks
mediawiki/extensions/AdvancedSearch : masterHooks redirectToNamespacedRequest, use ? or & appropriately for URL
mediawiki/extensions/AdvancedSearch : wmf/1.33.0-wmf.23Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

Event Timeline

Jdforrester-WMF triaged this task as Unbreak Now! priority.Mar 28 2019, 5:33 PM
Jdforrester-WMF created this task.
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMar 28 2019, 5:33 PM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
Restricted Application added a project: TCB-Team. · View Herald TranscriptMar 28 2019, 5:35 PM
Addshore claimed this task.Mar 28 2019, 5:44 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 28 2019, 5:44 PM

Change 499838 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@master] Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

https://gerrit.wikimedia.org/r/499838

Change 499841 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@wmf/1.33.0-wmf.23] Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

https://gerrit.wikimedia.org/r/499841

Change 499841 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@wmf/1.33.0-wmf.23] Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

https://gerrit.wikimedia.org/r/499841

Mentioned in SAL (#wikimedia-operations) [2019-03-28T18:17:50Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.23/extensions/AdvancedSearch/: AdvancedSearch: Fix two UBNs T219455 T219539 (duration: 00m 59s)

Jdforrester-WMF closed this task as Resolved.Mar 28 2019, 6:18 PM

Back-ported to production. Thanks, all!

Change 499848 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@master] Use wfAppendQuery in Hooks redirectToNamespacedRequest fix

https://gerrit.wikimedia.org/r/499848

Change 499838 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

https://gerrit.wikimedia.org/r/499838

Change 499848 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Use wfAppendQuery in Hooks

https://gerrit.wikimedia.org/r/499848