Page MenuHomePhabricator
Create Task
Maniphest T219539

Browsing to Special:Search is broken on wmf.23, redirects to Special:Search&ns0=1 not Special:Search?ns0=1
Closed, ResolvedPublicBUG REPORT
Actions

Description

Impact

  • Title re-write points to an invalid page, so the user is stranded.
  • Manual/direct browsing to Special:Search is apparently quite common.

Notes

Spotted when doing final testing before deploying T219455 back-port.

Details

SubjectRepoBranchLines +/-
Use wfAppendQuery in Hooksmediawiki/extensions/AdvancedSearchmaster+26 -8
Hooks redirectToNamespacedRequest, use ? or & appropriately for URLmediawiki/extensions/AdvancedSearchmaster+7 -1
Hooks redirectToNamespacedRequest, use ? or & appropriately for URLmediawiki/extensions/AdvancedSearchwmf/1.33.0-wmf.23+7 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF triaged this task as Unbreak Now! priority.Mar 28 2019, 5:33 PM
Jdforrester-WMF created this task.
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMar 28 2019, 5:33 PM
Restricted Application added a subscriber: TerraCodes. · View Herald Transcript
Jdforrester-WMF removed projects: Release-Engineering-Team (Kanban), Release, Train Deployments.Mar 28 2019, 5:34 PM
Jdforrester-WMF changed the subtype of this task from "Task" to "Bug Report".
Jdforrester-WMF added a project: Advanced-Search.

Looks like this was caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AdvancedSearch/+/496163

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMar 28 2019, 5:35 PM
Addshore claimed this task.Mar 28 2019, 5:44 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 28 2019, 5:44 PM
gerritbot added a comment.Mar 28 2019, 5:52 PM

Change 499838 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@master] Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

https://gerrit.wikimedia.org/r/499838

gerritbot added a project: Patch-For-Review.Mar 28 2019, 5:52 PM
Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.Mar 28 2019, 5:55 PM
gerritbot added a comment.Mar 28 2019, 5:58 PM

Change 499841 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@wmf/1.33.0-wmf.23] Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

https://gerrit.wikimedia.org/r/499841

gerritbot added a comment.Mar 28 2019, 6:09 PM

Change 499841 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@wmf/1.33.0-wmf.23] Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

https://gerrit.wikimedia.org/r/499841

Stashbot mentioned this in T219455: AdvancedSearch extension changes behaviour of default namespaces to be search for anon and logged in users.Mar 28 2019, 6:17 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-28T18:17:50Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.23/extensions/AdvancedSearch/: AdvancedSearch: Fix two UBNs T219455 T219539 (duration: 00m 59s)

Jdforrester-WMF closed this task as Resolved.Mar 28 2019, 6:18 PM
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed Patch-For-Review.

Back-ported to production. Thanks, all!

gerritbot added a comment.Mar 28 2019, 6:22 PM

Change 499848 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/AdvancedSearch@master] Use wfAppendQuery in Hooks redirectToNamespacedRequest fix

https://gerrit.wikimedia.org/r/499848

gerritbot added a project: Patch-For-Review.Mar 28 2019, 6:22 PM
gerritbot added a comment.Mar 28 2019, 7:07 PM

Change 499838 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Hooks redirectToNamespacedRequest, use ? or & appropriately for URL

https://gerrit.wikimedia.org/r/499838

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.24; 2019-04-02); removed MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 28 2019, 8:02 PM
gerritbot added a comment.Jun 4 2019, 2:55 PM

Change 499848 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Use wfAppendQuery in Hooks

https://gerrit.wikimedia.org/r/499848

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 4 2019, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL