Page MenuHomePhabricator
Create Task
Maniphest T219841

Unknown dependency: mw.externalguidance.init
Closed, ResolvedPublic
Actions

Description

On desktop Minerva I get a JS error on all pages.

Error: Unknown dependency: mw.externalguidance.init
    at sortDependencies (load.php?lang=en-gb&modules=startup&only=scripts&skin=minerva:8)
    at resolveStubbornly (load.php?lang=en-gb&modules=startup&only=scripts&skin=minerva:9)
    at Object.load (load.php?lang=en-gb&modules=startup&only=scripts&skin=minerva:21)
    at VM66 Spain:9
    at Array.RLQ.push (load.php?lang=en-gb&modules=startup&only=scripts&skin=minerva:108)
    at load.php?lang=en-gb&modules=startup&only=scripts&skin=minerva:108
    at load.php?lang=en-gb&modules=startup&only=scripts&skin=minerva:108

This is adding unnecessary noise to our error logging graphs, please fix ASAP.

QA steps

https://en.wikipedia.org/wiki/Spain?useskin=minerva

Details

SubjectRepoBranchLines +/-
Restore ExternalGuidance RL modules on mobilemediawiki/extensions/ExternalGuidancewmf/1.33.0-wmf.24+3 -0
Restore ExternalGuidance RL modules on mobilemediawiki/extensions/ExternalGuidancemaster+3 -0
Remove mobile/desktop targets from extension.jsonmediawiki/extensions/ExternalGuidancemaster+0 -3
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Apr 1 2019, 11:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2019, 11:16 PM
Jdlrobson triaged this task as High priority.Apr 1 2019, 11:17 PM
Jdlrobson added projects: MinervaNeue (Tracking), Web-Team-Backlog (Tracking).
phuedx added subscribers: Jdrewniak, • santhosh, phuedx.Apr 2 2019, 11:14 AM

Ping @santhosh and @Jdrewniak.

gerritbot added a comment.Apr 2 2019, 11:47 AM

Change 500708 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/ExternalGuidance@master] Remove mobile/desktop targets from extension.json

https://gerrit.wikimedia.org/r/500708

gerritbot added a project: Patch-For-Review.Apr 2 2019, 11:47 AM
Jdrewniak added a comment.Apr 2 2019, 11:55 AM

The patch above removes the "targets" from the extension.json file.
I think what was happening is that since the targets were set to "mobile", they weren't being loaded on Minerva desktop.

I think that setting the skinScripts to minerva in extension.json, and having the BeforePageDisplay hook check for the minerva skin is sufficient to limit these modules to Minerva, correct?

gerritbot added a comment.Apr 2 2019, 4:58 PM

Change 500708 merged by jenkins-bot:
[mediawiki/extensions/ExternalGuidance@master] Remove mobile/desktop targets from extension.json

https://gerrit.wikimedia.org/r/500708

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Apr 2 2019, 5:01 PM
gerritbot added a comment.Apr 9 2019, 12:19 AM

Change 502365 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/ExternalGuidance@master] Restore ExternalGuidance RL modules on mobile

https://gerrit.wikimedia.org/r/502365

Jdlrobson raised the priority of this task from High to Unbreak Now!.Apr 9 2019, 12:20 AM

I'm still seeing this problem in wmf24
It looks like the fix was wrong and it's taken the feature completely offline on mobile.

This has caused a 800% increase in errors in production
https://grafana.wikimedia.org/d/000000566/overview?panelId=15&fullscreen&orgId=1

@santhosh can you test the fix and get this SWATed ASAP?

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 9 2019, 12:20 AM
gerritbot added a comment.Apr 9 2019, 12:37 AM

Change 502371 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/ExternalGuidance@wmf/1.33.0-wmf.24] Restore ExternalGuidance RL modules on mobile

https://gerrit.wikimedia.org/r/502371

Jdlrobson added projects: Analytics, Release-Engineering-Team.Apr 9 2019, 12:38 AM

cc analytics and RelEng as there's potential for a lot of traffic to EventLogging (I've seen 80k a minute) to the WebClientError schema due to to this problem while it remains unfixed. I'm not sure how much as I don't know enough about the ExternalGuidance extension to know how widely used it is . I've prepared a fix but I can't get this SWATed right now as it's the end of San Francisco day.

gerritbot added a comment.Apr 9 2019, 12:56 AM

Change 502365 merged by jenkins-bot:
[mediawiki/extensions/ExternalGuidance@master] Restore ExternalGuidance RL modules on mobile

https://gerrit.wikimedia.org/r/502365

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.25; 2019-04-09); removed MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Apr 9 2019, 1:01 AM
gerritbot added a comment.Apr 9 2019, 2:28 AM

Change 502371 merged by jenkins-bot:
[mediawiki/extensions/ExternalGuidance@wmf/1.33.0-wmf.24] Restore ExternalGuidance RL modules on mobile

https://gerrit.wikimedia.org/r/502371

Stashbot added a comment.Apr 9 2019, 2:40 AM

Mentioned in SAL (#wikimedia-operations) [2019-04-09T02:40:06Z] <krinkle@deploy1001> Synchronized php-1.33.0-wmf.24/extensions/ExternalGuidance/extension.json: I8614f63960bc763 / T219841 (duration: 00m 53s)

Krinkle lowered the priority of this task from Unbreak Now! to High.Apr 9 2019, 2:41 AM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.24; 2019-04-02); removed MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 9 2019, 3:00 AM
Stashbot added a comment.Apr 9 2019, 3:23 AM

Mentioned in SAL (#wikimedia-operations) [2019-04-09T03:23:07Z] <krinkle@deploy1001> Synchronized php-1.33.0-wmf.24/extensions/ExternalGuidance/extension.json: Id04a3a4f40a884 / T219841 (duration: 00m 52s)

Jdlrobson added a subscriber: Krinkle.Apr 9 2019, 4:10 AM

Thank you @Krinkle for taking care of this.

• santhosh added a comment.Apr 9 2019, 4:39 AM

Thanks @Jdlrobson and @Krinkle.

phuedx added a comment.Apr 9 2019, 10:49 AM
In T219841#5096041, @Jdlrobson wrote:

cc analytics and RelEng as there's potential for a lot of traffic to EventLogging (I've seen 80k a minute) to the WebClientError schema

AIUI it was traffic to statsv, incrementing the MediaWiki.minerva.WebClientError counter (see https://graphite.wikimedia.org/S/b).

Jdlrobson closed this task as Resolved.Apr 9 2019, 7:39 PM
Jdlrobson claimed this task.

Errors are back to their normal level. Thanks all.

KartikMistry moved this task from Backlog to Done on the ExternalGuidance board.Apr 10 2019, 8:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL