Maniphest T219917

[Bug] Control / middle-clicking search auto-completion results dismisses the results
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	Apr 2 2019, 6:44 PM

Description

Steps to reproduce

Visit the https://wikipedia.org
Focus the search field
Start typing
Control or middle click an interesting result

Expected results

The autocomplete results are delightful, tempting, distracting, and demand to be opened in a new tab for consideration once I complete my primary search in the current window. This workflow requires that the results be persisted on control and middle click.

Actual results

The autocomplete results are dismissed on modifier click and only reappear if I delete a character and reenter it or otherwise keep typing. This poor experience discourages exploration of tangential topics that autocomplete.

Peek 2019-04-02 12-36.gif (1×1 px, 1 MB)

Environments observed

Browser version: Chromium v73.0.3683.75
OS version: Ubuntu v18.10
Device model: Desktop
Device language: English

Details

	Subject	Repo	Branch	Lines +/-
	Do not dismiss search auto-completion results on control/middle-clicking	wikimedia/portals	master	+28 -21

Customize query in gerrit

Related Objects

Mentioned In: T232797: Search suggestions override right/middle-clicking behaviour
Mentioned Here: T221628: [Bug] Scrolled search results cannot be followed on Wikipedia portal

Event Timeline

• Niedzielski created this task.Apr 2 2019, 6:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2019, 6:44 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Apr 2 2019, 7:16 PM

Not sure what our current commitment/process for portal is @phuedx

Maintenance of the Wikipedia portals is our responsibility. That being said, I don't believe we've had the discussion as to whether the portals are frozen. If not, then this work is no different from our other work (prioritisation and estimation and an eventual commitment).

/cc @ovasileva

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).Apr 3 2019, 2:45 PM

Jdlrobson moved this task from Needs Prioritization to Product Owner Backlog on the Web-Team-Backlog board.

MBinder_WMF edited projects, added Web-Team-Backlog (Needs Product Owner Decisions); removed Web-Team-Backlog.Aug 7 2019, 4:55 PM

• Niedzielski mentioned this in T232797: Search suggestions override right/middle-clicking behaviour.May 27 2020, 2:28 PM

Iniquity moved this task from Untriaged to Bugs on the Wikimedia-Portals board.Jun 5 2020, 5:34 PM

I have deep dug regarding this bug.

This issue is Actually origin when this bug is resolved T221628.
few function are used to resolved android issue.

Those functions are creating this issue......
So i have push some changes which has resloved this issue.

@Bharatkhatri351: Hi and thanks for investigating. Please see and follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines - thanks a lot! :)

Change 667843 had a related patch set uploaded (by Aklapper; owner: Bharatkhatri):
[wikimedia/portals@master] Do not dismiss search auto-completion results on control/middle-clicking

https://gerrit.wikimedia.org/r/667843

gerritbot added a project: Patch-For-Review.Mar 2 2021, 5:55 PM

In T219917#6874610, @Aklapper wrote:

@Bharatkhatri351: Hi and thanks for investigating. Please see and follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines - thanks a lot! :)

Thanks for informing me..But i have done commit according to the guidelines..
during commit one line is automatically added btw bug:txx and changeid
and i guess thats why gerritbot is not showing link here..

Am i thinking right???Can you tell what you have done changes on commit message due to which bot responded here????

@Bharatkhatri351: It was not according to the guidelines, that's why I edited it, and that's why the edited version triggered the gerritbot notification in Phab. Feel free to compare the two commit messages in the Gerrit UI interface. Further comments about the patch itself should go to Gerrit, not here in Phab. Thanks.

In T219917#6876084, @Aklapper wrote:

@Bharatkhatri351: It was not according to the guidelines, that's why I edited it, and that's why the edited version triggered the gerritbot notification in Phab. Feel free to compare the two commit messages in the Gerrit UI interface. Further comments about the patch itself should go to Gerrit, not here in Phab. Thanks.

Thanks I got my mistake.:)

Change 667843 merged by jenkins-bot:
[wikimedia/portals@master] Do not dismiss search auto-completion results on control/middle-clicking