Page MenuHomePhabricator
Create Task
Maniphest T220955

MediawikiEditEntity::checkEditPermissions fatals with unknown message 'no-permission'
Closed, ResolvedPublic
Actions

Description

MediawikiEditEntity::checkEditPermissions performs some permission checks (EntityPermissionChecker::getPermissionStatusForEntity) and sets the Status instance to ->fatal(), with 'no-permission' as argument.
The expected argument is a MessageSpecifier or i18n message key, but 'no-permission' does not seem to exact as an error message.

Maybe 'badaccess' or 'permissionserrors' are better message keys to use & pass to ->fatal()?
Or 'no-permission' needs to be created as a message.

Expected behaviour:
When the user making an edit does not have sufficient permissions, the i18n message used to indicate the error is permissionserrors (already existing message)

Details

SubjectRepoBranchLines +/-
Do not fatal with 'no-permission' messagemediawiki/extensions/Wikibasemaster+12 -12
Fix changes for error responsemediawiki/extensions/WikibaseLexememaster+8 -9
Skip tests in ApiUserBlockedTest temporarymediawiki/extensions/WikibaseLexememaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Apr 15 2019, 10:52 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2019, 10:52 AM
matthiasmullie mentioned this in T220660: Protected image captions can't be edited, API query points at null.Apr 15 2019, 11:00 AM
Reedy added a project: Wikidata-Campsite.Apr 23 2019, 3:38 PM
• Ramsey-WMF added projects: Multimedia, Structured Data Engineering.May 2 2019, 10:13 PM
• Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.
• Ramsey-WMF moved this task from To Do to Monitoring on the Structured Data Engineering board.
• Ramsey-WMF subscribed.

Anybody available to look at this one?

Aklapper edited projects, added Structured-Data-Backlog; removed Multimedia.Aug 10 2019, 11:54 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptAug 10 2019, 11:54 PM
Aklapper removed a project: Multimedia.Aug 15 2019, 4:30 PM
Addshore moved this task from Incoming to Needs Tech Work on the Wikidata-Campsite board.Jan 27 2020, 4:06 PM
Addshore added a project: Wikibase-SDC-Shared.
WMDE-leszek moved this task from Needs Tech Work to Unconnected Stories on the Wikidata-Campsite board.Jan 30 2020, 3:26 PM
WMDE-leszek moved this task from Unconnected Stories to Needs Tech Work on the Wikidata-Campsite board.
Addshore subscribed.Feb 6 2020, 9:58 AM

Looks like "permissionserrors" might make the most sense

Addshore triaged this task as Medium priority.Feb 6 2020, 9:58 AM
Addshore moved this task from Needs Tech Work to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
Addshore moved this task from Backlog to On WMDE on the Wikibase-SDC-Shared board.
WMDE-leszek updated the task description. (Show Details)Feb 18 2020, 1:07 PM
WMDE-leszek updated the task description. (Show Details)Feb 18 2020, 1:10 PM
WMDE-leszek moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Feb 18 2020, 1:13 PM
WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Feb 18 2020, 1:15 PM
gerritbot added a comment.Feb 18 2020, 3:46 PM

Change 572903 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Do not fatal with 'no-permission' message

https://gerrit.wikimedia.org/r/572903

gerritbot added a project: Patch-For-Review.Feb 18 2020, 3:46 PM
gerritbot added a comment.Feb 18 2020, 4:50 PM

Change 572915 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Skip tests in ApiUserBlockedTest temporary

https://gerrit.wikimedia.org/r/572915

gerritbot added a comment.Feb 18 2020, 4:53 PM

Change 572917 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Fix changes for error response

https://gerrit.wikimedia.org/r/572917

Ladsgroup claimed this task.Feb 18 2020, 4:55 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFeb 18 2020, 4:55 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Feb 18 2020, 5:15 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 19 2020, 11:37 AM
gerritbot added a comment.Feb 19 2020, 11:59 AM

Change 572915 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Skip tests in ApiUserBlockedTest temporary

https://gerrit.wikimedia.org/r/572915

gerritbot added a comment.Feb 19 2020, 11:59 AM

Change 572903 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Do not fatal with 'no-permission' message

https://gerrit.wikimedia.org/r/572903

gerritbot added a comment.Feb 19 2020, 11:59 AM

Change 572917 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix changes for error response

https://gerrit.wikimedia.org/r/572917

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 19 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 19 2020, 12:11 PM
• Sarahmarie1981 edited projects, added WMDE-Tech-Communication-Source-Code-Berlin; removed Structured-Data-Backlog.Mar 16 2020, 3:37 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptMar 16 2020, 3:37 PM
• Hazizibinmahdi awarded a token.Mar 16 2020, 3:58 PM
Aklapper removed a project: WMDE-Tech-Communication-Source-Code-Berlin.Mar 16 2020, 4:02 PM
MBinder_WMF mentioned this in T247891: Vandalism on Structured Data tasks.Mar 17 2020, 6:34 PM
Addshore closed this task as Resolved.May 4 2020, 1:05 PM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.May 4 2020, 1:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits