Page MenuHomePhabricator

MediawikiEditEntity::checkEditPermissions fatals with unknown message 'no-permission'
Open, MediumPublic

Description

MediawikiEditEntity::checkEditPermissions performs some permission checks (EntityPermissionChecker::getPermissionStatusForEntity) and sets the Status instance to ->fatal(), with 'no-permission' as argument.
The expected argument is a MessageSpecifier or i18n message key, but 'no-permission' does not seem to exact as an error message.

Maybe 'badaccess' or 'permissionserrors' are better message keys to use & pass to ->fatal()?
Or 'no-permission' needs to be created as a message.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2019, 10:52 AM
Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.
Ramsey-WMF moved this task from To Do to Monitoring on the Structured Data Engineering board.
Ramsey-WMF added a subscriber: Ramsey-WMF.

Anybody available to look at this one?

Restricted Application added a project: Multimedia. · View Herald TranscriptAug 10 2019, 11:54 PM

Looks like "permissionserrors" might make the most sense

Addshore triaged this task as Medium priority.Thu, Feb 6, 9:58 AM
Addshore moved this task from Needs Tech Work to Prioritized Tech on the Wikidata-Campsite board.
Addshore moved this task from Backlog to On WMDE on the Wikibase-SDC-Shared board.