Page MenuHomePhabricator
Create Task
Maniphest T221269

Reduce module registrations from PageTriage
Open, MediumPublic
Actions

Description

As of April 2019, PageTriage registers 16 modules on all wikis where it is installed:

https://grafana.wikimedia.org/d/BvWJlaDWk/startup-manifest-size?orgId=1&var-wiki=enwiki&var-component=PageTriage&var-multiwiki=commonswiki&var-multiwiki=dewiki&var-multiwiki=enwiki

  • mediawiki.template.underscore
  • ext.pageTriage.external
  • jquery.badge.external
  • ext.pageTriage.init
  • ext.pageTriage.util
  • ext.pageTriage.models
  • jquery.tipoff
  • ext.pageTriage.views.list
  • ext.pageTriage.defaultTagsOptions
  • ext.pageTriage.externalTagsOptions
  • ext.pageTriage.defaultDeletionTagsOptions
  • ext.pageTriage.externalDeletionTagsOptions
  • ext.pageTriage.toolbarStartup
  • ext.pageTriage.article
  • ext.pageTriage.messages
  • ext.pageTriage.views.toolbar
startup data
["mediawiki.template.underscore","04nm6ui",[340,1139]],["ext.pageTriage.external","18hx74z"],["jquery.badge.external","0a62j20"],["ext.pageTriage.init","1cjhroj",[340]],["ext.pageTriage.util","0i8xh7b",[342]],["ext.pageTriage.models","1tlhfat",[342,1182,1183]],["jquery.tipoff","1f7lttn"],["ext.pageTriage.views.list","08sjy05",[344,343,1094,345,1107,1213,339]],["ext.pageTriage.defaultTagsOptions","1il2s2h"],["ext.pageTriage.externalTagsOptions","022h6x3",[347]],["ext.pageTriage.defaultDeletionTagsOptions","1cqlxka",[974,1173]],["ext.pageTriage.externalDeletionTagsOptions","0glogko",[349]],["ext.pageTriage.toolbarStartup","0sw7r96"],["ext.pageTriage.article","0yulkyf",[342,1182,1143,1213]],
["ext.pageTriage.messages","1ipi0o0",[343]],["ext.pageTriage.views.toolbar","1iyabaa",[350,348,344,341,1094,1107,1110,1213,1162,339]],

About ~1 KB (uncompressed)

  • Identify which bundles need to exist (modules that need to be queued via addModules or lazy-loaded).
  • Identify whether they have a common set of scripts that would justify a shared non-entrypoint dependency.
  • Merge the rest.

Details

SubjectRepoBranchLines +/-
Merge defaultTagsOptions and defaultDeletionTagsOptions RL modulesmediawiki/extensions/PageTriagemaster+10 -18
Remove `jquery.badge.external` RL modulemediawiki/extensions/PageTriagemaster+6 -6
Merge PageTriageExternalDeletionTagsOptions into ExternalTagOptionsmediawiki/extensions/PageTriagemaster+10 -47
Merge module 'ext.pageTriage.models' into 'ext.pageTriage.util'mediawiki/extensions/PageTriagemaster+12 -24
Merge ext.pageTriage.messages into the module that needs itmediawiki/extensions/PageTriagemaster+39 -46
Remove unused ext.pageTriage.messages dependency from defaultDeletionTagsOptionsmediawiki/extensions/PageTriagemaster+2 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Apr 17 2019, 6:40 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 17 2019, 6:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Apr 17 2019, 6:54 PM

Change 504605 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/PageTriage@master] Remove unused ext.pageTriage.messages dependency from defaultDeletionTagsOptions

https://gerrit.wikimedia.org/r/504605

gerritbot added a project: Patch-For-Review.Apr 17 2019, 6:54 PM

Change 504650 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/PageTriage@master] Merge ext.pageTriage.messages into the module that needs it

https://gerrit.wikimedia.org/r/504650

Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.Apr 17 2019, 9:21 PM
gerritbot added a comment.Apr 19 2019, 7:24 PM

Change 504605 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Remove unused ext.pageTriage.messages dependency from defaultDeletionTagsOptions

https://gerrit.wikimedia.org/r/504605

gerritbot added a comment.Apr 19 2019, 7:59 PM

Change 504650 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Merge ext.pageTriage.messages into the module that needs it

https://gerrit.wikimedia.org/r/504650

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 19 2019, 8:00 PM
Krinkle removed projects: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review.Apr 20 2019, 12:52 AM
Krinkle updated the task description. (Show Details)May 6 2019, 10:03 PM
JTannerWMF moved this task from Inbox to Revisit on the Growth-Team board.May 8 2019, 7:19 PM
JTannerWMF subscribed.

This isn't within scope right now but we may work on it later.

gerritbot added a comment.Jun 10 2019, 12:43 PM

Change 516245 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/PageTriage@master] Merge 'ext.pageTriage.models' into 'ext.pageTriage.util'

https://gerrit.wikimedia.org/r/516245

gerritbot added a project: Patch-For-Review.Jun 10 2019, 12:43 PM
gerritbot added a comment.Jul 12 2019, 10:21 PM

Change 516245 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Merge module 'ext.pageTriage.models' into 'ext.pageTriage.util'

https://gerrit.wikimedia.org/r/516245

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 12 2019, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 12 2019, 11:10 PM
Krinkle updated the task description. (Show Details)Aug 5 2019, 10:27 PM
Krinkle removed a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).
gerritbot added a comment.Jun 11 2020, 7:16 PM

Change 604843 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Merge PageTriageExternalDeletionTagsOptions into ExternalTagOptions

https://gerrit.wikimedia.org/r/604843

gerritbot added a project: Patch-For-Review.Jun 11 2020, 7:16 PM
DannyS712 added a project: User-DannyS712.Jun 11 2020, 7:21 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 subscribed.
DannyS712 added a comment.Sep 8 2020, 9:08 PM
In T221269#5168439, @JTannerWMF wrote:

This isn't within scope right now but we may work on it later.

Is the growth team willing to review submitted patches?

Aklapper added a comment.Feb 19 2021, 8:51 AM

Looks like there is only one patch left to review at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/604843 , could someone take a look? TIA

gerritbot added a comment.Feb 19 2021, 9:42 AM

Change 604843 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Merge PageTriageExternalDeletionTagsOptions into ExternalTagOptions

https://gerrit.wikimedia.org/r/604843

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 19 2021, 10:00 AM
gerritbot added a comment.Feb 19 2021, 3:17 PM

Change 665183 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Merge defaultTagsOptions and defaultDeletionTagsOptions RL modules

https://gerrit.wikimedia.org/r/665183

DannyS712 updated the task description. (Show Details)Feb 19 2021, 3:18 PM
gerritbot added a comment.Feb 24 2021, 3:10 AM

Change 666335 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/PageTriage@master] Remove jquery.badge.external RL module

https://gerrit.wikimedia.org/r/666335

gerritbot added a comment.Mar 17 2021, 11:42 PM

Change 666335 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Remove jquery.badge.external RL module

https://gerrit.wikimedia.org/r/666335

DannyS712 updated the task description. (Show Details)Mar 17 2021, 11:46 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Mar 18 2021, 12:00 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
Krinkle removed a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Oct 3 2022, 10:19 PM
Krinkle updated the task description. (Show Details)
Krinkle added a comment.EditedOct 3 2022, 10:27 PM

As of April 2019, PageTriage registers 16 modules on all wikis where it is installed:

https://grafana.wikimedia.org/d/BvWJlaDWk/startup-manifest-size?orgId=1&var-wiki=enwiki&var-component=PageTriage&var-multiwiki=commonswiki&var-multiwiki=dewiki&var-multiwiki=enwiki

As of Oct 2022, PageTriage registers 12 modules:

  1. mediawiki.template.underscore
  2. ext.pageTriage.external
  3. ext.pageTriage.init
  4. ext.pageTriage.util
  5. ext.pageTriage.views.list
  6. ext.pageTriage.defaultTagsOptions
  7. ext.pageTriage.externalTagsOptions
  8. ext.pageTriage.defaultDeletionTagsOptions
  9. ext.pageTriage.toolbarStartup
  10. ext.pageTriage.article
  11. ext.PageTriage.enqueue
  12. ext.pageTriage.views.toolbar *

From https://github.com/wikimedia/mediawiki-extensions-PageTriage/blob/91e80c8003dd441577b526fb1bbd4b212a3854a2/extension.json#L108

This is still 9 more than the recommended three as per:
https://www.mediawiki.org/wiki/Wikimedia_Performance_Team/Page_load_performance
https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader

Based on a quick review of the extension, I see there are only 5 distinct load scenarios

$ git grep -E 'addModule|mw.loader'
includes/Hooks.php:             $outputPage->addModules( 'ext.pageTriage.toolbarStartup' );
includes/Hooks.php:             $outputPage->addModules( [ 'ext.pageTriage.article' ] );
includes/Hooks.php:         $outputPage->addModules( 'ext.PageTriage.enqueue' );
includes/SpecialNewPagesFeed.php:       $out->addModules( [
modules/ext.pageTriage.toolbarStartup/ext.pageTriage.toolbarStartup.js: mw.loader.using( 'ext.pageTriage.views.toolbar' )

If I am pessimistic and assume none of these scenarios are subsets (i.e. happen always together on the same page view), and if we assume each of these is unique and unlikely to be used by the same person in the same browsing session (i.e. we want to save data by not loading something that is likely loaded later anyway), and if we assume there is common functionality among these that is sufficiently large to not be worth embedding in multiple bundles (so we assume we need a "shared" module with that multiple module depend on), then that would make for at most 6 modules.

Krinkle assigned this task to DannyS712.Oct 3 2022, 10:28 PM
Krinkle triaged this task as Medium priority.
kostajh subscribed.Oct 7 2022, 7:52 PM

It seems like a single module would suffice, or maybe two? AFAIK the two scenarios are 1) Special:NewPagesFeed and 2) viewing articles that you arrived at after visiting Special:NewPagesFeed.

gerritbot added a comment.Nov 29 2022, 12:14 PM

Change 665183 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Merge defaultTagsOptions and defaultDeletionTagsOptions RL modules

https://gerrit.wikimedia.org/r/665183

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.13; 2022-12-05).Nov 29 2022, 1:01 PM
Krinkle removed a project: Patch-For-Review.Nov 29 2022, 10:00 PM
Krinkle updated the task description. (Show Details)
Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.Nov 29 2022, 10:07 PM
Jdlrobson subscribed.Mar 31 2023, 8:08 PM
Krinkle edited projects, added Wikimedia-Performance-recommendation; removed Performance-Team (Radar).Aug 18 2023, 8:42 PM
DannyS712 removed DannyS712 as the assignee of this task.Oct 5 2023, 9:43 PM

I'm sorry that I haven't handled this task. I recently returned from a long bout of unexpected inactivity, and while I plan to resume my contributions here on Phabricator its unfair to claim tasks that I might not work on when others may be interested in handling them. I'm removing myself as the assignee in a batch-action, but if someone feels that I really should be the one to handle this task feel free to re-assign me and I'll take a look.

Aklapper removed a project: PageTriage.Oct 17 2023, 9:07 PM
Aklapper edited projects, added PageTriage; removed Growth-Team.Oct 17 2023, 9:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits