Page MenuHomePhabricator

History page filter revisions cannot be expanded on Minerva skin
Closed, ResolvedPublic3 Estimated Story Points

Description

Visit https://en.wikipedia.org/wiki/Spain?action=history&useskin=minerva

Screen Shot 2019-05-14 at 10.16.08 AM.png (502×1 px, 158 KB)

Expected: I can expand the form. There is no flash of unstyled content.
Actual: I can't expand the form - there is no toggle (inserted in HTML or JS!)! There is a flash of unstyled content.

Developer notes

Fixed by mw.loader.using('mediawiki.page.ready')
Seems that code is needed on this page.
mediawiki.page.ready is a default module for all skins EXCEPT Minerva which purposely disables it. It has multiple responsibilities (including collapse/expand behaviour on article pages - see T111565)
As a temporary measure, we'd want to load mediawiki.page.ready on the special page.

QA Steps

Test Mobile Site

  1. When logged in and with AMC mode on, Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Selenium_Echo_mention_test_0.5017605665634842&action=history
  2. Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form

Test Vector

  1. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Mod%C3%A8le:43e&action=history
  2. Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form

Test Minerva on Desktop

  1. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Mod%C3%A8le:43e&action=history&useskin=minerva
  2. Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form. Don't worry about the red background - this is a beta cluster site style that will not appear on production. Also don't worry about the "Compare selected revisions button" being smaller. This is a bug unrelated to this patch and I will file another ticket for that.

QA Results

ACStatusDetails
1T223204#5255597
2T223204#5255597
3T223204#5255597

Event Timeline

Change 510090 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] History form collapsible on Minerva

https://gerrit.wikimedia.org/r/510090

@ovasileva I wonder if it would make sense to hide the filter/form on mobile? Tilman's comment T107069#5095853 suggests that 6% (or less) of people use the filter.

In T223204#5211129, @alexhollender wrote:

@ovasileva I wonder if it would make sense to hide the filter/form on mobile? Tilman's comment T107069#5095853 suggests that 6% (or less) of people use the filter.

No strong opinion either way but I think we should definitely have it collapsible but available on Minerva desktop - if this translates into it being collapsible on mobile, that would be optimal. If not, I think hiding would be okay as well.

nray removed nray as the assignee of this task.May 29 2019, 5:09 PM
nray added a subscriber: nray.

it works as expected, there is only one minor issue, there is no information when we use filter and there are no results.

image.png (618×780 px, 21 KB)

We should create a ticket to and information box "no results"

@pmiazga good catch. This is an issue on mobile and desktop. Also, if you expand the filter, add some criteria, then click "Show results" the filter closes when the results are shown. Ideally the filter would remain expanded in that case.

In T223204#5247958, @alexhollender wrote:

@pmiazga good catch. This is an issue on mobile and desktop. Also, if you expand the filter, add some criteria, then click "Show results" the filter closes when the results are shown. Ideally the filter would remain expanded in that case.

@alexhollender those are exactly two things I told Nick after I checked this patch :). @nray will create phab tickets to fix those issues

Change 510090 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] 🐛 Bug: Make the history action's filters form toggleable again

https://gerrit.wikimedia.org/r/510090

Edtadros added a subscriber: Edtadros.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA Steps

✅ AC1: Test Mobile Site
When logged in and with AMC mode on, Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Selenium_Echo_mention_test_0.5017605665634842&action=history
Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form

T223204-1.gif (808×372 px, 193 KB)

✅ AC2: Test Vector
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Mod%C3%A8le:43e&action=history
Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form

T223204-2.gif (1×800 px, 713 KB)

✅ AC3: Test Minerva on Desktop
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Mod%C3%A8le:43e&action=history&useskin=minerva
Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form. Don't worry about the red background - this is a beta cluster site style that will not appear on production. Also don't worry about the "Compare selected revisions button" being smaller. This is a bug unrelated to this patch and I will file another ticket for that.

T223204-3.gif (1×800 px, 356 KB)