Visit https://en.wikipedia.org/wiki/Spain?action=history&useskin=minerva
Expected: I can expand the form. There is no flash of unstyled content.
Actual: I can't expand the form - there is no toggle (inserted in HTML or JS!)! There is a flash of unstyled content.
Developer notes
Fixed by mw.loader.using('mediawiki.page.ready')
Seems that code is needed on this page.
mediawiki.page.ready is a default module for all skins EXCEPT Minerva which purposely disables it. It has multiple responsibilities (including collapse/expand behaviour on article pages - see T111565)
As a temporary measure, we'd want to load mediawiki.page.ready on the special page.
QA Steps
Test Mobile Site
- When logged in and with AMC mode on, Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Selenium_Echo_mention_test_0.5017605665634842&action=history
- Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form
Test Vector
- https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Mod%C3%A8le:43e&action=history
- Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form
Test Minerva on Desktop
- https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Mod%C3%A8le:43e&action=history&useskin=minerva
- Ensure when you click on the "expand"/"collapse" link in the "Filter revisions" box, it toggles the visibility of the form. Don't worry about the red background - this is a beta cluster site style that will not appear on production. Also don't worry about the "Compare selected revisions button" being smaller. This is a bug unrelated to this patch and I will file another ticket for that.
QA Results
AC | Status | Details |
1 | ✅ | T223204#5255597 |
2 | ✅ | T223204#5255597 |
3 | ✅ | T223204#5255597 |