Page MenuHomePhabricator
Create Task
Maniphest T223449

Cannot search for anything: BadMethodCallException in search on some wikis
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

https://zh-classical.wikipedia.org/w/index.php?search=Test&title=%E7%89%B9%E6%AE%8A%3A%E5%B0%8B&fulltext=%E6%90%9C%E5%B0%8B&uselang=en
[XN1lBgpAMFAAAJhU1BgAAACD] 2019-05-16 13:26:30: Fatal exception of type "BadMethodCallException"
https://zh.wikipedia.beta.wmflabs.org/w/index.php?search=Test&title=Special%3A%E6%90%9C%E7%B4%A2&fulltext=%E6%90%9C%E5%B0%8B

[XN1lN6wQBHcAAEsfMkQAAABJ] /w/index.php?search=Test&title=Special%3A%E6%90%9C%E7%B4%A2&fulltext=%E6%90%9C%E5%B0%8B BadMethodCallException from line 234 of /srv/mediawiki/php-master/extensions/CirrusSearch/includes/CirrusSearch.php: Call to a member function isOK() on a non-object (null)

Backtrace:

#0 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/CirrusSearch.php(188): CirrusSearch->searchTextReal(CirrusSearch\Search\SearchQuery)
#1 /srv/mediawiki/php-master/includes/search/SearchEngine.php(83): CirrusSearch->doSearchText(string)
#2 /srv/mediawiki/php-master/includes/search/SearchEngine.php(169): Closure$SearchEngine::searchText()
#3 /srv/mediawiki/php-master/includes/search/SearchEngine.php(84): SearchEngine->maybePaginate(Closure$SearchEngine::searchText;1456)
#4 /srv/mediawiki/php-master/includes/specials/SpecialSearch.php(341): SearchEngine->searchText(string)
#5 /srv/mediawiki/php-master/includes/specials/SpecialSearch.php(173): SpecialSearch->showResults(string)
#6 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(570): SpecialSearch->execute(NULL)
#7 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(575): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(865): MediaWiki->performRequest()
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(515): MediaWiki->main()
#11 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Details

SubjectRepoBranchLines +/-
Don't return null from InterwikiSearchermediawiki/extensions/CirrusSearchwmf/1.34.0-wmf.5+2 -1
Don't return null from InterwikiSearchermediawiki/extensions/CirrusSearchmaster+2 -1
Don't return null from InterwikiSearchermediawiki/extensions/CirrusSearchmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xiplus created this task.May 16 2019, 1:28 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 16 2019, 1:28 PM
Restricted Application added subscribers: Stang, Aklapper. · View Herald Transcript
Wargo subscribed.EditedMay 16 2019, 1:56 PM

Also szl, test

Aklapper triaged this task as Unbreak Now! priority.May 16 2019, 2:02 PM
Aklapper added a parent task: T220730: 1.34.0-wmf.5 deployment blockers.
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 16 2019, 2:02 PM
Aklapper renamed this task from BadMethodCallException in search on zh-classical.wikipedia to Cannot search for anything: BadMethodCallException in search on zh-classical.wikipedia and szl.May 16 2019, 2:02 PM
Wargo added a parent task: T221621: Allow FallbackMethod to create their own SearchQuery.May 16 2019, 2:15 PM
Wargo renamed this task from Cannot search for anything: BadMethodCallException in search on zh-classical.wikipedia and szl to Cannot search for anything: BadMethodCallException in search on group 0 and 1 wikis.May 16 2019, 2:20 PM
Wargo renamed this task from Cannot search for anything: BadMethodCallException in search on group 0 and 1 wikis to Cannot search for anything: BadMethodCallException in search on some wikis.May 16 2019, 2:30 PM
debt assigned this task to dcausse.May 16 2019, 2:37 PM
debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.
gerritbot added a comment.May 16 2019, 2:39 PM

Change 510734 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Don't return null from InterwikiSearcher

https://gerrit.wikimedia.org/r/510734

gerritbot added a project: Patch-For-Review.May 16 2019, 2:39 PM
gerritbot added a comment.May 16 2019, 2:57 PM

Change 510734 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Don't return null from InterwikiSearcher

https://gerrit.wikimedia.org/r/510734

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 16 2019, 3:00 PM
gerritbot added a comment.May 16 2019, 3:07 PM

Change 510738 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Don't return null from InterwikiSearcher

https://gerrit.wikimedia.org/r/510738

gerritbot added a comment.May 16 2019, 3:11 PM

Change 510739 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.5] Don't return null from InterwikiSearcher

https://gerrit.wikimedia.org/r/510739

gerritbot added a comment.May 16 2019, 3:36 PM

Change 510738 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Don't return null from InterwikiSearcher

https://gerrit.wikimedia.org/r/510738

gerritbot added a comment.May 16 2019, 3:44 PM

Change 510739 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@wmf/1.34.0-wmf.5] Don't return null from InterwikiSearcher

https://gerrit.wikimedia.org/r/510739

Stashbot added a comment.May 16 2019, 3:49 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-16T15:49:50Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.5/extensions/CirrusSearch/includes/InterwikiSearcher.php: Hot-deploy CirrusSearch interwiki no result UBN T223449 (duration: 00m 49s)

Jdforrester-WMF closed this task as Resolved.May 16 2019, 3:52 PM
Jdforrester-WMF removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.5; 2019-05-14); removed MW-1.34-notes (1.34.0-wmf.6; 2019-05-21).May 16 2019, 4:00 PM
hashar mentioned this in T220730: 1.34.0-wmf.5 deployment blockers.May 17 2019, 3:29 PM
EBernhardson moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.Jul 11 2019, 11:50 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Stang added a project: Chinese-Sites.Nov 13 2021, 8:15 PM
Stang moved this task from Backlog to Closed on the Chinese-Sites board.
Stang unsubscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL