Page MenuHomePhabricator
Create Task
Maniphest T223844

Reserve space for the "Related articles" container
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
matmarex
May 19 2019, 6:49 PM
Tags
Referenced Files
F34931891: Screen Shot 2022-01-26 at 1.33.47 PM.png
Jan 26 2022, 6:36 PM
F34738508: Screen Recording 2021-11-08 at 4.44.29 PM.mov.gif
Nov 9 2021, 12:47 AM
F34738506: Screen Recording 2021-11-08 at 4.38.24 PM.mov.gif
Nov 9 2021, 12:46 AM
F29141590: LCRZ0788.MP4
May 19 2019, 6:49 PM
F29141591: 2019-05-19 20-47-17.mkv
May 19 2019, 6:49 PM
Subscribers
Aklapper
• alexhollender_WMF
Edtadros
Jdlrobson
JohanahoJ
Krinkle
Masumrezarock100
View All 10 Subscribers

Description

It is EXTREMELY annoying when you scroll down to the bottom of the page to use the "Desktop" link, and then have it disappear from under your finger/cursor because "Related articles" have loaded in.

LCRZ0788.MP41 MBDownload

2019-05-19 20-47-17.mkv3 MBDownload

Developer notes

  • The reserved space is different for mobile or desktop but should always be fixed.
  • The reserved space should be hidden when the client-nojs class is present in the page

QA

You can QA on https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog OR https://en.m.wikipedia.org/wiki/Dog

  • Scroll quickly to the bottom of the page and poise yourself to click the "desktop view" link.
  • Wait until related articles loads, but do not move your finger.
  • After RelatedArticles has loaded make sure your finger is still hovering over "desktop view".

QA Results - Beta

ACStatusDetails
1✅T223844#7491301

QA Results - Prod

ACStatusDetails
1✅T223844#7491303

Details

SubjectRepoBranchLines +/-
Fix loading of related articles via IntersectionObservermediawiki/extensions/RelatedArticleswmf/1.38.0-wmf.7+27 -0
Fix loading of related articles via IntersectionObservermediawiki/extensions/RelatedArticlesmaster+27 -0
Show card placeholders while loadingmediawiki/extensions/RelatedArticlesmaster+75 -28
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.May 19 2019, 6:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2019, 6:49 PM
• nray added a project: Web-Team-Backlog.Jun 3 2019, 11:35 PM
ovasileva triaged this task as Low priority.Jun 6 2019, 8:24 AM
Jdlrobson claimed this task.Jul 31 2019, 4:26 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson removed Jdlrobson as the assignee of this task.Jul 8 2020, 12:04 AM
Jdlrobson subscribed.
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Feb 25 2021, 7:26 PM
phuedx added a project: good first task.Mar 12 2021, 1:30 PM
Aklapper removed a project: good first task.Mar 17 2021, 7:59 AM
Aklapper added a subscriber: phuedx.

@phuedx: A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. Given the current short task description I'm removing the good first task tag. Please add details what exactly has to happen where and how for a new contributor, and then add back the good first task project tag. Thanks a lot in advance!

Jdlrobson updated the task description. (Show Details)Jun 14 2021, 6:26 PM
Jdlrobson added a parent task: T284951: [EPIC] Simplify the RelatedArticles extension.
Jdlrobson moved this task from Triaged but Future to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.Jun 15 2021, 12:17 AM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.
Jdlrobson moved this task from Kanbanana-FY-2020-21 to Tracking on the Web-Team-Backlog board.
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog (Kanbanana-FY-2020-21).
matmarex claimed this task.Jun 15 2021, 12:04 PM
gerritbot added a comment.Jun 15 2021, 12:37 PM

Change 699928 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/RelatedArticles@master] Show card placeholders while loading

https://gerrit.wikimedia.org/r/699928

gerritbot added a project: Patch-For-Review.Jun 15 2021, 12:37 PM
Jdlrobson merged a task: T208180: "Related articles" appears too late and displaces footer links (FOUC; content jump).Jun 17 2021, 9:33 PM
Jdlrobson added subscribers: Krinkle, JohanahoJ, Masumrezarock100, • alexhollender_WMF.
gerritbot added a comment.Jul 15 2021, 11:41 AM

Change 699928 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/RelatedArticles@master] Show card placeholders while loading

Reason:

https://gerrit.wikimedia.org/r/699928

matmarex removed matmarex as the assignee of this task.Jul 15 2021, 11:42 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 15 2021, 12:10 PM
gerritbot added a comment.Jul 16 2021, 11:59 PM

Change 705033 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] Simplify the RelatedArticles extension to use WVUI

https://gerrit.wikimedia.org/r/705033

gerritbot added a project: Patch-For-Review.Jul 16 2021, 11:59 PM
gerritbot added a comment.Aug 12 2021, 9:44 PM

Change 705033 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] Simplify the RelatedArticles extension to use WVUI

https://gerrit.wikimedia.org/r/705033

Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (Tracking).Sep 8 2021, 3:28 PM
Jdlrobson moved this task from Backlog to Remove mobile Watchlist special page on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Sep 8 2021, 4:20 PM
gerritbot added a comment.Nov 4 2021, 7:30 PM

Change 736871 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@master] Fix loading of related articles via IntersectionObserver

https://gerrit.wikimedia.org/r/736871

gerritbot added a comment.Nov 4 2021, 9:34 PM

Change 736830 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/RelatedArticles@wmf/1.38.0-wmf.7] Fix loading of related articles via IntersectionObserver

https://gerrit.wikimedia.org/r/736830

gerritbot added a comment.Nov 4 2021, 9:44 PM

Change 736871 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@master] Fix loading of related articles via IntersectionObserver

https://gerrit.wikimedia.org/r/736871

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 4 2021, 10:00 PM
gerritbot added a comment.Nov 4 2021, 11:12 PM

Change 736830 merged by jenkins-bot:

[mediawiki/extensions/RelatedArticles@wmf/1.38.0-wmf.7] Fix loading of related articles via IntersectionObserver

https://gerrit.wikimedia.org/r/736830

Jdlrobson assigned this task to Edtadros.Nov 4 2021, 11:20 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog (Needs Prioritization (Tech)).
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 0.
Jdlrobson moved this task from Needs Analysis to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)
Stashbot added a comment.Nov 4 2021, 11:22 PM

Mentioned in SAL (#wikimedia-operations) [2021-11-04T23:22:56Z] <cjming@deploy1002> Synchronized php-1.38.0-wmf.7/extensions/RelatedArticles: Backport: [[gerrit:736830|Fix loading of related articles via IntersectionObserver (T223844)]] (duration: 00m 55s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.7; 2021-11-02); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 5 2021, 12:00 AM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Nov 9 2021, 12:46 AM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

You can QA on https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog OR https://en.m.wikipedia.org/wiki/Dog

Scroll quickly to the bottom of the page and poise yourself to click the "desktop view" link.
Wait until related articles loads, but do not move your finger.
✅ AC1: After RelatedArticles has loaded make sure your finger is still hovering over "desktop view".

Screen Recording 2021-11-08 at 4.38.24 PM.mov.gif (898×414 px, 305 KB)

Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Nov 9 2021, 12:47 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

You can QA on https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog OR https://en.m.wikipedia.org/wiki/Dog

Scroll quickly to the bottom of the page and poise yourself to click the "desktop view" link.
Wait until related articles loads, but do not move your finger.
✅ AC1: After RelatedArticles has loaded make sure your finger is still hovering over "desktop view".

Screen Recording 2021-11-08 at 4.44.29 PM.mov.gif (898×414 px, 229 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Nov 9 2021, 12:49 AM
Edtadros updated the task description. (Show Details)
Edtadros subscribed.
ovasileva closed this task as Resolved.Nov 10 2021, 1:49 PM
matmarex added a comment.Jan 16 2022, 1:14 AM

I just wanted to say that I haven't accidentally clicked on a related article while trying to switch to desktop for weeks now, and I'm really happy about it. Thanks for fixing this.

Jdlrobson added a comment.Jan 19 2022, 10:28 PM

Glad it made a difference! Thanks for sharing!

• alexhollender_WMF added a subscriber: Volker_E.Jan 26 2022, 6:36 PM

@Jdlrobson @Volker_E wondering if it would be possible to add some kind of basic loading indicator here? it looks a bit broken currently before the related articles load:

Screen Shot 2022-01-26 at 1.33.47 PM.png (1×843 px, 82 KB)

Jdlrobson added a comment.Jan 26 2022, 7:01 PM

@alexhollender, yeh a loader would make sense. Can you open a ticket with some mocks?

• alexhollender_WMF mentioned this in T300258: Add loading indicator for related articles.Jan 27 2022, 3:09 PM
Jdlrobson changed the status of subtask T300258: Add loading indicator for related articles from Open to Stalled.Mar 21 2024, 4:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL