Page MenuHomePhabricator
Create Task
Maniphest T226031

Add 'unLink' icon to Wikimedia Design Style Guide and OOUI
Closed, ResolvedPublic
Actions

Assigned To
• iamjessklein
Authored By
Volker_E
Jun 18 2019, 3:50 PM
Tags
Referenced Files
F29631531: image.png
Jun 24 2019, 5:54 PM
F29630795: Screen Shot 2019-06-24 at 12.10.41 PM.png
Jun 24 2019, 4:13 PM
F29607873: image.png
Jun 20 2019, 7:26 PM
F29543454: image.png
Jun 20 2019, 2:51 PM
F29543493: image.png
Jun 20 2019, 2:51 PM
F29543444: image.png
Jun 20 2019, 2:51 PM
Subscribers
Aklapper
deryckchan
Esanders
• iamjessklein
Jdforrester-WMF
JTannerWMF
ppelberg
Volker_E

Description

An 'unLink' icon has been identified to be needed in our icon collection.

Please follow the “Process” steps in T135081 to ensure it's available everywhere.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.33.0mediawiki/coremaster+515 -266
Create unLink iconoojs/uimaster+16 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Jun 18 2019, 3:50 PM
Volker_E triaged this task as Medium priority.Jun 19 2019, 4:44 AM
Volker_E moved this task from Backlog to Next-up on the OOUI board.
Volker_E added a comment.Jun 20 2019, 4:56 AM

@iamjessklein If you provide the SVG here (the cleaned-up with closed near-paths) from Ed, I'm happy to put this further in time for next week's release!

• iamjessklein added a comment.Jun 20 2019, 1:47 PM

Thanks for adding this @Volker_E will do.
cc/ @Esanders

• iamjessklein moved this task from 📚 Backlog to 📐 Doing on the Editing Design board.Jun 20 2019, 1:51 PM
Esanders merged a task: T226190: Create unLink icon.Jun 20 2019, 2:51 PM
In T225725#5259687, @Esanders wrote:

Based on the current template for "un-" icons, "unLink" would look like this:

100%400%
image.png (31×33 px, 728 B)
image.png (120×116 px, 2 KB)

On the grid:

image.png (342×340 px, 15 KB)

gerritbot added a comment.Jun 20 2019, 2:52 PM

Change 518049 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Create unLink icon

https://gerrit.wikimedia.org/r/518049

gerritbot added a project: Patch-For-Review.Jun 20 2019, 2:52 PM
Volker_E added a comment.Jun 20 2019, 7:26 PM

I still think this gap is unnecessary and problematic:

image.png (216×735 px, 13 KB)

• iamjessklein added a comment.Jun 21 2019, 7:14 PM

+1 I would vote for tweaking that @Volker_E

• iamjessklein added a comment.Jun 24 2019, 4:07 PM

Some reference:

• iamjessklein added a comment.Jun 24 2019, 4:13 PM

Here's another version that I mocked up, removing some of the visual noise:

Screen Shot 2019-06-24 at 12.10.41 PM.png (1×1 px, 150 KB)

Esanders added a comment.Jun 24 2019, 5:54 PM

More reference (search for "unlink icon"):

image.png (703×1 px, 433 KB)

gerritbot added a comment.Jun 24 2019, 6:59 PM

Change 518049 merged by jenkins-bot:
[oojs/ui@master] Create unLink icon

https://gerrit.wikimedia.org/r/518049

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2019, 7:10 PM
• iamjessklein added a comment.Jun 25 2019, 12:07 AM

@Volker_E and I discussed today that we should ship this as it generally has the appropriate look and feel. In a future iteration, we can then address the excess visual noise.

@Esanders 👍to ship.

Esanders closed this task as Resolved.Jun 25 2019, 1:31 PM
• iamjessklein added a comment.Jun 25 2019, 1:32 PM

Closing this issue as it is merged on OOUI (thanks @Esanders and @Volker_E )

Will make a new ticket for the tweaks that I suggested for clean up.

• iamjessklein removed a project: Editing Design.Jun 25 2019, 1:32 PM
Esanders mentioned this in T226505: Cleanup "unlink" icon.Jun 25 2019, 1:33 PM
Volker_E reopened this task as Open.Jun 25 2019, 4:46 PM

Not fully resolved yet, as it's not yet part of Style Guide resources.

gerritbot added a comment.Jun 27 2019, 4:02 AM

Change 519341 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.33.0

https://gerrit.wikimedia.org/r/519341

gerritbot added a project: Patch-For-Review.Jun 27 2019, 4:02 AM
gerritbot added a comment.Jun 27 2019, 9:03 PM

Change 519341 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.0

https://gerrit.wikimedia.org/r/519341

Maintenance_bot removed a project: Patch-For-Review.Jun 27 2019, 9:11 PM
Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.0); removed OOUI.Jun 27 2019, 9:55 PM
Jdforrester-WMF subscribed.

This icon has landed in MediaWiki 1.34.0-wmf.13.

JTannerWMF added a project: VisualEditor-Edit Cards .Jul 14 2019, 3:45 PM
Volker_E added a comment.Jul 16 2019, 12:11 PM

Design Style Guide part covered in https://github.com/wikimedia/WikimediaUI-Style-Guide/pull/218.

Volker_E closed this task as Resolved.Jul 16 2019, 1:14 PM

PR 218 is merged and pushed to DSG server.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL