Mentioned in SAL (#wikimedia-operations) [2019-06-24T13:50:54Z] <reedy@deploy1001> Synchronized wmf-config/flaggedrevs.php: T225144 T225276 T225414 T225776 T225797 T226054 (duration: 00m 56s)

Seems to be a code error rather than configuration error then, see below:

[urbanecm@mwmaint1002 ~]$ mwrepl ruwikisource
Welcome to HipHop Debugger!
Type "help" or "?" for a complete list of commands.

Note: no server specified, debugging local scripts only.
If you want to connect to a server, launch with "-h" or use:
  [m]achine [c]onnect <servername>

hphpd> var_dump($wgFlaggedRevsNamespaces);
var_dump($wgFlaggedRevsNamespaces);
array(7) {
  [0]=>
  int(0)
  [1]=>
  int(6)
  [2]=>
  int(10)
  [3]=>
  int(828)
  [4]=>
  int(12)
  [5]=>
  int(104)
  [6]=>
  int(106)
}

Wikisource NS (number 4) is not included in wgFlaggedRevsNamespaces, which means configuration is working properly. Adding FlaggedRevs and removing Wikimedia-Site-requests then.

At a guess, it's because of the feature in question is enabled conditionally (ugh) in FR...

The problem being the extensionfunction in flaggedrevs.php is run after the one in FR that does it... So the config isn't applied before the conditional setup is done, but appears to be there by the time you can view it in eval.php

This var_dump($wgFlaggedRevsNamespaces) have #6 (NS File), seems it now work (an example is above in post). Update: hm... I update page and it again shown links to not reviewed NS File: https://ru.wikisource.org/w/index.php?title=ИЭС/Раджа&oldid=3672630&diff=cur

Also, here no NS MediaWiki #8, which have same problem. See https://ru.wikisource.org/w/index.php?title=Похождения_Чичикова_(Булгаков)&oldid=1349304&diff=cur.

On the Main page of https://ru.wikisource.org for unlogged readers still showing old News. It doesn't updating. (They placed in NS "Wikisource" and can't be revieved for show.) What to do?

Also, https://ru.wikipedia.org have this problem with requiring accept reviews for transcludes from such NS.

@Vladis13: I don't see how that's related to this task. See T119366: Disable caching on the main page for anonymous users instead.

It do, I think. This problem was not until was disabled FlaggedRevs for NS "Wikisourse". And there don't using [[{{LOCALDAY}}. {{LOCALMONTHNAME}}]] [[{{LOCALYEAR}}]] {{#time}} unlike T119366.
Also, the unupdated version shows as stabilized: https://ru.wikisource.org/w/index.php?title=Заглавная_страница&stable=1. I tried to disable stabilisation for Main page, but problem still, because a transcludion can' be reviewed, as I wrote in this task.

Also, I tried to rename the transclusion to another NS, then I accept the review version of it, then did rename page to back in NS "Wikisource". It work. (Although there is some confusing due to there are some pages: the Main page includes template page, which included page of NS Wikisource.)
But it is impossible to do this after each editing the transclusion by users.

Also with NS MediaWiki.
I am administrator and created the MediaWiki:Encyclopedias_settings.json and MediaWiki:Wikiprojects settings.json pages, which are included in most ruWikisource pages of Main NS. Now, after edits on pages (seems, only new users' edits), appear the requirement to review these MediaWiki pages, but this imposible to do. Can to remove this message from one page, but it will appear again and again, since Mediawiki pages cannot be patrolled.

@Reedy, could you resolve this bug or disable the revision requirement for these NS?

Does this still happen?

Yes

And this page was created by bureaucrat of ruWikisource today. https://ru.wikisource.org/wiki/%D0%91%D0%A1%D0%AD1/%D0%91%D0%B5%D0%BB%D0%BE%D1%80%D1%83%D1%81%D1%81%D0%B8%D1%8F How you can see, this also have the mark "unreviewed pages" with link to a page in NS Project that which technically can't be reviewed.

We probably have 30% of the entire Wikisource (!!!) with warnings that pages need to be patrolled, or it will appear after any editing of the page. Because our main template for texts in Main NS is dependent with json settings and modules in the Mediawiki NS that can be edited.

For example, this page was edited only by the admin bot, or this one - only by admins. They have the warning.

If I understand correctly, here are the current FlaggedRevs settings.
Why can't I see there settings for the quality interwikis 'enwikisource', 'de', 'fr', 'pl'. More precisely 'pl' is, but short.

@Reedy Maybe then try disabling the unset options for 'ruwikisource'? Are they conflicting with Wikisource?
Or is there a problem in setting $wgGroupPermissions['sysop']['stablesettings'] = true; // -aaron 3/20/10 ? Which is disabled by default, and not enabled in any other Wikisource. (Except for 'hewikisource', but I don't know if this interwiki has similar bugs.)

If no one already knows how the FlaggedRevs extension works, then is it possible to return it as it was or do it as in the mentioned quality interwikis? This is a ask from our forum.

We are sorry. FlaggedRevs is basically unmaintained and without owner (T185664: Code stewardship review: FlaggedRevs). I can try to take a look at it next week in oob capacity.

When will the problem be resolved? Thanks.

@Ratte: Whenever someone volunteers to write a patch, and someone else volunteers to review it and accepts it, basically.

Actually this is not a bug from the programmer’s perspective: $wgFlaggedRevsNamespaces controls whether pages in a given namespace can and should be reviewed. Stable transclusion hides unreviewed changes to transcluded templates. Since the project and MediaWiki namespaces are not in the list of reviewable namespaces, any changes to them are unreviewed by definition. Unreviewable pages should generally not be transcluded in reviewable pages, but even in such rare cases when they are, I think the current behavior is safer. Adding an option to show unreviewable transclusions’ changes immediately should be technically possible, but since FlaggedRevs is already unmaintainably complex, I don’t think any developer will be willing to implement a new option.

Without code changes, you have some options:

• Move Викитека:Новости сайта to a reviewable namespace. This still requires unconfirmed users’ edits to be reviewed, but confirmed users’ edits appear immediately.
• Disable flagged revisions on Служебная:Стабилизация/Заглавная страница. This makes edits to the main page or any transcluded page to appear immediately, not only those to the news section. (I think this works, but I haven’t seen this solution in action.)
• Move the main page to an unreviewable namespace, e.g. project namespace. This also makes edits to the main page or any transcluded page to appear immediately. Some wikis do this even without the FlaggedRevs issues, e.g. French or Czech Wikisources (probably on the grounds that the main namespace should contain only works, and the main page is not a work).

@Tacsipacsi, thanks. But you answered an old example from 2019. At the time, I fixed it, bypassing the problem by moving all inclusions to Template NS. Several times I moved the page through different namespaces, tried patrolling and bouncing back, changed the settings for page stabilization and transclusions in different ways... it didn't help.

I have updated the issue description.

One possible way to fix this is to disable stable tracking of transclusions (it's disabled in English Wikipedia for example)

It seems to me that this option should not cause side problems. All important transclusions are on the users watchlists.

Please reach community consensus to disable flaggedrevs transclusion and I will do it for you.

Here is the community consensus.

It is not closed by a local functionary yet. Once it's closed as successful, ping me and I get it done.

@Ladsgroup, I closed it up there, was 2 weeks of the poll. All administrators, bureaucrat and active users voted. Consensus.

Change 753441 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Disable flaggedrevs stable template inclusion in ruwikisource

https://gerrit.wikimedia.org/r/753441

Change 753441 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable flaggedrevs stable template inclusion in ruwikisource

https://gerrit.wikimedia.org/r/753441

Mentioned in SAL (#wikimedia-operations) [2022-01-12T13:30:26Z] <ladsgroup@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:753441|Disable flaggedrevs stable template inclusion in ruwikisource (T226054)]] (duration: 01m 08s)

Is it fixed now?

Seems, yes. Thank you very much!
I checked the places where the bug could appear. It was massive, if the bug remained somewhere I didn't notice, I'll let you know.