Homepage Mentorship - issues with parsing mentor added descriptions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jul 8 2019, 10:34 PM

Description

As a follow up for T220145.

All cases refer to the page Wikipedia:Mentors on betalabs:

(1) If mentors add their user page link and that link has a display name - e.g. [[User:ET15|ET15]]- the description added after a pipe won't be displayed.

(2) If mentors add a pipe to their user link and nothing else after that, e.g.

* [[User:ET125]]|            
* [[User:ET15|ET15]]

Special:Homepage will be broken: the assigned mentor link won't be displayed (in the example it should be ET125) only wikitext of a following mentor's name:

Screen Shot 2019-07-08 at 3.14.33 PM.png (291×432 px, 30 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Mentor: Fix parsing of empty mentor description	mediawiki/extensions/GrowthExperiments	master	+18 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• Rileych	T213990 [EPIC] Growth: Newcomer homepage
Resolved	SBisson	T216631 Homepage: mentorship module
Resolved	None	T223215 Homepage: Improve newcomer understanding of mentors
Resolved	• Tim_WMDE	T220145 Homepage Mentorship: allow mentors to configure their presentation
Resolved	Catrope	T227535 Homepage Mentorship - issues with parsing mentor added descriptions

Event Timeline

Etonkovidova created this task.Jul 8 2019, 10:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2019, 10:34 PM

Etonkovidova updated the task description. (Show Details)Jul 8 2019, 10:36 PM

Etonkovidova mentioned this in T220145: Homepage Mentorship: allow mentors to configure their presentation.Jul 8 2019, 10:48 PM

MMiller_WMF added a parent task: T220145: Homepage Mentorship: allow mentors to configure their presentation.Jul 9 2019, 12:29 AM

MMiller_WMF edited projects, added Growth-Team; removed GrowthExperiments-Homepage.

MMiller_WMF added a project: GrowthExperiments.

MMiller_WMF added subscribers: kostajh, SBisson, • Tim_WMDE.

JTannerWMF assigned this task to Catrope.Jul 9 2019, 7:30 PM

JTannerWMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

It turns out that if you have a mentor with an empty description like on the first line (here, [[User:ET125]]|), then that mentor's custom intro message will be whatever is on the next line. In this case that's [[User:ET15|ET15]], but it doesn't matter what it is, it's purely because of the pipe at the end of the first line.

Change 521963 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Mentor: Fix parsing of empty mentor description

https://gerrit.wikimedia.org/r/521963

gerritbot added a project: Patch-For-Review.Jul 10 2019, 9:40 PM

Catrope moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 10 2019, 10:16 PM

SBisson moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 15 2019, 7:38 PM

Change 521963 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentor: Fix parsing of empty mentor description

https://gerrit.wikimedia.org/r/521963

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 8:01 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 8:10 PM

Etonkovidova updated the task description. (Show Details)Jul 30 2019, 7:34 PM

• Tim_WMDE unsubscribed.Jul 30 2019, 7:36 PM

Etonkovidova closed this task as Resolved.Jul 30 2019, 7:54 PM