[wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jul 29 2019, 8:26 PM

Description

On mobile Homepage click 'Your mentor' or 'Get help with editing'. Then click on 'Cancel' - the word 'undefined' (see the screenshot below) would be briefly displayed:

Screen Shot 2019-07-29 at 1.05.23 PM.png (664×462 px, 99 KB)

mentorship_undefined_displayed.gif (769×458 px, 742 KB)

Note: If a user reloads the page when the overlay displays, the page will be displayed as the following:

Details

Subject	Repo	Branch	Lines +/-
Homepage: Unbreak question dialogs on mobile	mediawiki/extensions/GrowthExperiments	wmf/1.34.0-wmf.21	+14 -11
Homepage: Unbreak question dialogs on mobile	mediawiki/extensions/GrowthExperiments	master	+14 -11
Homepage: Restructure mobile overlay handling	mediawiki/extensions/GrowthExperiments	master	+79 -40

Customize query in gerrit

Related Objects

Mentioned In: T230716: Show most recent question in overlay immediately after tapping "Done"
T225663: Homepage: add sub-header text about user longevity to mobile homepage

Event Timeline

Etonkovidova created this task.Jul 29 2019, 8:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2019, 8:26 PM

Etonkovidova updated the task description. (Show Details)Jul 29 2019, 9:27 PM

• Catrope moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 31 2019, 1:55 AM

Etonkovidova mentioned this in T225663: Homepage: add sub-header text about user longevity to mobile homepage.Aug 1 2019, 11:12 PM

This is clearly an undesirable bug, so we want to work on it soon.

This bug is very obviously visible if you open e.g. the "ask your mentor" dialog on the mobile site in a desktop browser at full size (without device emulation). The OOUI dialog doesn't cover the whole screen (because the screen isn't small enough to trigger that behavior), and you get this:

Screenshot from 2019-08-02 17-56-27.png (730×883 px, 62 KB)

Change 527800 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Homepage: Restructure mobile overlay handling

https://gerrit.wikimedia.org/r/527800

gerritbot added a project: Patch-For-Review.Aug 3 2019, 4:09 AM

• Catrope claimed this task.Aug 3 2019, 4:14 AM

• Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

• Catrope moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

FWIW, I can't reproduce either of these issues on wmf.17 (testwiki) or beta, but the approach in the patch seems better than what we have now.

In T229271#5408898, @kostajh wrote:

FWIW, I can't reproduce either of these issues on wmf.17 (testwiki) or beta, but the approach in the patch seems better than what we have now.

Re-checked wmf.17 - the issue is present in mobile browser (Chrome) emulator (and on iPhone 6Plus, iOS 12).

Krinkle renamed this task from [wmf.15-mobile]Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' to [wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' .Aug 26 2019, 7:11 PM

Krinkle awarded a token.

Change 527800 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage: Restructure mobile overlay handling

https://gerrit.wikimedia.org/r/527800

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 1 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 1 2019, 7:10 PM

Change 534238 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Homepage: Unbreak question dialogs on mobile

https://gerrit.wikimedia.org/r/534238

gerritbot added a project: Patch-For-Review.Sep 3 2019, 9:21 PM

• Catrope mentioned this in T230716: Show most recent question in overlay immediately after tapping "Done".Sep 3 2019, 9:29 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 4 2019, 9:30 AM

Change 534238 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Homepage: Unbreak question dialogs on mobile

https://gerrit.wikimedia.org/r/534238

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.22; 2019-09-10); removed MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 4 2019, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2019, 10:10 AM

Checked in betalabs - the issue is fixed.

Change 534492 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.21] Homepage: Unbreak question dialogs on mobile

https://gerrit.wikimedia.org/r/534492

gerritbot added a project: Patch-For-Review.Sep 4 2019, 5:21 PM

Change 534492 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.21] Homepage: Unbreak question dialogs on mobile

https://gerrit.wikimedia.org/r/534492

Mentioned in SAL (#wikimedia-operations) [2019-09-04T17:59:50Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.21/extensions/GrowthExperiments/modules/homepage/: T229271 Homepage: Unbreak question dialogs on mobile (duration: 00m 56s)

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.21; 2019-09-03); removed MW-1.34-notes (1.34.0-wmf.22; 2019-09-10).Sep 4 2019, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2019, 6:10 PM

	F29945063: Screenshot from 2019-08-02 17-56-27.png
	Aug 3 2019, 12:57 AM

	F29900088: mentorship_undefined_displayed.gif
	Jul 29 2019, 8:26 PM

	F29899967: Screen Shot 2019-07-29 at 1.05.23 PM.png
	Jul 29 2019, 8:26 PM

[wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined'
Closed, ResolvedPublic
Actions