Page MenuHomePhabricator
Create Task
Maniphest T229604

Several selectors/experts are broken
Closed, ResolvedPublicBUG REPORT
Actions

Description

Several selectors are broken right now. At least you can't:

  • edit language of monolingual text values
  • get the date expert to open up
  • get the unit selector

Initial report:

Steps to Reproduce:

Go to https://www.wikidata.org/wiki/Q66058247

Add a new value to "title", write a bit.

(Also lexemes are affected)

Actual Results:

The language selection drop down does not show up and the "publish" button is greyed

Expected Results:

The language selection drop down should appear and after language selection, the "publish" button should be enabled

Details

SubjectRepoBranchLines +/-
Define $wgMessagesDirs in WikibaseView PHP entry pointmediawiki/extensions/Wikibasewmf/1.34.0-wmf.16+6 -0
Define $wgMessagesDirs in WikibaseView PHP entry pointmediawiki/extensions/Wikibasemaster+6 -0
Revert "fix eslint errors in lib after moving submodule files into lib"mediawiki/extensions/Wikibasemaster+2 K -2 K
Revert "fix eslint errors in lib after moving submodule files into lib"mediawiki/extensions/Wikibasewmf/1.34.0-wmf.16+2 K -2 K
Customize query in gerrit

Related Objects

Event Timeline

Fnielsen created this task.Aug 1 2019, 6:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2019, 6:10 PM
ArthurPSmith subscribed.Aug 1 2019, 6:35 PM

I see the problem also (Safari browser). When you talk about it affecting lexemes, where do you see that? I experimented with adding a form and that seemed fine.

Fnielsen added a comment.Aug 1 2019, 6:49 PM

The lexeme has these language fields for word stem.

Fnielsen added a comment.Aug 1 2019, 6:52 PM

My browser is Firefox.

Moebeus subscribed.Aug 1 2019, 7:10 PM
Moebeus added a comment.Aug 1 2019, 7:13 PM

Can confirm: The problem started around 17:45 GMT +1 and affects all browsers (Firefox, Edge, Chrome and variants).

Premeditated subscribed.Aug 1 2019, 7:19 PM
Moebeus added a comment.Aug 1 2019, 7:58 PM

Now fixed on my end 👍

Fnielsen added a comment.Aug 1 2019, 8:11 PM

Yes, fixed at my end too.

Fnielsen closed this task as Resolved.Aug 1 2019, 8:11 PM
Fnielsen claimed this task.
Moebeus added a comment.EditedAug 1 2019, 10:10 PM

It looks like the problem is back, stopped working again just now :(

Fnielsen reopened this task as Open.Aug 1 2019, 11:35 PM

Yes. It is back.

Moebeus mentioned this in T229632: Language selection for monolingual fields does not work.Aug 2 2019, 12:18 AM
matej_suchanek triaged this task as Unbreak Now! priority.Aug 2 2019, 8:02 AM
matej_suchanek merged a task: T229632: Language selection for monolingual fields does not work.
matej_suchanek added a project: Regression.
matej_suchanek added a subscriber: putnik.
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptAug 2 2019, 8:02 AM
VIGNERON subscribed.Aug 2 2019, 8:48 AM
Salgo60 subscribed.Aug 2 2019, 8:50 AM
Lucas_Werkmeister_WMDE subscribed.Aug 2 2019, 9:37 AM
Lydia_Pintscher added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Aug 2 2019, 9:39 AM
Lydia_Pintscher subscribed.

Amir is looking into it right now.

Lucas_Werkmeister_WMDE added a comment.EditedAug 2 2019, 9:40 AM
In T229604#5385566, @Moebeus wrote:

Can confirm: The problem started around 17:45 GMT +1 and affects all browsers (Firefox, Edge, Chrome and variants).

17:45 UTC+1 would be about an hour after group1 to wmf.16 (15:40 UTC). It was then moved back to wmf.15 (19:40 UTC) and finally again to wmf.16 (21:23 UTC), which would explain why the error was gone for a bit.

Lydia_Pintscher renamed this task from Not possible to write in language edit fields to Several selectors/experts are broken.Aug 2 2019, 9:40 AM
Lydia_Pintscher removed Fnielsen as the assignee of this task.
Lydia_Pintscher updated the task description. (Show Details)
Ladsgroup subscribed.Aug 2 2019, 9:43 AM

The wikibase patches that went in with wmf.16: https://www.mediawiki.org/wiki/MediaWiki_1.34/wmf.16#Wikibase

gerritbot added a comment.Aug 2 2019, 10:08 AM

Change 527500 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Revert "fix eslint errors in lib after moving submodule files into lib"

https://gerrit.wikimedia.org/r/527500

gerritbot added a project: Patch-For-Review.Aug 2 2019, 10:08 AM

Change 527501 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.16] Revert "fix eslint errors in lib after moving submodule files into lib"

https://gerrit.wikimedia.org/r/527501

gerritbot added a comment.Aug 2 2019, 10:45 AM

Change 527501 merged by Ladsgroup:
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.16] Revert "fix eslint errors in lib after moving submodule files into lib"

https://gerrit.wikimedia.org/r/527501

Moebeus added a comment.Aug 2 2019, 11:03 AM

image.png (122×849 px, 9 KB)
Some improvement just now :)

Ladsgroup claimed this task.Aug 2 2019, 11:04 AM

I'm working on it. It should be back online now with the change I deployed but with missing i18n messages. I'm on it.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 2 2019, 11:04 AM
Moebeus added a comment.Aug 2 2019, 11:07 AM
In T229604#5387497, @Ladsgroup wrote:

I'm working on it. It should be back online now with the change I deployed but with missing i18n messages. I'm on it.

Thanks a bunch for the fast action!

Fnielsen added a comment.Aug 2 2019, 11:09 AM

Works for me now too. Thanks!

WMDE-leszek subscribed.Aug 2 2019, 11:30 AM
Stashbot added a comment.Aug 2 2019, 11:34 AM

Mentioned in SAL (#wikimedia-operations) [2019-08-02T11:34:29Z] <ladsgroup@deploy1001> Started scap: [[phab:T229604|Rebuilding l10n cache]]

Stashbot added a comment.Aug 2 2019, 11:39 AM

Mentioned in SAL (#wikimedia-operations) [2019-08-02T11:39:35Z] <ladsgroup@deploy1001> Finished scap: [[phab:T229604|Rebuilding l10n cache]] (duration: 05m 06s)

Ladsgroup lowered the priority of this task from Unbreak Now! to High.Aug 2 2019, 12:04 PM

After talking to @Lydia_Pintscher sicne people can enter values now, it's good for now but I'm still working on to rebuild the l10n cache.

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 2 2019, 12:25 PM
gerritbot added a comment.Aug 2 2019, 1:21 PM

Change 527500 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "fix eslint errors in lib after moving submodule files into lib"

https://gerrit.wikimedia.org/r/527500

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 2 2019, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2019, 2:10 PM
gerritbot added a comment.Aug 2 2019, 4:10 PM

Change 527594 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Define $wgMessagesDirs in WikibaseView PHP entry point

https://gerrit.wikimedia.org/r/527594

gerritbot added a project: Patch-For-Review.Aug 2 2019, 4:10 PM
gerritbot added a comment.Aug 2 2019, 4:20 PM

Change 527597 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.16] Define $wgMessagesDirs in WikibaseView PHP entry point

https://gerrit.wikimedia.org/r/527597

gerritbot added a comment.Aug 2 2019, 5:00 PM

Change 527594 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Define $wgMessagesDirs in WikibaseView PHP entry point

https://gerrit.wikimedia.org/r/527594

gerritbot added a comment.Aug 2 2019, 5:17 PM

Change 527597 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.34.0-wmf.16] Define $wgMessagesDirs in WikibaseView PHP entry point

https://gerrit.wikimedia.org/r/527597

Stashbot added a comment.Aug 2 2019, 5:25 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-02T17:25:13Z] <lucaswerkmeister-wmde@deploy1001> Started scap: Fix WikibaseView i18n globals (T229604)

Stashbot added a comment.Aug 2 2019, 5:42 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-02T17:42:04Z] <lucaswerkmeister-wmde@deploy1001> Finished scap: Fix WikibaseView i18n globals (T229604) (duration: 16m 51s)

Lucas_Werkmeister_WMDE moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 2 2019, 5:54 PM

The issue persisted for ca. 10 minutes after the scap finished, for reasons I don’t understand, but now it does seem to be resolved. Leaving the task open for verification by others.

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.16; 2019-07-30); removed MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 2 2019, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2019, 6:10 PM
Stashbot added a comment.Aug 2 2019, 6:14 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-02T18:14:32Z] <Lucas_WMDE> recached all WikibaseView messages in ResourceLoader for T229604, cf. https://w.wiki/6kc

Lydia_Pintscher closed this task as Resolved.Aug 7 2019, 10:38 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Fixed \o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL