Site header doesn't fit on screen in advanced contributors mode
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	kaldari
	Aug 9 2019, 6:54 PM

Description

I'm on an iPhone SE.

Looks like there's plenty of extra space between the header icons that could be shrunk on smaller screens. Probably just need to add a CSS media query.

Sign off steps

The fix is a hack that will need to be reverted. Make sure this task is not resolved, and is removed from the sprint board/moved to blocked on others. It will need to be tested again when T229440 is done, test on different device sizes (s, m, and l roughly)

QA Results

AC	Status	Details
1	✅	T230232#5516106

Details

	Subject	Repo	Branch	Lines +/-
	[hack] [toolbar] tighten the icon spacing	mediawiki/skins/MinervaNeue	master	+8 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T226562 AMC - display labels for toolbar actions on larger screens
Resolved	• alexhollender_WMF	T229440 [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency
Resolved	ovasileva	T230232 Site header doesn't fit on screen in advanced contributors mode
Resolved	ovasileva	T229447 Reduce spacing of icons in mobile header

Event Timeline

kaldari created this task.Aug 9 2019, 6:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2019, 6:54 PM

kaldari merged a task: T230233: Site header doesn't fit on screen in advanced contributors mode.Aug 9 2019, 6:57 PM

kaldari updated the task description. (Show Details)

kaldari added a subtask: T229447: Reduce spacing of icons in mobile header.Aug 9 2019, 7:02 PM

Jdlrobson triaged this task as High priority.Aug 12 2019, 6:02 PM

Jdlrobson added a project: Web-Team-Backlog (Design).

XanonymusX subscribed.Aug 28 2019, 1:18 PM

Change 533534 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] [hack] [toolbar] tighten the icon spacing

https://gerrit.wikimedia.org/r/533534

gerritbot added a project: Patch-For-Review.Aug 30 2019, 2:57 PM

Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog (Design).Aug 30 2019, 5:28 PM

Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson updated the task description. (Show Details)Aug 30 2019, 5:39 PM

Jdlrobson added a parent task: T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.

Nice, I was going to complain about this too :)

Change 533534 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] [hack] [toolbar] tighten the icon spacing

https://gerrit.wikimedia.org/r/533534

Restricted Repository Identity mentioned this in rSKINf74f4e5dd1e7: Update git submodules.Aug 30 2019, 7:42 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 30 2019, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2019, 8:10 PM