The first result here is redundant:
Interestingly this doesn't happen if the match is fuzzier (in this case a capitalisation fix for the second word):
Esanders | |
Aug 20 2019, 4:51 PM |
F30129935: image.png | |
Aug 27 2019, 11:11 AM |
F30050366: image.png | |
Aug 20 2019, 4:51 PM |
F30050364: image.png | |
Aug 20 2019, 4:51 PM |
The first result here is redundant:
Interestingly this doesn't happen if the match is fuzzier (in this case a capitalisation fix for the second word):
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T221247 [Epic] Mobile context items | |||
Resolved | None | T229830 Edit Cards: deploy v3 to all wikis | |||
Resolved | Esanders | T229831 Implement Edit Cards v3 | |||
Resolved | • ppelberg | T230213 Test edit cards v3 at Wikimania | |||
Resolved | • ppelberg | T230819 Link inspector shows duplicate results for single word articles |
This was deliberately fixed to behave like this in T52452, so that typing "<ctrl>+k, iPhone" didn't result in the text IPhone being inserted. Since then we have fixed the link insertion code to always use the casing in the input field.
This extra result is actually removable by config (addQueryInput) which was added for CX and other use cases.
If we set this to false then the user would no longer be able to type in lower case then select their result from the list and keep casing, however I think that is less of an issue than the current confusing double result. In fact I think the double result is so confusing we should make the addQueryInput default to false, and probably deprecate it.
If we do keep/use addQueryInput, the extra result should at least have the correct metadata:
Change 532691 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Use correct metadata when adding exact query match
Change 532693 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Link inspector: Turn off 'addQueryInput'
Change 532691 merged by jenkins-bot:
[mediawiki/core@master] Use correct metadata when adding exact query match
Change 532693 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Link inspector: Turn off 'addQueryInput'