Page MenuHomePhabricator
Create Task
Maniphest T231430

Structure test to validate existence of ResourceLoaderImageModule "images" files
Closed, ResolvedPublic
Actions

Description

From T231358, 062e067d4964c2854c33821fb5522cf578dc4f89 for MinervaNeue made a ResourceLoaderImageModule invalid since it has an image pointing to a non existent file:

+                               "userSandbox": "resources/resources/skins.minerva.personalMenu.icons/userSandbox.svg"
                                                ^^^^^^^^^^^^^^^^^^^
-                               "userSandbox": "resources/skins.minerva.mainMenu.icons/userSandbox.svg"

MediaWiki has structure tests to validate resources file existence but it does not have any such tests for ResourceLoaderImageModule ones.

tests/phpunit/structure/ResourcesTest.php only look for modules being an instance of ResourceLoaderFileModule, while ResourceLoaderImageModule descend directly from ResourceLoaderModule.

We thus need an extra structure test in ResourcesTest.php to validate that images referred to by a ResourceLoaderImageModule are actually existing.

Details

SubjectRepoBranchLines +/-
(do not merge) ensure ImageModule images are checkedmediawiki/skins/MinervaNeuemaster+1 -1
resourceloader: Add test to validate existence of ImageModule "images" filesmediawiki/coremaster+36 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Aug 28 2019, 11:20 AM
hashar mentioned this in T231358: File '/srv/mediawiki/php-1.34.0-wmf.20/skins/MinervaNeue/resources/resources/skins.minerva.personalMenu.icons/userSandbox.svg' does not exist.
zeljkofilipin triaged this task as Unbreak Now! priority.Aug 28 2019, 12:46 PM
hashar lowered the priority of this task from Unbreak Now! to Medium.Aug 28 2019, 1:19 PM

it is not a blocker but a follow up to T231358 which has been a blocker but is now solved.

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Aug 29 2019, 12:32 AM
Krinkle added a project: MediaWiki-ResourceLoader.
Restricted Application added a project: Performance-Team. · View Herald TranscriptAug 29 2019, 12:32 AM
Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.Aug 29 2019, 12:32 AM
• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Sep 3 2019, 8:13 PM
Krinkle added a project: patch-welcome.Sep 3 2019, 8:14 PM
hashar updated the task description. (Show Details)Sep 27 2019, 8:19 PM
hashar mentioned this in T234092: structure/ResourcesTest should also check conditional skin styles and language scripts.Sep 27 2019, 8:25 PM

A similar one: T234092: structure/ResourcesTest should also check conditional skin styles and language scripts

Krinkle renamed this task from MediaWiki structure tests do not validate ResourceLoaderImageModule "images" file existence to Structure test to validate existence of ResourceLoaderImageModule "images" files.Sep 27 2019, 9:01 PM
• WDoranWMF assigned this task to • holger.knust.Feb 6 2020, 6:16 PM
• WDoranWMF added a project: Platform Team Workboards (Clinic Duty Team).
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptFeb 6 2020, 6:17 PM
• WDoranWMF moved this task from Inbox to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Feb 6 2020, 6:19 PM
Krinkle moved this task from Ready (WIP:5) to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Feb 6 2020, 6:21 PM
Krinkle moved this task from Doing(WIP:5) to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.
Krinkle moved this task from Backlog: Maintenance, non-prioritized to Doing (old) on the Performance-Team board.
gerritbot added a comment.Feb 12 2020, 2:04 PM

Change 571615 had a related patch set uploaded (by Krinkle; owner: Holger Knust):
[mediawiki/core@master] resourceloader: Add test to validate existence of ImageModule "images" files

https://gerrit.wikimedia.org/r/571615

gerritbot added a project: Patch-For-Review.Feb 12 2020, 2:04 PM
gerritbot added a comment.Feb 12 2020, 5:02 PM

Change 571615 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Add test to validate existence of ImageModule "images" files

https://gerrit.wikimedia.org/r/571615

Maintenance_bot removed a project: Patch-For-Review.Feb 12 2020, 5:11 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 12 2020, 6:00 PM
• holger.knust closed this task as Resolved.Feb 13 2020, 6:34 PM
zeljkofilipin unsubscribed.Feb 14 2020, 10:41 AM
hashar added a comment.Mar 4 2020, 9:57 AM

Thank you @holger.knust

gerritbot added a comment.Mar 4 2020, 10:00 AM

Change 576649 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/skins/MinervaNeue@master] (do not merge) ensure ImageModule images are checked

https://gerrit.wikimedia.org/r/576649

gerritbot added a project: Patch-For-Review.Mar 4 2020, 10:00 AM
gerritbot added a comment.Mar 4 2020, 10:42 AM

Change 576649 abandoned by Hashar:
(do not merge) ensure ImageModule images are checked

Reason:
It fails properly:

ResourcesTest::testImageFiles
File 'toast.mw-notification-type-error,.mw-notification.mw-notification-type-error' referenced by 'skins.minerva.content.styles.images' must exist.

https://gerrit.wikimedia.org/r/576649

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2020, 11:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits