Rollback link on mobile should be styled on Special:Watchlist, Special:RecentChanges and Special:Contributions
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Ammarpad
	Sep 8 2019, 5:50 PM

Description

In mobile recent changes page and AMC's Special:Contributions page rollback links are shown as a free wandering links.

Note: The history page shows exactly how this should look and is working correctly.

IMG_20190908_184120_131.JPG (1×720 px, 133 KB)

QA steps

Ask @Jdlrobson to make you a rollbacker on beta cluster using https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special%3AUserRights&user=Jdlrobson and ENABLE amc mode.
Visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Arbitration_Committee_(English_Wikipedia)&action=history and check rollback link there
Ensure Special:Contributions treatment of rollback link matches (https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Contributions/Jdlrobson)
Ensure Special:RecentChanges treatment of rollback link matches (https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Special:RecentChanges

)

Developer notes

the CSS rules for rollback link live in skinStyles/mediawiki.action.history.styles.less and should be moved to skinStyles/mediawiki.special.changeslist.less

Details

	Subject	Repo	Branch	Lines +/-
	Consistent undo/rollback links across changelist pages	mediawiki/skins/MinervaNeue	master	+26 -34
	Style rollback link on RecentChanges, Contributions and Watchlist	mediawiki/skins/MinervaNeue	master	+18 -11

Customize query in gerrit

Related Objects

Mentioned In: T225127: Display core version of watchlist page for AMC users

Event Timeline

Ammarpad created this task.Sep 8 2019, 5:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2019, 5:50 PM

Ammarpad added a project: MobileFrontend.Sep 8 2019, 5:51 PM

Jdlrobson added a project: Web-Team-Backlog.Sep 9 2019, 8:25 PM

ovasileva triaged this task as Medium priority.Sep 10 2019, 9:49 AM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.

@alexhollender how should these appear?

@Jdrewniak didn't we style these as buttons somewhere?

I wonder if the treatment of Undo on the History page would work here? I'm also fine with parentheses.

en.m.wikipedia.org_w_index.php_title=Uncut_Gems&action=history(iPhone 6_7_8).png (1×750 px, 157 KB)

Yeh that could work. How would it look with undo and revert? Would buttons be stacked vertically or horizontally?

In T232284#5484770, @Jdlrobson wrote:

Yeh that could work. How would it look with undo and revert? Would buttons be stacked vertically or horizontally?

Who sees both Undo and Revert/Rollback? Is it only admins? Given the variation in the string lengths across languages I think we'd need to do something like this:

In T232284#5495762, @alexhollender wrote:

In T232284#5484770, @Jdlrobson wrote:

Yeh that could work. How would it look with undo and revert? Would buttons be stacked vertically or horizontally?

Who sees both Undo and Revert/Rollback? Is it only admins? Given the variation in the string lengths across languages I think we'd need to do something like this:

There's a rollbacker group on many wikis and they tend to outnumber admins. In enwiki alone there are more than 6K, though not sure of the percentage that uses mobile.

AMC's history page with concurrent undo/rollback links.

IMG_20190917_065121_973.jpg (1×720 px, 118 KB)

Jdlrobson updated the task description. (Show Details)Sep 18 2019, 10:31 PM

Jdlrobson added a project: good first task.Sep 18 2019, 10:36 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Ammarpad renamed this task from Rollback link on mobile should be enclosed in parentheses to Rollback link on mobile should be styled.Sep 20 2019, 9:50 PM

Ammarpad updated the task description. (Show Details)

Ammarpad merged a task: T233505: AMC should have button for revert option in RC, no just hyperlink.Sep 22 2019, 4:24 AM

Ammarpad added a subscriber: Kizule.

Jdlrobson updated the task description. (Show Details)Sep 24 2019, 4:11 PM

@Alexhollender there are 2 issues here as we see it:

We need to fix the styling of the rollback link so it doesn't look like a plain link but a button and is consistent with the history page.
We want to move the undo and rollback links underneath the tags (based on your mock in T232284#5495762).

number 1 is likely a very easy task but number 2 is a little more tricky and if desired we will need to make some changes in core/desktop.

Jdlrobson moved this task from Upcoming to Needs Analysis on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 24 2019, 4:35 PM

In T232284#5520008, @Jdlrobson wrote:

@Alexhollender there are 2 issues here as we see it:

We need to fix the styling of the rollback link so it doesn't look like a plain link but a button and is consistent with the history page.

We want to move the undo and rollback links underneath the tags (based on your mock in T232284#5495762).

number 1 is likely a very easy task but number 2 is a little more tricky and if desired we will need to make some changes in core/desktop.

Ok well I think it's up to @ovasileva to decide whether or not we want to work on this right now

@alexhollender is it worth doing 1 given its super easy? I assume that is better than the status quo and would make RecentChanges/Contributions consistent with history page. Issue 2 currently impacts history page too.

In T232284#5521141, @Jdlrobson wrote:

@alexhollender is it worth doing 1 given its super easy? I assume that is better than the status quo and would make RecentChanges/Contributions consistent with history page. Issue 2 currently impacts history page too.

I'm not sure I understand what doing #1 looks like without also doing #2? Would it look like this T232284#5497938?

See https://phabricator.wikimedia.org/T232284#5497938 for how 1 looks on history page

Masumrezarock100 subscribed.Sep 25 2019, 3:16 PM

In T232284#5522761, @Jdlrobson wrote:

See https://phabricator.wikimedia.org/T232284#5497938 for how 1 looks on history page

Ok cool, I'm fine with that

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Sep 25 2019, 4:40 PM

Jdlrobson renamed this task from Rollback link on mobile should be styled to Rollback link on mobile should be styled on Special:Watchlist, Special:RecentChanges and Special:Contributions.Sep 27 2019, 12:25 AM

Jdlrobson mentioned this in T225127: Display core version of watchlist page for AMC users.

Change 539595 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Style rollback link on RecentChanges, Contributions and Watchlist

https://gerrit.wikimedia.org/r/539595

gerritbot added a project: Patch-For-Review.Sep 27 2019, 6:06 PM

after above change:

Screenshot 2019-09-27 at 11.05.28 AM.png (601×380 px, 67 KB)

Screenshot 2019-09-27 at 11.02.10 AM.png (468×380 px, 37 KB)

Screenshot 2019-09-27 at 11.02.30 AM.png (419×370 px, 53 KB)

In T232284#5530526, @Jdlrobson wrote:

after above change:

I think it should use OOUI destructive (primary or non-primary) button to indicate that it will revert (destroy) all edits by a user.

This is out of scope for this task.
There is a whole project for the rollback link here https://phabricator.wikimedia.org/project/view/3862/ !

if the rollback link is fixed to use OOUI there, this will just work in mobile/Minerva.

MBinder_WMF edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q2); removed Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1).Sep 30 2019, 5:20 PM

MBinder_WMF moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Sep 30 2019, 5:22 PM

ovasileva set the point value for this task to 2.Oct 1 2019, 4:10 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.

Jdlrobson moved this task from Ready for Development to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 1 2019, 5:01 PM

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 2 2019, 10:54 PM

@alexhollender During code review @nray asks whether the buttons should be the size they are in the history page or the watchlist

history:

contributions:

watchlist:

Change 539595 merged by Jdlrobson:
[mediawiki/skins/MinervaNeue@master] Style rollback link on RecentChanges, Contributions and Watchlist

https://gerrit.wikimedia.org/r/539595

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 3 2019, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2019, 12:10 AM

In T232284#5542797, @Jdlrobson wrote:

@alexhollender During code review @nray asks whether the buttons should be the size they are in the history page or the watchlist

Smaller seems better here

Jdlrobson claimed this task.Oct 7 2019, 5:15 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.

Change 541340 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Consistent undo/rollback links across changelist pages

https://gerrit.wikimedia.org/r/541340

gerritbot added a project: Patch-For-Review.Oct 7 2019, 6:15 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 7 2019, 6:16 PM

Change 541340 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Consistent undo/rollback links across changelist pages

https://gerrit.wikimedia.org/r/541340

@Jdlrobson Should this go into design review or qa next?

@alexhollender please take a look at this on the beta cluster
https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain?action=history
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Contributions/Jdlrobson
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges
https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Watchlist

• nray reassigned this task from Edtadros to • alexhollender_WMF.Oct 10 2019, 6:58 PM

• nray added a subscriber: Edtadros.

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.2; 2019-10-15); removed MW-1.35-notes (1.35.0-wmf.1; 2019-10-08).Oct 10 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 10 2019, 7:10 PM

@Jdlrobson @nray here's what I'm seeing:

History page	Contributions	Recent changes	Watchlist
			didn't see any rollback links

If this is the best we can get without getting into the territory of #2 as mentioned here by @Jdlrobson T232284#5520008, then let's move forward.

We'd need to make some HTML changes to have consistent placement of those buttons. If we want to do that I'd suggest a spike to start off with.

Sounds good - since rollback isn't available to everyone, I think we can live with this. Resolving.

	F30629898: Screen Shot 2019-10-11 at 11.57.12 AM.png
	Oct 11 2019, 4:04 PM

	F30629903: Screen Shot 2019-10-11 at 11.58.11 AM.png
	Oct 11 2019, 4:04 PM

	F30629907: Screen Shot 2019-10-11 at 11.57.59 AM.png
	Oct 11 2019, 4:04 PM

	F30528436: Screenshot 2019-10-02 at 3.55.20 PM.png
	Oct 2 2019, 11:40 PM

	F30484341: Screenshot 2019-09-27 at 11.02.10 AM.png
	Sep 27 2019, 6:22 PM

Rollback link on mobile should be styled on Special:Watchlist, Special:RecentChanges and Special:ContributionsClosed, ResolvedPublic2 Estimated Story PointsActions