Page MenuHomePhabricator
Create Task
Maniphest T232866

VirtualRESTServiceClient returns status code 0 on Docker
Closed, ResolvedPublic
Actions

Description

After upgrading from MW REL 1.32 to REL 1.33 I encountered problems with the VirtualRESTServiceClient. In combination with Docker, it returns status code 0 instead of 200 even though the response-content is intact. I can not reproduce the problem locally. Unfortunately, I have no idea how to further debug this problem. Any help is appreciated...

PS: I am using a slightly modified version of the official MediaWiki Docker images. However, since the official MediaWiki Docker images do not contain VE or Math. I can not test with them. https://github.com/physikerwelt/mediawiki-docker

Details

SubjectRepoBranchLines +/-
Mimic CURLOPT_POST in GuzzleHttpRequestmediawiki/coreREL1_33+26 -0
Mimic CURLOPT_POST in GuzzleHttpRequestmediawiki/coreREL1_34+26 -0
Mimic CURLOPT_POST in GuzzleHttpRequestmediawiki/coremaster+26 -0
Fix support for HTTP/2 in MultiHttpClientmediawiki/coremaster+1 -1
Fix support for HTTP/2 in MultiHttpClientmediawiki/coreREL1_34+1 -1
Fix support for HTTP/2 in MultiHttpClientmediawiki/coreREL1_33+1 -1
Fix support for HTTP/2 in MultiHttpClientmediawiki/coreREL1_32+1 -1
Fix support for HTTP/2 in MultiHttpClientmediawiki/coreREL1_31+1 -1
WIP: MWHttpRequest regression demomediawiki/coreREL1_32+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Physikerwelt created this task.Sep 13 2019, 5:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2019, 5:51 PM
hashar removed a project: docker-pkg.Sep 13 2019, 7:23 PM
hashar subscribed.

https://doc.wikimedia.org/docker-pkg/ is a software to define a fleat of Dockerfile using a templating engine, so unrelated.

• mobrovac added projects: MediaWiki-General, MediaWiki-Containers, Platform Team Workboards (Clinic Duty Team).Sep 16 2019, 10:20 AM
• mobrovac edited projects, added MediaWiki-libs-HTTP; removed MediaWiki-General.Sep 16 2019, 2:47 PM
Physikerwelt added a comment.Sep 20 2019, 3:27 PM

Can this be related to T202352, since we use MultiHttpClient https://github.com/wikimedia/mediawiki-extensions-Math/blob/54d1b77401a250d24a6923193c5c73459a10c2c2/src/MathRestbaseInterface.php#L170 ? I wonder if I am the only one seeing status code 0?

• mobrovac added a comment.Sep 20 2019, 3:35 PM
In T232866#5509545, @Physikerwelt wrote:

Can this be related to T202352, since we use MultiHttpClient https://github.com/wikimedia/mediawiki-extensions-Math/blob/54d1b77401a250d24a6923193c5c73459a10c2c2/src/MathRestbaseInterface.php#L170 ? I wonder if I am the only one seeing status code 0?

This is unlikely the case because the ticket hasn't been implemented yet. Have you tried printing the complete HTTP response you get? How often does it happen? Are there special circumstances in which this occurs?

hashar unsubscribed.Sep 20 2019, 4:04 PM
• kchapman triaged this task as Medium priority.Oct 7 2019, 7:53 PM
daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:56 AM
Physikerwelt mentioned this in T233162: Special:MathStatus tests show a 400 Bad Request error from `http://mathoid.discovery.wmnet:10042`.Nov 15 2019, 9:45 PM
Physikerwelt removed projects: MediaWiki-Containers, RESTBase.Nov 22 2019, 3:24 PM
gerritbot added a comment.Nov 22 2019, 3:28 PM

Change 552527 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/core@master] WIP: MWHttpRequest regression demo

https://gerrit.wikimedia.org/r/552527

gerritbot added a project: Patch-For-Review.Nov 22 2019, 3:28 PM
Physikerwelt added a comment.Nov 22 2019, 3:29 PM

I did some debugging and it seems this is neither related to containers nor related to restbase. I came up with a minimal post request example. While this example uses restbase I also tried accessing mathoid directly from localhost. One idea is, that this might potentially be related to T202352.

gerritbot added a comment.Nov 22 2019, 3:31 PM

Change 552528 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/core@REL1_32] WIP: MWHttpRequest regression demo

https://gerrit.wikimedia.org/r/552528

Physikerwelt added a comment.Nov 22 2019, 3:44 PM

Jenkins confirmed my local experiments. I will try to dig a bit deeper and see if I can trace down the problem.

Physikerwelt added a comment.Nov 22 2019, 5:07 PM

Got it. MW1_32 used php_curl and in particular this line

$this->curlOptions[CURLOPT_POST] = true;

tells libcurl to do a regular HTTP post. This will also make the library use a "Content-Type: application/x-www-form-urlencoded" header. (This is by far the most commonly used POST method). cf. https://curl.haxx.se/libcurl/c/CURLOPT_POST.html

In the new implementation this is missing.
I'll upload the fix soon.

Physikerwelt added a comment.Nov 22 2019, 5:11 PM

Was almost fixed in T211806.

gerritbot added a comment.Nov 22 2019, 6:18 PM

Change 552528 abandoned by Physikerwelt:
WIP: MWHttpRequest regression demo

https://gerrit.wikimedia.org/r/552528

Physikerwelt added a comment.Nov 22 2019, 6:47 PM

Writing the test was actually harder than the fix. However, I could also understand if one considers adding a test middelware to evaluate the request header is overdone. However, the Middleware exists in the library anyhow and I can not imagine another conceptually solid approach.

Physikerwelt mentioned this in T120929: Math extension depends on php5-curl.Nov 25 2019, 1:20 PM
Physikerwelt assigned this task to BPirkle.Nov 25 2019, 1:28 PM
WDoranWMF removed BPirkle as the assignee of this task.Nov 25 2019, 4:26 PM
WDoranWMF moved this task from Backlog to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
WDoranWMF added subscribers: BPirkle, WDoranWMF.

hey @Physikerwelt I'm unassigning @BPirkle as he's working on one of our product teams right now, but I've moved this into our CR pipeline.

Physikerwelt added a comment.Nov 25 2019, 4:51 PM

@WDoranWMF thank you. The CR for the main part is trivial. However, for the testing framework, it would be great to get someone with experience in the Guzzle framework involved.

Physikerwelt merged a task: T233162: Special:MathStatus tests show a 400 Bad Request error from `http://mathoid.discovery.wmnet:10042`.Nov 26 2019, 8:53 AM
Physikerwelt added a subscriber: Kizule.
Physikerwelt mentioned this in T239357: Identify Page-Previews product people.Nov 27 2019, 7:00 PM
Paladox subscribed.EditedNov 30 2019, 9:06 PM

This is either a UBN or a high priority as VisualEditor is broken on debian buster+ based on testing.

MediaWiki version: 1.33 and php version 7.3.

From what i can tell https://github.com/wikimedia/mediawiki-extensions-VisualEditor/commit/9ce8ae05c727694e54c961f3e2dd6a2b60892848#diff-b781650abf89f11630b68fce3d572daeR117 is returning the 'code' = 0.

And from the log when i cherry picked the change + your other one:

2019-11-30 22:35:55 mw2.miraheze.org metawiki: ApiVisualEditor::requestRestbase: Received HTTP 0 from RESTBase for page/html/Miraheze/89991?redirect=false. Trace: #0 /srv/mediawiki/w/extensions/VisualEditor/includes/ApiVisualEditor.php(289): ApiVisualEditor->requestRestbase(Object(Title), 'GET', 'page/html/Mirah...', Array)
#1 /srv/mediawiki/w/includes/api/ApiMain.php(1593): ApiVisualEditor->execute()
#2 /srv/mediawiki/w/includes/api/ApiMain.php(531): ApiMain->executeAction()
#3 /srv/mediawiki/w/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#4 /srv/mediawiki/w/api.php(87): ApiMain->execute()
#5 {main} Response: <!DOCTYPE html>.......(ton more content)

When i curl curl -I https://parsoid-lb.miraheze.org/meta.miraheze.org/v4/page/html/Miraheze/89991?redirect=false i get a good response not a 0. But this only happens on debian buster not debian stretch. So i'm thinking the curl version used has different behaviour?

(Confirmed broken on 2 debian buster instances where as works under 3 stretch instances)

gerritbot added a comment.Dec 1 2019, 5:59 PM

Change 553859 had a related patch set uploaded (by Paladox; owner: Paladox):
[mediawiki/core@master] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553859

gerritbot added a comment.Dec 1 2019, 7:42 PM

Change 553862 had a related patch set uploaded (by Reedy; owner: Paladox):
[mediawiki/core@REL1_34] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553862

gerritbot added a comment.Dec 1 2019, 7:46 PM

Change 553863 had a related patch set uploaded (by Reedy; owner: Paladox):
[mediawiki/core@REL1_33] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553863

gerritbot added a comment.Dec 1 2019, 7:48 PM

Change 553864 had a related patch set uploaded (by Reedy; owner: Paladox):
[mediawiki/core@REL1_32] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553864

gerritbot added a comment.Dec 1 2019, 7:51 PM

Change 553865 had a related patch set uploaded (by Reedy; owner: Paladox):
[mediawiki/core@REL1_31] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553865

gerritbot added a comment.Dec 1 2019, 7:55 PM

Change 553859 merged by jenkins-bot:
[mediawiki/core@master] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553859

gerritbot added a comment.Dec 1 2019, 7:58 PM

Change 553865 merged by jenkins-bot:
[mediawiki/core@REL1_31] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553865

ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 1 2019, 8:00 PM
gerritbot added a comment.Dec 1 2019, 8:00 PM

Change 553864 merged by jenkins-bot:
[mediawiki/core@REL1_32] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553864

gerritbot added a comment.Dec 1 2019, 8:01 PM

Change 553863 merged by jenkins-bot:
[mediawiki/core@REL1_33] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553863

gerritbot added a comment.Dec 1 2019, 8:01 PM

Change 553862 merged by jenkins-bot:
[mediawiki/core@REL1_34] Fix support for HTTP/2 in MultiHttpClient

https://gerrit.wikimedia.org/r/553862

ReleaseTaggerBot added projects: MW-1.32-notes, MW-1.33-notes, MW-1.34-notes.Dec 1 2019, 9:01 PM
gerritbot added a comment.Dec 4 2019, 4:15 PM

Change 552527 merged by jenkins-bot:
[mediawiki/core@master] Mimic CURLOPT_POST in GuzzleHttpRequest

https://gerrit.wikimedia.org/r/552527

gerritbot added a comment.Dec 4 2019, 4:28 PM

Change 554554 had a related patch set uploaded (by Paladox; owner: Physikerwelt):
[mediawiki/core@REL1_34] Mimic CURLOPT_POST in GuzzleHttpRequest

https://gerrit.wikimedia.org/r/554554

gerritbot added a comment.Dec 4 2019, 4:29 PM

Change 554555 had a related patch set uploaded (by Paladox; owner: Physikerwelt):
[mediawiki/core@REL1_33] Mimic CURLOPT_POST in GuzzleHttpRequest

https://gerrit.wikimedia.org/r/554555

gerritbot added a comment.Dec 4 2019, 8:09 PM

Change 554554 merged by jenkins-bot:
[mediawiki/core@REL1_34] Mimic CURLOPT_POST in GuzzleHttpRequest

https://gerrit.wikimedia.org/r/554554

• mobrovac moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Dec 4 2019, 8:14 PM
gerritbot added a comment.Dec 4 2019, 8:29 PM

Change 554555 merged by jenkins-bot:
[mediawiki/core@REL1_33] Mimic CURLOPT_POST in GuzzleHttpRequest

https://gerrit.wikimedia.org/r/554555

Paladox closed this task as Resolved.Dec 18 2019, 6:09 PM

Seems resolved now.

Physikerwelt mentioned this in T248459: Math extension randomly fails in gate-and-submit for Wikibase.Apr 2 2020, 2:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL