Hi, I'd like to request including the localized Wikipedia wordmark in the Silesian version of the mobile frontend. The wordmark is available here:
https://commons.wikimedia.org/wiki/File:Wikipedia_wordmark-szl.svg
Thank you!
Uostofchuodnego | |
Sep 17 2019, 12:20 PM |
F31505971: Screen Shot 2020-01-09 at 11.47.13 AM.png | |
Jan 9 2020, 10:59 AM |
F31505966: Screen Shot 2020-01-09 at 11.41.20 AM.png | |
Jan 9 2020, 10:59 AM |
F30907331: wordmark-slz.svg | |
Oct 29 2019, 1:42 PM |
F30874502: obraz.png | |
Oct 22 2019, 8:46 AM |
F30874495: obraz.png | |
Oct 22 2019, 8:42 AM |
F30872892: Wikipedia_wordmark-szl.svg | |
Oct 21 2019, 1:46 PM |
F30509960: Screen Shot 2019-09-30 at 10.19.20 AM.png | |
Sep 30 2019, 2:19 PM |
F30467927: Wikipedia_wordmark-szl.png | |
Sep 25 2019, 10:32 PM |
Hi, I'd like to request including the localized Wikipedia wordmark in the Silesian version of the mobile frontend. The wordmark is available here:
https://commons.wikimedia.org/wiki/File:Wikipedia_wordmark-szl.svg
Thank you!
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Goal | ovasileva | T242131 [GOAL] Deploy new header to at least one test wiki | ||
Resolved | Jdlrobson | T240856 [EPIC] New header for desktop improvements project | |||
Resolved | JMinor | T132511 [EPIC] iPad support for iOS app | |||
Resolved | JoeWalsh | T132512 Better Feed layout for iPad | |||
Invalid | JoeWalsh | T143398 Update the nav bar on iPad feed | |||
Open | None | T309972 [Goal] prepare desktop improvements project for further deployment | |||
Duplicate | None | T54019 Vectorize all project logos | |||
Open | Spike | None | T244486 [GOAL] Create new logos for all projects for DI header and make sure everyone knows how to use them | ||
Resolved | • alexhollender_WMF | T142426 Create wordmarks for all Wikipedia languages | |||
Resolved | Ammarpad | T233104 Add localized Wikipedia wordmark to the Silesian (szl) mobile frontend |
Change 538408 merged by jenkins-bot:
[operations/mediawiki-config@master] Add localized Wikipedia wordmark for szlwiki
Mentioned in SAL (#wikimedia-operations) [2019-09-23T18:30:55Z] <urbanecm@deploy1001> Synchronized static/images/mobile/copyright/wikipedia-wordmark-szl.svg: SWAT: d397f5f: Add localized Wikipedia wordmark for szlwiki (T233104) (duration: 00m 56s)
Mentioned in SAL (#wikimedia-operations) [2019-09-23T18:35:23Z] <urbanecm@deploy1001> Synchronized wmf-config/VariantSettings.php: SWAT: be2f9d4: Add localized Wikipedia wordmark for szlwiki (T233104) (duration: 00m 55s)
I believe the lack of initial slash in VariantSettings.php is guilty of this.
'copyright' => 'static/images/mobile/copyright/wikipedia-wordmark-szl.svg',
Change 538911 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Typo: Add a slash to szlwiki for wgMinervaCustomLogos
Change 538930 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Revert "Add localized Wikipedia wordmark for szlwiki"
Change 538930 merged by Urbanecm:
[operations/mediawiki-config@master] Revert "Add localized Wikipedia wordmark for szlwiki"
Change 538911 abandoned by Urbanecm:
Typo: Add a slash to szlwiki for wgMinervaCustomLogos
Mentioned in SAL (#wikimedia-operations) [2019-09-25T07:27:20Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: c761ec1: Revert "Add localized Wikipedia wordmark for szlwiki" (T233104) (duration: 01m 16s)
Mentioned in SAL (#wikimedia-operations) [2019-09-25T07:28:40Z] <urbanecm@deploy1001> Synchronized static/images/mobile/copyright/: c761ec1: Revert "Add localized Wikipedia wordmark for szlwiki" (T233104) (duration: 01m 04s)
Change 539052 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Add wgMinervaCustomLogos for szlwiki
@Jdlrobson sorry for the delay. The SVG looks good. I've added a higher resolution PNG to the task description.
Change 539052 merged by jenkins-bot:
[operations/mediawiki-config@master] Add wgMinervaCustomLogos for szlwiki
Mentioned in SAL (#wikimedia-operations) [2019-09-26T11:07:48Z] <urbanecm@deploy1001> Synchronized static/images/mobile/copyright/wikipedia-wordmark-szl.png: SWAT: 96bba4c: Add wgMinervaCustomLogos for szlwiki (T233104; 1/3) (duration: 01m 08s)
Mentioned in SAL (#wikimedia-operations) [2019-09-26T11:13:06Z] <urbanecm@deploy1001> Synchronized static/images/mobile/copyright/wikipedia-wordmark-szl.svg: SWAT: 96bba4c: Add wgMinervaCustomLogos for szlwiki (T233104; 2/3) (duration: 01m 05s)
Mentioned in SAL (#wikimedia-operations) [2019-09-26T11:14:21Z] <Urbanecm> Purge https://en.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-szl.svg (T233104)
Mentioned in SAL (#wikimedia-operations) [2019-09-26T11:16:26Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: 96bba4c: Add wgMinervaCustomLogos for szlwiki (T233104; 3/3) (duration: 01m 05s)
Our designer should check the result and resolve this ticket.
Looks all good. I went ahead and asked an admin to full protect the file on Commons.
Am not sure why this is necessary. We don't serve the image directly from Commons so this is not a source of vandalism if you are worried about that :-).
I know. But this logo is being used on sale wiki's main page (see it's Global usage). I am done working with the SVG anyway, and it doesn't look like any other work on the file is necessary. So why thought why not.
@Jdlrobson the size and alignment look a bit off (assuming I'm supposed to be checking production?). I haven't taken a close look at how we render logos in the header so feel free to pass this back to me if you want more notes before working more on it.
@alexhollender @Masumrezarock100 just wanted an update with this task. There is a logo but we're not happy with it. If we want to change it we should probably open a new bug or repurpose this one as this bug is confusing as written.
Options at this point include
Regarding it's resolution, we could easily change it if we add width and height parameter to SVG tag. English Wikipedia's wordmark has a viewport of 116x18. But I am afraid changing it's dimension might be a little too hard, and I'd rather let an experienced designer handle it.
@Jdlrobson Feel free to.
My understanding is that the width and height don't need to be changed in the SVG itself but the config.
ie. the numbers in https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/538408/8/wmf-config/VariantSettings.php,unified
I've checked in with the design team about how we usually create these. Here is an updated SVG to use at the proper dimensions:
width = 118px
height = 22px
@alexhollender Thanks. I have cleaned up some code and minified the SVG. Now at https://upload.wikimedia.org/wikipedia/commons/archive/b/bd/20191021172612%21Test.svg
Yup, the same thing happened to the SVG of T200870. New ones are badly redrawn. We'll need work on these SVGs more. @alexhollender We might need to roll back to how the SVG was. Back to square one.
@Masumrezarock100 @Uostofchuodnego my apologies for the problematic SVG and the delay in responding (I was having a difficult time figuring out what the issue was). I think the issues are fixed now, can you please take a look at this SVG:
I don't understand which character resembles "U", and how could the alignment be improved?
Nevermind. I said something stupid. I am not really familiar with Silesian alphabets.
Change 557584 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[operations/mediawiki-config@master] Re-add localized Wikipedia wordmark for szlwiki
Hi @alexhollender, we also don't have szl.wiki on Beta cluster so you've to actually review it only on production or do it locally. The patch was also not deployed (I am not sure why).
Below, I compared the old patch which was deployed on Sept. 26; see T233104#5525573 with the new patch which is yet to be merged/deployed
The old patch is the current image on production https://szl.m.wikipedia.org/, both screenshots were taken on 320 x 611 resolution.
Old patch 539052 | New patch 539052 |
@Ammarpad thanks for the screenshots. It looks great and I think this is sufficient for testing.
Change 557584 merged by jenkins-bot:
[operations/mediawiki-config@master] Re-add localized Wikipedia wordmark for szlwiki
Mentioned in SAL (#wikimedia-operations) [2020-02-03T12:29:12Z] <urbanecm@deploy1001> Synchronized static/images/mobile/copyright/: SWAT: 76e67cd: e266e25: Add static wordmarks for szlwiki and etwiki (T233104, T230379) (duration: 01m 06s)
Mentioned in SAL (#wikimedia-operations) [2020-02-03T12:30:41Z] <urbanecm@deploy1001> Synchronized static/images/mobile/copyright/: SWAT: 76e67cd: e266e25: Add wordmarks for szlwiki and etwiki (T233104, T230379) (duration: 01m 06s)
Mentioned in SAL (#wikimedia-operations) [2020-02-03T12:31:59Z] <Urbanecm> Purge https://en.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-szl.svg (T233104)