Namespace definitions for Hindi Wikisource need to be in the ProofreadPage extension, not in VariantSettings.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	jhsoby
	Sep 19 2019, 8:44 PM

Description

The namespace names for the page and index namespaces need to be in ProofreadPage.namespaces.php, not in VariantSettings.php (currently at line 3902 onwards). I would submit patches for this myself, but I have a new computer and haven't set up Git yet.

I believe this should be fixed before content can be imported, to avoid namespace problems akin to the ones we had with napwikisource.

(Semi-unrelated note: Why doesn't the hiwikisource settings in VariantSettings.php have the + in front of hiwikisource, like all other projects do?)

Details

	Subject	Repo	Branch	Lines +/-
	Add NS translation for hi	mediawiki/extensions/ProofreadPage	master	+8 -0
	Redefine hiwikisource extra namespaces	operations/mediawiki-config	master	+2 -6

Customize query in gerrit

Related Objects

Mentioned In: T218155: Create Wikisource Hindi
Mentioned Here: rOMWC37fcbdf025cb: Fix: Move hiwikisource's extra namespace to extra namespace section
T218155: Create Wikisource Hindi
T230541: Remove duplicate namespace definition for napwikisource

Event Timeline

jhsoby created this task.Sep 19 2019, 8:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2019, 8:44 PM

jhsoby added a subscriber: Urbanecm.Sep 19 2019, 8:44 PM

jhsoby renamed this task from Namespace definitions for Hindi Wikisource should be in the ProofreadPage extension, not in VariantSettings.php to Namespace definitions for Hindi Wikisource need to be in the ProofreadPage extension, not in VariantSettings.php.Sep 20 2019, 8:57 AM

Peachey88 subscribed.Sep 20 2019, 11:27 PM

Change 538695 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/ProofreadPage@master] Add NS translation for hi

https://gerrit.wikimedia.org/r/538695

gerritbot added a project: Patch-For-Review.Sep 23 2019, 7:05 PM

Change 538697 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Redefine hiwikisource extra namespaces

https://gerrit.wikimedia.org/r/538697

Urbanecm claimed this task.Sep 23 2019, 7:14 PM

Restricted Application added a project: User-Urbanecm. · View Herald TranscriptSep 23 2019, 7:14 PM

Change 538697 merged by jenkins-bot:
[operations/mediawiki-config@master] Redefine hiwikisource extra namespaces

https://gerrit.wikimedia.org/r/538697

Site request part was done

Mentioned in SAL (#wikimedia-operations) [2019-09-23T19:16:42Z] <urbanecm@deploy1001> Synchronized wmf-config/VariantSettings.php: 2a7a125: Redefine hiwikisource extra namespaces (T233365) (duration: 00m 57s)

I've removed the extra-extra namespace, and uploaded a patch against ProofreadPage that readds the namespace correctly. I've also moved the extra namespaces section to correct part of VS.php in 37fcbdf. Thanks for noticing that!

Thank you very much, @Urbanecm! The ProofreadPage part has already been uploaded by @Tpt though, here. The task mentioned was the one for creating the wiki, so it doesn't appear here. ~~It still needs to be merged though, I don't know who can do that.~~ (Update: It has now been merged.)