Page MenuHomePhabricator
Create Task
Maniphest T234026

Deploy AMC contextual hooks modal
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Description

In T226069: AMC Outreach - contextual hooks via new Drawer (showing AMC optin drawer within workflows) we built a modal that lets people know about AMC when they perform certain actions. We would now like to turn it on.

User Story

As a mobile editor, I would like to know that advanced mode exists so that I can opt in

Dev notes

Patch at https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/541853/

QA Steps

In an incognito window where you are logged in with AMC disabled you can trigger the modal

  • Confirm that the Outreach drawers show on English Wikivoyage/MediaWiki when you click talk, history link or mobile view
  • Confirm that the dialogs show on English Wikipedia when you click talk, history link or mobile view (blocked until late Thursday/Friday when train has run)

Acceptance criteria

  • Deploy contextual hooks modal for all Wikipedias

Details

SubjectRepoBranchLines +/-
Turn on Amc Outreach Modal (contexual hooks campaign)operations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva created this task.Sep 27 2019, 10:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2019, 10:21 AM
ovasileva triaged this task as High priority.Sep 27 2019, 10:21 AM
ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.
ovasileva added a subtask: T226069: AMC Outreach - contextual hooks via new Drawer (showing AMC optin drawer within workflows).
Masumrezarock100 subscribed.Sep 27 2019, 2:08 PM
MBinder_WMF edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q2); removed Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1).Sep 30 2019, 5:19 PM
ovasileva moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 1 2019, 9:18 AM
ovasileva set the point value for this task to 2.Oct 1 2019, 4:06 PM
Jdlrobson moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 1 2019, 4:56 PM
Jdlrobson moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 2 2019, 9:55 PM
Jdlrobson moved this task from Ready for Development to Blocked on Others on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.
ovasileva closed subtask T226069: AMC Outreach - contextual hooks via new Drawer (showing AMC optin drawer within workflows) as Resolved.Oct 9 2019, 11:34 AM
ovasileva moved this task from Blocked on Others to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.
gerritbot added a comment.Oct 9 2019, 4:48 PM

Change 541853 had a related patch set uploaded (by Nray; owner: Nray):
[operations/mediawiki-config@master] Turn on Amc Outreach Modal (contexual hooks campaign)

https://gerrit.wikimedia.org/r/541853

gerritbot added a project: Patch-For-Review.Oct 9 2019, 4:48 PM
• nray updated the task description. (Show Details)Oct 9 2019, 4:49 PM
Jdlrobson added a project: Wikimedia-Site-requests.Oct 9 2019, 5:13 PM
Jdlrobson moved this task from Ready for Development to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.
Restricted Application added a subscriber: Dereckson. · View Herald TranscriptOct 9 2019, 5:13 PM
gerritbot added a comment.Oct 9 2019, 11:08 PM

Change 541853 merged by jenkins-bot:
[operations/mediawiki-config@master] Turn on Amc Outreach Modal (contexual hooks campaign)

https://gerrit.wikimedia.org/r/541853

Maintenance_bot removed a project: Patch-For-Review.Oct 9 2019, 11:10 PM
Stashbot added a comment.Oct 9 2019, 11:17 PM

Mentioned in SAL (#wikimedia-operations) [2019-10-09T23:17:17Z] <catrope@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Turn on AMC outreach modal (T234026) (duration: 00m 59s)

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 9 2019, 11:25 PM
Jdlrobson updated the task description. (Show Details)
Edtadros claimed this task.Oct 14 2019, 5:07 PM
Edtadros reassigned this task from Edtadros to Jdlrobson.Oct 15 2019, 4:20 PM
Edtadros added subscribers: Jdlrobson, Edtadros.

@Jdlrobson I may have claimed this task too soon. I'm unable to get a modal to appear in enwiki.

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Oct 15 2019, 4:53 PM
Jdlrobson updated the task description. (Show Details)

^ @Edtadros QA steps missed out a vital piece of information. Hope that helps!

Edtadros reassigned this task from Edtadros to Jdlrobson.Oct 16 2019, 2:09 PM

@Jdlrobson I think we talked about moving this to ready for signoff because I didn't have 100+ edits to test it. Is this correct?

Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q2) board.Oct 16 2019, 2:31 PM

Confirmed. I am seeing the dialog so it appears to be working.

ovasileva closed this task as Resolved.Oct 21 2019, 10:23 AM

Works for me as well, resolving

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits