Page MenuHomePhabricator

Remove 'editToken' from mw.user.tokens (deprecated for 'csrfToken')
Closed, ResolvedPublic

Description

It's been some 3 years since this became obsolete.

The editToken key of mw.users.tokens has been replaced by csrfToken since 298cf413dbc3fa4e (MediaWiki 1.27, released 2016).

The primary user of it, mediawiki.api was already migrated in the same commit. This means code using mw.Api#getToken('edit') will continue to work and is already using the new csrfToken key underneath.

What we need to migrate still is anything that uses editToken directly via mw.user.tokens.

Let's update whatever is using this in tarballed/WMF extensions and remove it from the payload.

Details

Related Gerrit Patches:

Event Timeline

Change 540732 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Remove 'editToken' from mw.user.tokens

https://gerrit.wikimedia.org/r/540732

Change 541087 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] selenium: Stop using editToken

https://gerrit.wikimedia.org/r/541087

Change 540732 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Remove 'editToken' from mw.user.tokens

https://gerrit.wikimedia.org/r/540732

Change 541087 abandoned by Ladsgroup:
selenium: Stop using editToken

Reason:
oh alright then.

https://gerrit.wikimedia.org/r/541087

Krinkle closed this task as Resolved.Oct 8 2019, 7:00 PM
Krinkle claimed this task.