Page MenuHomePhabricator

ProtectionForm::buildForm is deprecated in favor of ProtectionForm::addFormFields
Closed, ResolvedPublic

Description

As part of the OOUI-ification of the protection form we will need to change the function signature of the hook ProtectionForm::buildForm in a similar way to how we changed the function signature of SpecialContributions::getForm::filters

according to https://codesearch.wmflabs.org/search/?q=ProtectionForm%3A%3AbuildForm&i=nope&files=&repos=
We will need some cooperation from the following extensions:

  • FlaggedRevs
  • ArticleFeedbackv5
  • mediawiki-PageProtect

This will follow the deprecation policy.
A deprecation notice has been added for 1.35.

Related Objects

Event Timeline

Change 581878 had a related patch set uploaded (by VolkerE; owner: BrandonXLF):
[mediawiki/core@master] WIP: Use OOUI for protection form

https://gerrit.wikimedia.org/r/581878

Change 581878 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/core@master] Use OOUI for protection form

https://gerrit.wikimedia.org/r/581878

Jdlrobson added subscribers: BrandonXLF, matmarex.

Hey @BrandonXLF sorry that's it's taken so long to look into this. Were you hoping to get this into 1.35 ?

@Volker_E @matmarex what do you think?

@Jdlrobson @matmarex I'd be in for this, but it's also clear that all Desktop Improvements have priority for me over this and we basically have just 1.5(?) weeks left…

@Jdlrobson Yes I was, but if it's not feasible, then that's okay.

ovasileva triaged this task as Medium priority.Jul 7 2020, 3:36 PM
ovasileva moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.

Change 581878 merged by jenkins-bot:
[mediawiki/core@master] Use OOUI for protection form

https://gerrit.wikimedia.org/r/581878

Putting on board for visibility.
I'll own making sure any issues that arise because of this get addressed

Change 663327 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/extensions/FlaggedRevs@master] Use OOUI for action=protect form

https://gerrit.wikimedia.org/r/663327

Please fix flagged revisions asap as I cannot modify pending changes protection on EnWiki

Change 663327 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use OOUI for action=protect form

https://gerrit.wikimedia.org/r/663327

Volker_E updated the task description. (Show Details)