ProtectionForm::buildForm is deprecated in favor of ProtectionForm::addFormFields
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 22 2019, 11:25 PM

Description

As part of the OOUI-ification of the protection form we will need to change the function signature of the hook ProtectionForm::buildForm in a similar way to how we changed the function signature of SpecialContributions::getForm::filters

according to https://codesearch.wmflabs.org/search/?q=ProtectionForm%3A%3AbuildForm&i=nope&files=&repos=
We will need some cooperation from the following extensions:

FlaggedRevs
ArticleFeedbackv5
mediawiki-PageProtect

This will follow the deprecation policy.
A deprecation notice has been added for 1.35.

Details

	Subject	Repo	Branch	Lines +/-
	Use OOUI for action=protect form	mediawiki/extensions/FlaggedRevs	master	+93 -125
	Use OOUI for protection form	mediawiki/core	master	+459 -231

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open		None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Open		None	T100161 Convert all of MediaWiki core to OOUI PHP (tracking)
Resolved		matmarex	T101480 Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path
Invalid		None	T101471 Convert core forms that use MW UI with wgUseMediaWikiUIEverywhere false to OOUI FormSpecialPage or explicit OOUI PHP
Resolved		Jdlrobson	T235424 Convert action=protect to OOUI (protect form is unusable on mobile)
Resolved		Jdlrobson	T236218 ProtectionForm::buildForm is deprecated in favor of ProtectionForm::addFormFields
Resolved	PRODUCTION ERROR	None	T274889 Use of ProtectionForm::buildForm hook (used in FlaggedRevsUIHooks::onProtectionForm) was deprecated in MediaWiki 1.36

Event Timeline

Jdlrobson created this task.Oct 22 2019, 11:25 PM

Jdlrobson removed projects: Web-Team-Backlog (Kanbanana-2019-20-Q2), MobileFrontend.

Jdlrobson mentioned this in T235424: Convert action=protect to OOUI (protect form is unusable on mobile).Oct 22 2019, 11:29 PM

Change 581878 had a related patch set uploaded (by VolkerE; owner: BrandonXLF):
[mediawiki/core@master] WIP: Use OOUI for protection form

https://gerrit.wikimedia.org/r/581878

gerritbot added a project: Patch-For-Review.Mar 20 2020, 3:45 AM

Change 581878 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/core@master] Use OOUI for protection form

https://gerrit.wikimedia.org/r/581878

Hey @BrandonXLF sorry that's it's taken so long to look into this. Were you hoping to get this into 1.35 ?

@Volker_E @matmarex what do you think?

@Jdlrobson @matmarex I'd be in for this, but it's also clear that all Desktop Improvements have priority for me over this and we basically have just 1.5(?) weeks left…

@Jdlrobson Yes I was, but if it's not feasible, then that's okay.

ovasileva triaged this task as Medium priority.Jul 7 2020, 3:36 PM

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson moved this task from Backlog to Triaged on the Advanced Mobile Contributions board.Dec 10 2020, 11:08 PM

Kizule added a subscriber: Hexmode.Feb 2 2021, 5:44 PM

Change 581878 merged by jenkins-bot:
[mediawiki/core@master] Use OOUI for protection form

https://gerrit.wikimedia.org/r/581878

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 2 2021, 6:00 PM

Putting on board for visibility.
I'll own making sure any issues that arise because of this get addressed

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 2 2021, 8:50 PM

Change 663327 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/extensions/FlaggedRevs@master] Use OOUI for action=protect form

https://gerrit.wikimedia.org/r/663327

• mmodell mentioned this in T274889: Use of ProtectionForm::buildForm hook (used in FlaggedRevsUIHooks::onProtectionForm) was deprecated in MediaWiki 1.36.Feb 16 2021, 3:00 PM

• mmodell added a subtask: T274889: Use of ProtectionForm::buildForm hook (used in FlaggedRevsUIHooks::onProtectionForm) was deprecated in MediaWiki 1.36.Feb 16 2021, 3:06 PM